[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575873009 Hi @skylook , could you update your copyright on the file listed as No. 7 above? `./example/image-classification/predict-cpp/image-classification-predict.cc` This file was contributed by you before MXNet was donated to Apache Software Foundation. This file only has your copyright, but there is no license. The Apache Software Foundation does not require individual copyright notice from contributors. If you choose to license this file under Apache-2.0, do you mind adding the license ? If you do not want to license using Apache-2.0, please also state in the file which license you want. It seems the CPP package are licensed under Apache-2.0, you can add the same text on top of this file. https://github.com/apache/incubator-mxnet/blob/master/cpp-package/LICENSE Thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575873009 Hi @skylook , could you update your copyright on the file listed as No. 7 above? `./example/image-classification/predict-cpp/image-classification-predict.cc` This file was contributed by you before MXNet was donated to Apache Software Foundation. This file only has your copyright, but there is no license. The Apache Software Foundation does not require individual copyright notice from contributors. If you choose to license this file under Apache-2.0 as a ASF contributor, do you mind removing this copyright notice and make an update? If you do not want to license using Apache-2.0, please also state in the file which license you want. Thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-575294965 > @roywei Regarding [3], [4], do you think we need list the copyrights/license in MXNet top LICENSE file or ask MKL-DNN itself to change? I noticed that in the latest version of MKL-DNN, it already added MathJax copyrights/license to its LICENSE file. See https://github.com/intel/mkl-dnn/blob/master/LICENSE#L352 Hi @TaoLv , yes, the existing MathJax is for the docs file, we need to also include mkldnn part(add additional file path that use the same license). Basically for all newly added source files, if there is a different license or copyright statement (different than the Apache contributor copyright) we need to state in the top level license file clearly: which file used what license and what’s the copyright. So we also need to list all files or file paths that has intel copyright This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574913499 > @roywei thanks. When removing the ASF header from incubator-mxnet/cmake/Modules/FindCUDAToolkit.cmake, how to pass the RAT license check? There is no `.rat-excludes` files in the mxnet repository. How to exclude the file? here it is: https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/apache_rat_license_check/rat-excludes It's used by CI step here: https://github.com/apache/incubator-mxnet/blob/master/ci/docker/runtime_functions.sh#L1457 More reference and history: https://cwiki.apache.org/confluence/display/MXNET/MXNet+Source+Licenses This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574909620 > > @hzfan @reminisce @haojin2 Looks like we need to remove the ASF header if this file is directly copied from numpy, and add it to whitelist of the header check. > > https://github.com/apache/incubator-mxnet/blob/master/src/operator/numpy/np_einsum_op-inl.h > > @roywei The file includes modifications, such as > > https://github.com/apache/incubator-mxnet/blob/bd67723da96e6d36e72c9a42535a4fe68f234a71/src/operator/numpy/np_einsum_op-inl.h#L1088 > > It seems valid to re-license the file under Apache license given that the original license header is included. (Above link suggests this approach is not recommended though) > > If we choose not to relicense files with minor modifications, https://github.com/apache/incubator-mxnet/blob/master/cmake/Modules/FindCUDAToolkit.cmake also needs to be updated to remove the ASF header. > The file contains the following minor modifications > > https://github.com/apache/incubator-mxnet/blob/bd67723da96e6d36e72c9a42535a4fe68f234a71/cmake/Modules/FindCUDAToolkit.cmake#L713-L715 I'll leave the authors to decide whether to add Apache license if it's modified by MXNet contributors. Either way, we also need to acknowledge the original License and CopyRight in the [LICENSE](https://github.com/apache/incubator-mxnet/blob/master/LICENSE) file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
roywei edited a comment on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574829986 @PatricZhao could you help with the "Copyright 2019 Intel Corporation” and 3 and 4 under mkldnn? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
