[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-12-11 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-446253481 @larroy This PR just fixes a broken existing feature. Why do we need cython? We may have some performance gain. Here is the copy of a qu

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-11-19 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-440091940 Any discussion on the last change? Or can we get this PR merged? This i

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-11-07 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-436900249 #12160 looks like delayed too much. The issue is that the cmake build with llvm openmp causes a segfault in the CI environment. The segf

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-10-09 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-428091496 @vrakesh I'm still waiting on #12160. I'll update this PR to resolve the conflict and make sure that it passes the tests after #12160 is

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-08-14 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-412778840 It looks like that the segmentation fault from the cmake build is related to #11417. [Here](https://github.com/apache/incubator-mxnet/i

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-08-04 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-410495113 - We need to build cython modules for both of python2 and python3. Once the two builds are successful, I think we don't strictly need to

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-08-01 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-409782946 @apeforest My preference is the current way of using two env variables. I think it's not so confusing. My confusion was because there wa

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-08-01 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-409491960 For a quick benchmark I have run `example/gluon/image_classification.py` with `--model=resnet50_v1 --dataset=cifar10` on a machine with

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-07-31 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-409469161 Would you please merge this PR if there is no problem? This is an autom

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-19 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-398577395 I removed the use of the cython modules from the Cent OS environments as @marcoabreu requested. Now "CPU: Openblas" and "GPU: Cuda 9.1"

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-19 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-398307755 A way to check whether or not cython is actually used at runtime is seeing `mx.nd._internal.NDArrayBase`. It must be `mxnet._cy3.ndarray

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-16 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397175348 ```bash make make cython cd python # `pip install -e .` or export PYTHONPATH=my_installation_dir python setup.py i

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-16 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397852430 I added the cython build to Python3 CentOS 7 CPU and GPU environments. I have made an intentional bug in the cython module and confirmed

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-16 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397852430 I added the cython build to Python3 CentOS 7 CPU and GPU environments. I have made an intentional bug in the cython module and confirmed

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-16 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397852430 I added the cython build to Python3 CentOS 7 CPU and GPU environments. I have made an intentional bug in the cython module and confirmed

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-13 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397175348 ```bash make cd python make cython # pip install or export PYTHONPATH=my_installation_dir python setup.py inst

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-13 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397175348 ```bash make cd python make cython # pip install or export PYTHONPATH=my_installation_dir python setup.py inst

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-13 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397172463 @marcoabreu Thank you. First, I'm just not sure what is the best way to add a cython build to CI. There are already many environments. W

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-13 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397172463 @marcoabreu Thank you. First, I'm just not sure what is the best way to add a cython build to CI. There are already many environments. W

[GitHub] asitstands commented on issue #10951: [MXNET-545] Fix broken cython build

2018-06-13 Thread GitBox
asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397151382 @piiswrong @szha @marcoabreu Would you review this PR? This is an autom