[GitHub] lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET

2018-08-09 Thread GitBox
lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-411782278 There might be additional changes needed to make CUDA usable with cmake https://github.com/apache/incubator-mxnet/issues/12107 --

[GitHub] lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET

2018-04-16 Thread GitBox
lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-381669082 I think this is indeed a very good change. I am sure that there are alternatives to hardcoding things into CMakeLists.txt with documen