[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-06 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r172750286 ## File path: src/ndarray/ndarray_function-inl.h ## @@ -446,6

[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-06 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r172749967 ## File path: src/ndarray/ndarray.cc ## @@ -805,15 +808,71 @@

[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-01-31 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r165179254 ## File path: src/ndarray/ndarray_function-inl.h ## @@ -47,6

[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-01-31 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r165179017 ## File path: src/ndarray/ndarray.cc ## @@ -270,15 +274,72 @@

[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-01-31 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r165178744 ## File path: src/ndarray/ndarray.cc ## @@ -246,16 +246,20 @@

[GitHub] piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-01-31 Thread GitBox
piiswrong commented on a change in pull request #9029: Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r165178480 ## File path: src/ndarray/ndarray_function-inl.h ## @@ -433,6