Re: [PR] newt: Add external repos patches support [mynewt-newt]

2024-04-05 Thread via GitHub
kasjer merged PR #550: URL: https://github.com/apache/mynewt-newt/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] newt: Add external repos patches support [mynewt-newt]

2024-04-05 Thread via GitHub
kasjer commented on PR #550: URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039548839 Verified to work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] newt: Add external repos patches support [mynewt-newt]

2024-04-05 Thread via GitHub
m-gorecki commented on PR #550: URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039539957 @kasjer Fix applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] newt: Add external repos patches support [mynewt-newt]

2024-04-05 Thread via GitHub
kasjer commented on PR #550: URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039452695 When patch fails affected git repository stays in state that `git am --abort` or `git am --skip` are required. Maybe newt could call `git am --abort` as not to leave git in the middle

Re: [PR] newt: Add external repos patches support [mynewt-newt]

2024-04-03 Thread via GitHub
sjanc commented on code in PR #550: URL: https://github.com/apache/mynewt-newt/pull/550#discussion_r1549381073 ## newt/downloader/downloader.go: ## @@ -451,6 +455,16 @@ func (gd *GenericDownloader) Checkout(repoDir string, commit string) error { return err } +func