[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-563023887 @sijie PTAL. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-563016308 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-561937849 @sijie PTAL. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-561937689 run java8 tests run integration tests run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-561098054 @sijie I add a new method `wrap` to wrap the exception to enriching the exception message info. The wrap method will get the exception and wrap the old exception with the same type of the exception, so I can add more message info to the exception. I run the test that failed before, it can be passed on my laptop. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558874357 Yes. There are many exceptions thrown by `ClientCnx`. In `ClientCnx`, it using a map to save `requestId` and CompleableFuture. And the `requestId` is generated from other places like `ConsumerImpl` or `ProducerImpl` or `LookupService`. Should I pass the topic name from the `Consumerimpl` and combine it with `requestId`? If so I can get the topic name or other information when the future complete exceptionally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558706669
@sijie
There are two ways when we threw an Exception.
One is we get an exception and throw it out.
```
future.exceptionally(e -> {
anotherFuture.completeExceptionally(e)
})
```
Another is we wrap the exception with the `PulsarClientException`.
```
future.exceptionally(e -> {
anotherFuture.completeExceptinoally(new PulsarClientException())
})
```
If the exception belongs to the second one, I can add the info message
easily. Otherwise, I think it has a risk to update the Exception If I don't
know the exception is caught by others for retrying or do something others.
How do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558431290 The unit test seems failed caused by my fix. I am fixing the test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
