[GitHub] HaraldGustafsson opened a new issue #1633: Admin REST-API from a python client

2018-04-23 Thread GitBox
HaraldGustafsson opened a new issue #1633: Admin REST-API from a python client URL: https://github.com/apache/incubator-pulsar/issues/1633 Expected behavior I set up a standalone pulsar broker with SSL authentication and authorisation. I'm trying to write a python 3

[GitHub] maskit commented on issue #1266: Pass all Apache Podling Website Checks

2018-04-23 Thread GitBox
maskit commented on issue #1266: Pass all Apache Podling Website Checks URL: https://github.com/apache/incubator-pulsar/issues/1266#issuecomment-383565282 @lucperkins As I wrote on my last comment, we have an event page but we haven't passed the check because the check is a bit strict. It

[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-23 Thread GitBox
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-383371863 retest this please for Integration Tests.

[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-23 Thread GitBox
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-383442060 retest this please

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383623164 Thanks @ivankelly for the comments, changed following your comments and add the logic for reading back.

[GitHub] lucperkins commented on issue #1632: Avoid creating different message object for pulsar sink connector

2018-04-23 Thread GitBox
lucperkins commented on issue #1632: Avoid creating different message object for pulsar sink connector URL: https://github.com/apache/incubator-pulsar/pull/1632#issuecomment-383661997 Big +1 to this. I was working on an example connector last week and found the doubled implementation odd.

[GitHub] jai1 closed issue #1631: Fixes for patch release 1.22.1

2018-04-23 Thread GitBox
jai1 closed issue #1631: Fixes for patch release 1.22.1 URL: https://github.com/apache/incubator-pulsar/issues/1631 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] jai1 commented on issue #1631: Fixes for patch release 1.22.1

2018-04-23 Thread GitBox
jai1 commented on issue #1631: Fixes for patch release 1.22.1 URL: https://github.com/apache/incubator-pulsar/issues/1631#issuecomment-383667217 Closing this issue - using a new project to track the tasks. This is an

[GitHub] lucperkins closed pull request #1263: FAQ page template (WIP)

2018-04-23 Thread GitBox
lucperkins closed pull request #1263: FAQ page template (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1263 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] lucperkins commented on issue #1263: FAQ page template (WIP)

2018-04-23 Thread GitBox
lucperkins commented on issue #1263: FAQ page template (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1263#issuecomment-383673086 I'm going to close this for now. If we decided we want to templating the FAQ page later on I'm happy to revive this.

[GitHub] jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183611828 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageRecordImpl.java

[GitHub] merlimat opened a new pull request #1635: Also look for the '_static' suffix when searching for libjsoncpp.a

2018-04-23 Thread GitBox
merlimat opened a new pull request #1635: Also look for the '_static' suffix when searching for libjsoncpp.a URL: https://github.com/apache/incubator-pulsar/pull/1635 ### Motivation Newer versions of Homebrew have the JSONCpp static library installed as `libjsoncpp_static.a`

[GitHub] merlimat opened a new pull request #1634: In pulsar admin Java API, unified persistent vs non-persistent into "topics()"

2018-04-23 Thread GitBox
merlimat opened a new pull request #1634: In pulsar admin Java API, unified persistent vs non-persistent into "topics()" URL: https://github.com/apache/incubator-pulsar/pull/1634 ### Motivation There's a split in the Java admin API between `persistent` and `non-persistent` topics

[GitHub] merlimat closed pull request #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option

2018-04-23 Thread GitBox
merlimat closed pull request #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option URL: https://github.com/apache/incubator-pulsar/pull/1608 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option (#1608)

2018-04-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9947f74 Fixed typo in

[GitHub] sijie commented on issue #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
sijie commented on issue #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#issuecomment-383766743 @jerrypeng @srkukarni - please review this @zhaijack - please also review this, since I am touching `TopicMessageImpl`

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383760988 retest this please This is an automated message from the Apache

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383760988 retest this please for `org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition`

[GitHub] sijie opened a new pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
sijie opened a new pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636 *Motivation* Having two different `Message` interfaces is a bit confusing and also introduced unnecessary object allocation.

[GitHub] sijie closed pull request #1635: Also look for the '_static' suffix when searching for libjsoncpp.a

2018-04-23 Thread GitBox
sijie closed pull request #1635: Also look for the '_static' suffix when searching for libjsoncpp.a URL: https://github.com/apache/incubator-pulsar/pull/1635 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Also look for the '_static' suffix when searching for libjsoncpp.a (#1635)

2018-04-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new dd601b7 Also look for the '_static'

[GitHub] sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183609200 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageRecordImpl.java

[GitHub] jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183586587 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageRecordImpl.java

[GitHub] jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183587224 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java

[GitHub] jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
jerrypeng commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183611320 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java

[GitHub] sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-23 Thread GitBox
sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183609303 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ##

[incubator-pulsar] branch master updated: Add a integration test for create subscription CLI command (#1613)

2018-04-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2ac2b5c Add a integration test for

[GitHub] merlimat closed pull request #1613: Add a integration test for create subscription CLI command

2018-04-23 Thread GitBox
merlimat closed pull request #1613: Add a integration test for create subscription CLI command URL: https://github.com/apache/incubator-pulsar/pull/1613 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of