[incubator-pulsar] branch asf-site updated: Updated site at revision e6bcae5

2018-05-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 57f66c2 Updated site at revision

[GitHub] ivankelly opened a new pull request #1805: Expose offload deletion lag in broker configuration

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1805: Expose offload deletion lag in broker configuration URL: https://github.com/apache/incubator-pulsar/pull/1805 With this configuration, the administrator can configure how long the bookkeeper ledger will be kept around after a ledger has been

[GitHub] srkukarni commented on issue #1816: Removed internal shading

2018-05-18 Thread GitBox
srkukarni commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-390377859 retest this please This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on issue #1805: Expose offload deletion lag in broker configuration

2018-05-18 Thread GitBox
ivankelly commented on issue #1805: Expose offload deletion lag in broker configuration URL: https://github.com/apache/incubator-pulsar/pull/1805#issuecomment-390214399 retest this please // org.apache.pulsar.broker.service.ReplicatorGlobalNSTest.setup &

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-18 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-390265202 I have a couple more comments: - Rename `MessageBuilder` to a `ProducerMessage` since it is no longer implements a builder pattern? - It

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-18 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-390269446 A couple more observations: - There should be control over logging, either turning it off or provide an interface to wrap it somehow so the

[GitHub] ivankelly opened a new pull request #1808: Used OrderedScheduler for ledger offload

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1808: Used OrderedScheduler for ledger offload URL: https://github.com/apache/incubator-pulsar/pull/1808 We want to ensure that operations for the same ledger do not overlap. This is particularly important for the ReadHandle as it has state(the

[GitHub] ivankelly opened a new pull request #1809: S3 offloader doesn't allow block size < 5MB

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1809: S3 offloader doesn't allow block size < 5MB URL: https://github.com/apache/incubator-pulsar/pull/1809 S3 doesn't allow multipart upload to be used with a block size less than 5MB. So we shouldn't allow our offloader to be configured with a

[GitHub] ivankelly opened a new pull request #1806: Use our own minimal S3Mock rather than findify S3Mock

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1806: Use our own minimal S3Mock rather than findify S3Mock URL: https://github.com/apache/incubator-pulsar/pull/1806 The findify mock's project isn't very active, and is missing some functionallity, such as setting metadata on multipart objects

[GitHub] ivankelly opened a new pull request #1807: In S3 offloader, dont use InputStream#available for stream length

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1807: In S3 offloader, dont use InputStream#available for stream length URL: https://github.com/apache/incubator-pulsar/pull/1807 According to the javadoc, available() returns the number bytes that can be read without blocking. It is _not_ the total

[GitHub] ivankelly opened a new pull request #1810: Store offloaded data object size in index

2018-05-18 Thread GitBox
ivankelly opened a new pull request #1810: Store offloaded data object size in index URL: https://github.com/apache/incubator-pulsar/pull/1810 We need the size of the data object to set a bound on the stream we read from S3. Without the size in the index we need to do an extra call

[incubator-pulsar] branch master updated: Ensure BookKeeperClientFactory is only instantiated once in PulsarService (#1804)

2018-05-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 655b7c0 Ensure

[GitHub] merlimat closed pull request #1804: Ensure BookKeeperClientFactory is only instantiated once in PulsarService

2018-05-18 Thread GitBox
merlimat closed pull request #1804: Ensure BookKeeperClientFactory is only instantiated once in PulsarService URL: https://github.com/apache/incubator-pulsar/pull/1804 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] merlimat opened a new pull request #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf

2018-05-18 Thread GitBox
merlimat opened a new pull request #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf URL: https://github.com/apache/incubator-pulsar/pull/1812 ### Motivation Since ManagedLedger protobuf code was using the regular 2.4.1 protoc generated

[GitHub] merlimat commented on a change in pull request #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf

2018-05-18 Thread GitBox
merlimat commented on a change in pull request #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf URL: https://github.com/apache/incubator-pulsar/pull/1812#discussion_r189378991 ## File path:

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-18 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390276898 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat opened a new pull request #1811: Improve logging when we fail to bind on server ports

2018-05-18 Thread GitBox
merlimat opened a new pull request #1811: Improve logging when we fail to bind on server ports URL: https://github.com/apache/incubator-pulsar/pull/1811 ### Motivation Ensure that in most cases we print the IP/port we're trying to bind to when there is a bind exception.

[GitHub] jerrypeng commented on issue #1813: adding update functionality to sources and sinks

2018-05-18 Thread GitBox
jerrypeng commented on issue #1813: adding update functionality to sources and sinks URL: https://github.com/apache/incubator-pulsar/pull/1813#issuecomment-390355545 @sijie @srkukarni please review This is an automated

[GitHub] jerrypeng opened a new pull request #1813: adding update functionality to sources and sinks

2018-05-18 Thread GitBox
jerrypeng opened a new pull request #1813: adding update functionality to sources and sinks URL: https://github.com/apache/incubator-pulsar/pull/1813 This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat commented on issue #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf

2018-05-18 Thread GitBox
merlimat commented on issue #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf URL: https://github.com/apache/incubator-pulsar/pull/1812#issuecomment-390362076 retest this please This