[GitHub] sijie opened a new issue #1943: Non serializable client builder

sijie opened a new issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943 ``` One of the main change concerns the configuration classes, replace by builders. Although ProducerBuilder and ConsumerBuilder interfaces implement

[GitHub] sijie closed pull request #1936: Cpp client: fix flaky seek test

sijie closed pull request #1936: Cpp client: fix flaky seek test URL: https://github.com/apache/incubator-pulsar/pull/1936 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Cpp client: fix flaky seek test (#1936)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new bff4f8b Cpp client: fix flaky seek

[GitHub] sijie closed pull request #1934: Added a bunch of concrete sources/sinks so that they are usable without having to write code

sijie closed pull request #1934: Added a bunch of concrete sources/sinks so that they are usable without having to write code URL: https://github.com/apache/incubator-pulsar/pull/1934 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] ivankelly opened a new pull request #1942: Fix topic name in getting started documentation

ivankelly opened a new pull request #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942 It was "my-topic", when it should have been persistent://public/default/my-topic.

[GitHub] ivankelly commented on issue #1942: Fix topic name in getting started documentation

ivankelly commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395796456 @merlimat there was a user complaining that it wasn't working recently on slack

[incubator-pulsar] branch master updated: Added a bunch of concrete sources/sinks so that they are usable without having to write code (#1934)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1950538 Added a bunch of concrete

[GitHub] merlimat commented on issue #1943: Non serializable client builder

merlimat commented on issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943#issuecomment-395820413 The problem has not an easy fix. The builders impl intrinsically hold references to non-serializable objects (eg: Client instance, or auth

[GitHub] srkukarni opened a new pull request #1938: Have the ability to specify instance id offset in localrun

srkukarni opened a new pull request #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938 ### Motivation To run functions in kubernetes, the most easiest approach would be to launch the k8 containers running

[GitHub] ivankelly opened a new pull request #1941: Tiered Storage documentation

ivankelly opened a new pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941 The patch adds a section in "Concepts and Architecture" and a cookbook for setting up tiered storage with S3. Master Issue: #1511

[GitHub] sijie closed pull request #1937: Fix doc build error on broker config

sijie closed pull request #1937: Fix doc build error on broker config URL: https://github.com/apache/incubator-pulsar/pull/1937 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Fix doc build error on broker config (#1937)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c2e9219 Fix doc build error on broker

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194107081 ## File path: pulsar-client-cpp/lib/ConsumerImpl.h ## @@

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194109234 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194104557 ## File path: pulsar-client-cpp/lib/ConsumerImpl.h ## @@

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194100685 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ##

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194108495 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194107442 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194101542 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ##

[GitHub] ivankelly opened a new pull request #1940: Fix reference configuration display

ivankelly opened a new pull request #1940: Fix reference configuration display URL: https://github.com/apache/incubator-pulsar/pull/1940 Long lines were not wrapping, so they were overflowing on the next cell. Maybe not a problem if you have a gigantic monitor, but a lot of people do

[GitHub] ivankelly commented on issue #1942: Fix topic name in getting started documentation

ivankelly commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395796980 ah, it was an old version of the client. Still confusing for them though.

[GitHub] sijie commented on issue #1942: Fix topic name in getting started documentation

sijie commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395804081 shall put a link on the 2.0 documents to refer back to 1.22.x release doc if people are using 1.22.x clients? just like what we

[GitHub] merlimat commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

merlimat commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194116244 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ##

[GitHub] ivankelly commented on issue #1939: Instructions to build site on linux with root

ivankelly commented on issue #1939: Instructions to build site on linux with root URL: https://github.com/apache/incubator-pulsar/pull/1939#issuecomment-395793170 Site won't actually build until is in https://github.com/apache/incubator-pulsar/pull/1937 Would be good if someone

[GitHub] ivankelly opened a new pull request #1939: Instructions to build site on linux with root

ivankelly opened a new pull request #1939: Instructions to build site on linux with root URL: https://github.com/apache/incubator-pulsar/pull/1939 Previously you required root access in linux to build a bunch of html files. This patch makes it so you no longer need root to run the

[GitHub] rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#issuecomment-395693775 retest this please This is an

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395764038 PR #1936 is for the cpp seek flaky test fix This is an

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395626566 retest this please This is an automated message from the

[GitHub] nkurihar commented on a change in pull request #1907: Added documentation for authn & authz plugins

nkurihar commented on a change in pull request #1907: Added documentation for authn & authz plugins URL: https://github.com/apache/incubator-pulsar/pull/1907#discussion_r194040422 ## File path: site/docs/latest/reference/CustomAuth.md ## @@ -0,0 +1,228 @@ +--- +title:

[incubator-pulsar] annotated tag v2.0.1-incubating-candidate-2 updated (fd47532 -> 454ce00)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to annotated tag v2.0.1-incubating-candidate-2 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. *** WARNING: tag v2.0.1-incubating-candidate-2 was modified! *** from fd47532

[incubator-pulsar] 02/02: Make Python code work with Pulsar Function localrun (#1930)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit fd47532380d770e4fd78cabe71dea293fc2f0e06 Author: massakam AuthorDate: Fri Jun 8 01:02:12 2018 +0900

[incubator-pulsar] 01/02: Include functions in pulsar-client Python package (#1893)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit 7b0703d5dbd97c58c3028756b19d6713e3f93314 Author: Matteo Merli AuthorDate: Mon Jun 4 15:12:56 2018 -0700

[incubator-pulsar] branch branch-2.0 updated (b18a268 -> fd47532)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. from b18a268 Fixed shading on generated protobuf backported from master new 7b0703d Include

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r193967793 ## File path:

[GitHub] hrsakai commented on a change in pull request #1838: Pulsar Go client docs

hrsakai commented on a change in pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r193984538 ## File path: site/docs/latest/clients/go.md ## @@ -0,0 +1,589 @@ +--- +title: The Pulsar Go client +tags: [client,

[GitHub] zhaijack opened a new pull request #1936: Cpp client: fix flaky seek test

zhaijack opened a new pull request #1936: Cpp client: fix flaky seek test URL: https://github.com/apache/incubator-pulsar/pull/1936 In BasicEndToEndTest, test case `TEST(BasicEndToEndTest, testSeek)` is flaky because of not wait enough time for consumer connection. This PR add sleep time

[GitHub] rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r193975538 ## File path:

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194001198 ## File path:

[GitHub] hrsakai commented on a change in pull request #1838: Pulsar Go client docs

hrsakai commented on a change in pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r193988604 ## File path: site/docs/latest/clients/go.md ## @@ -0,0 +1,589 @@ +--- +title: The Pulsar Go client +tags: [client,

[GitHub] nkurihar commented on a change in pull request #1922: Enable bookkeeper table service in pulsar standalone

nkurihar commented on a change in pull request #1922: Enable bookkeeper table service in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1922#discussion_r194035940 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r193960672 ## File path:

[GitHub] rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#issuecomment-395693775 retest this please This is an

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194002698 ## File path:

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194002521 ## File path:

[GitHub] srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun

srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938#issuecomment-395844992 retest this please This is an automated message

[GitHub] srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun

srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938#issuecomment-395867214 retest this please This is an automated message

[incubator-pulsar] branch master updated: Add Client auth plugin and tls support for function to connect with broker (#1935)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6e336b4 Add Client auth plugin

[GitHub] rdhabalia closed pull request #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia closed pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] mgodave opened a new pull request #1944: Add CLI commands for schema registry

mgodave opened a new pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #1943: Non serializable client builder

sijie commented on issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943#issuecomment-395832694 Can we do things like `PulsarClient.builder.withConf(ClientConfiguration).build()`?

[GitHub] rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194164704 ## File path:

[GitHub] jerrypeng commented on issue #1917: adding avro schema

jerrypeng commented on issue #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#issuecomment-395919037 @merlimat I have shaded the avro dependences. Please check if I got them all This is an

[GitHub] zhaijack commented on issue #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

zhaijack commented on issue #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#issuecomment-395266577 retest this please This is an

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395927722 retest this please This is an automated message from the

[incubator-pulsar] branch master updated: Have the ability to specify instance id offset in localrun (#1938)

This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 51a7c02 Have the ability to

[GitHub] merlimat commented on a change in pull request #1917: adding avro schema

merlimat commented on a change in pull request #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#discussion_r194203236 ## File path: pulsar-client-shaded/pom.xml ## @@ -86,6 +86,14 @@

[GitHub] jerrypeng commented on a change in pull request #1917: adding avro schema

jerrypeng commented on a change in pull request #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#discussion_r194204481 ## File path: pulsar-client-shaded/pom.xml ## @@ -86,6 +86,14 @@

[GitHub] srkukarni closed pull request #1938: Have the ability to specify instance id offset in localrun

srkukarni closed pull request #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed (#1945)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8682776 Fix: managedledger

[GitHub] rdhabalia closed pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed

rdhabalia closed pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed URL: https://github.com/apache/incubator-pulsar/pull/1945 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] rdhabalia commented on issue #1946: Use broker advertisedAddress + tls url in function worker

rdhabalia commented on issue #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946#issuecomment-395926154 @massakam as we discussed on #1935 This is an

[GitHub] rdhabalia closed pull request #1946: Use broker advertisedAddress + tls url in function worker

rdhabalia closed pull request #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Use broker advertisedAddress + tls url in function worker (#1946)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2bf387d Use broker

[GitHub] rdhabalia opened a new pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed

rdhabalia opened a new pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed URL: https://github.com/apache/incubator-pulsar/pull/1945 ### Motivation While closing ManagedLedgerFactory, if one of the ledger-future is not

[GitHub] rdhabalia opened a new pull request #1946: Use broker advertisedAddress + tls url in function worker

rdhabalia opened a new pull request #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946 ### Motivation Function can use broker's advertised-address and tls url if function and broker supports it. ###

[incubator-pulsar] branch master updated: Instructions to build site on linux without root (#1939)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7a86673 Instructions to build site

[GitHub] merlimat closed pull request #1939: Instructions to build site on linux without root

merlimat closed pull request #1939: Instructions to build site on linux without root URL: https://github.com/apache/incubator-pulsar/pull/1939 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat commented on a change in pull request #1944: Add CLI commands for schema registry

merlimat commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191607 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194191655 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194191756 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] sijie commented on issue #1944: Add CLI commands for schema registry

sijie commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-395890879 @jerrypeng @srkukarni please help review this This is an automated message

[GitHub] sijie commented on a change in pull request #1944: Add CLI commands for schema registry

sijie commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194181707 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Schemas.java ## @@ -0,0

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194190912 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/SchemasImpl.java

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194192059 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] sijie commented on issue #1941: Tiered Storage documentation

sijie commented on issue #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#issuecomment-395891279 @aahmed-se @mgodave @srkukarni can you guys help review documentation? This is an

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191137 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191179 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@

[GitHub] sijie commented on issue #1940: Fix reference configuration display

sijie commented on issue #1940: Fix reference configuration display URL: https://github.com/apache/incubator-pulsar/pull/1940#issuecomment-395891569 retest this please This is an automated message from the Apache Git Service.