[GitHub] hrsakai commented on issue #2131: Fix Link in Binary Protocol

2018-07-11 Thread GitBox
hrsakai commented on issue #2131: Fix Link in Binary Protocol URL: https://github.com/apache/incubator-pulsar/pull/2131#issuecomment-404067812 retest this please This is an automated message from the Apache Git Service. To

[GitHub] zhaijack opened a new issue #2133: track adobe/s3mock update, since it is not using the latest version of github repo

2018-07-11 Thread GitBox
zhaijack opened a new issue #2133: track adobe/s3mock update, since it is not using the latest version of github repo URL: https://github.com/apache/incubator-pulsar/issues/2133 dockerhub adobe/s3mock: https://hub.docker.com/r/adobe/s3mock/ is not using the latest version of github

[GitHub] k2la commented on issue #2131: Fix Link in Binary Protocol

2018-07-11 Thread GitBox
k2la commented on issue #2131: Fix Link in Binary Protocol URL: https://github.com/apache/incubator-pulsar/pull/2131#issuecomment-404089704 retest this please This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on issue #2126: Slow consumer prevents offloaded ledger cleanup

2018-07-11 Thread GitBox
ivankelly commented on issue #2126: Slow consumer prevents offloaded ledger cleanup URL: https://github.com/apache/incubator-pulsar/pull/2126#issuecomment-404097081 retest this please // org.apache.pulsar.client.impl.SequenceIdWithErrorTest.testCheckSequenceId

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201637787 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] sijie opened a new pull request #2134: Fix a few links in security pages

2018-07-11 Thread GitBox
sijie opened a new pull request #2134: Fix a few links in security pages URL: https://github.com/apache/incubator-pulsar/pull/2134 *Motivation* A few links use `../..` for locating pages in same `security` category, which are wrong. *Solution* Change `../..` to `..`

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201638762 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201636750 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201635600 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201624141 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201619275 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201625356 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201634904 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201618522 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201623711 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201619573 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201625942 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201625533 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201624577 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201622511 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201638086 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201627055 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar

2018-07-11 Thread GitBox
ivankelly commented on a change in pull request #2048: Add Upgrade Guide to Apache Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2048#discussion_r201618191 ## File path: site/docs/latest/admin/Upgrade.md ## @@ -0,0 +1,152 @@ +--- +title: Upgrade +--- + + +

[GitHub] zhaijack commented on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-11 Thread GitBox
zhaijack commented on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#issuecomment-404116641 retest this please This is

[GitHub] zhaijack edited a comment on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-11 Thread GitBox
zhaijack edited a comment on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#issuecomment-404116641 retest this please for ut: org.apache.pulsar.broker.service.ReplicatorTest.setup

[GitHub] merlimat closed pull request #2134: Fix a few links in security pages

2018-07-11 Thread GitBox
merlimat closed pull request #2134: Fix a few links in security pages URL: https://github.com/apache/incubator-pulsar/pull/2134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on issue #2056: Add authentication to admin proxy

2018-07-11 Thread GitBox
merlimat commented on issue #2056: Add authentication to admin proxy URL: https://github.com/apache/incubator-pulsar/pull/2056#issuecomment-404247017 @rdhabalia @jai1 PTAL as well This is an automated message from the Apache

[GitHub] jerrypeng commented on issue #2114: Submit and run locally builtin connectors

2018-07-11 Thread GitBox
jerrypeng commented on issue #2114: Submit and run locally builtin connectors URL: https://github.com/apache/incubator-pulsar/pull/2114#issuecomment-404246724 retest this please This is an automated message from the Apache

[GitHub] sijie commented on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
sijie commented on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404264838 @jerrypeng @srkukarni please review this. This is an

[GitHub] srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201797566 ## File path:

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-11 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-404269152 retest this please This is an automated

[GitHub] aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore

2018-07-11 Thread GitBox
aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123#issuecomment-404269108 retest this please This is an automated message from the Apache

[GitHub] srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201799408 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@

[incubator-pulsar] branch asf-site updated: Updated site at revision 76fb8dc

2018-07-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 08b40b9 Updated site at revision

[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201802757 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@

[GitHub] rdhabalia commented on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404274032 > Might be worthwhile to go over this in detail about what we are trying to achieve and why there are so many touch points

[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201804691 ## File path:

[GitHub] nkurihar commented on issue #2131: Fix Link in Binary Protocol

2018-07-11 Thread GitBox
nkurihar commented on issue #2131: Fix Link in Binary Protocol URL: https://github.com/apache/incubator-pulsar/pull/2131#issuecomment-404156360 retest this please This is an automated message from the Apache Git Service. To

[GitHub] ivankelly opened a new pull request #2135: Allow user to get topic from consumer message (#2007)

2018-07-11 Thread GitBox
ivankelly opened a new pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135 When a user receives a message, allow them to get the topic from the message itself. This is mostly useful in the case where a

[GitHub] nkurihar commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8

2018-07-11 Thread GitBox
nkurihar commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8 URL: https://github.com/apache/incubator-pulsar/pull/2086#issuecomment-404156214 retest this please This is an automated

[GitHub] jerrypeng commented on issue #2114: Submit and run locally builtin connectors

2018-07-11 Thread GitBox
jerrypeng commented on issue #2114: Submit and run locally builtin connectors URL: https://github.com/apache/incubator-pulsar/pull/2114#issuecomment-404293192 retest this please This is an automated message from the Apache

[GitHub] merlimat opened a new pull request #2140: Temporarely disable SequenceIdWithErrorTest

2018-07-11 Thread GitBox
merlimat opened a new pull request #2140: Temporarely disable SequenceIdWithErrorTest URL: https://github.com/apache/incubator-pulsar/pull/2140 ### Motivation There is a race condition between the consumer and producer reconnecting after a ledger fenced error that causes the test

[GitHub] sijie commented on a change in pull request #2139: Use container name in logs

2018-07-11 Thread GitBox
sijie commented on a change in pull request #2139: Use container name in logs URL: https://github.com/apache/incubator-pulsar/pull/2139#discussion_r201909161 ## File path: tests/integration-tests-utils/src/main/java/org/apache/pulsar/tests/DockerUtils.java ## @@ -61,11

[GitHub] sijie commented on issue #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-11 Thread GitBox
sijie commented on issue #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#issuecomment-404388986 retest this please This is an automated

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912703 ## File path:

[GitHub] rdhabalia commented on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404395866 I have rebased the PR, and addressed the discussed changes. any more concern before we merge PR?

[GitHub] massakam commented on issue #2131: Fix Link in Binary Protocol

2018-07-11 Thread GitBox
massakam commented on issue #2131: Fix Link in Binary Protocol URL: https://github.com/apache/incubator-pulsar/pull/2131#issuecomment-404360401 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat closed pull request #2123: Add pulsar python wheelhouse to gitignore

2018-07-11 Thread GitBox
merlimat closed pull request #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Add pulsar python to gitignore (#2123)

2018-07-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a4e9399 Add pulsar python to

[GitHub] merlimat opened a new issue #2141: Race condition in reconnection after managed ledger is fenced

2018-07-11 Thread GitBox
merlimat opened a new issue #2141: Race condition in reconnection after managed ledger is fenced URL: https://github.com/apache/incubator-pulsar/issues/2141 While checking the intermittent failures for `SequenceIdWithErrorTest`, I've seen that the test is failing due to a race

[GitHub] jiazhai commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007)

2018-07-11 Thread GitBox
jiazhai commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135#discussion_r201909840 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java

[GitHub] merlimat commented on issue #2140: Temporarely disable SequenceIdWithErrorTest

2018-07-11 Thread GitBox
merlimat commented on issue #2140: Temporarely disable SequenceIdWithErrorTest URL: https://github.com/apache/incubator-pulsar/pull/2140#issuecomment-404390115 @sijie Yes, created #2141 to track the issue that causes the test to fail.

[GitHub] rdhabalia removed a comment on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia removed a comment on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404382968 retest this please This is an automated message

[GitHub] rdhabalia commented on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404382968 retest this please This is an automated message from the

[GitHub] k2la commented on issue #2131: Fix Link in Binary Protocol

2018-07-11 Thread GitBox
k2la commented on issue #2131: Fix Link in Binary Protocol URL: https://github.com/apache/incubator-pulsar/pull/2131#issuecomment-404387945 retest this please This is an automated message from the Apache Git Service. To

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912982 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912934 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912955 ## File path:

[GitHub] rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-11 Thread GitBox
rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-404329883 retest this please This is an automated

[GitHub] rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-11 Thread GitBox
rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-404329829 retest this please This is an automated

[GitHub] rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-11 Thread GitBox
rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-404329883 retest this please This is an automated message

[GitHub] srkukarni closed pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-11 Thread GitBox
srkukarni closed pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Extract out common code from standalone and build Embedded Pulsar (#2080)

2018-07-11 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 11c Extract out common code

[GitHub] srkukarni opened a new pull request #2137: Added more Java and Python examples and made the examples match across languages

2018-07-11 Thread GitBox
srkukarni opened a new pull request #2137: Added more Java and Python examples and made the examples match across languages URL: https://github.com/apache/incubator-pulsar/pull/2137 ### Motivation In order to enhance user experience when trying out functions, this pr does two

[GitHub] aahmed-se opened a new pull request #2139: Use container name in logs

2018-07-11 Thread GitBox
aahmed-se opened a new pull request #2139: Use container name in logs URL: https://github.com/apache/incubator-pulsar/pull/2139 Use container name instead of uuid to bring more clarity to the logs. This is an automated

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912576 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912580 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912610 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-11 Thread GitBox
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201912597 ## File path:

[GitHub] aahmed-se commented on issue #2036: Add testcontainer based standalone test

2018-07-11 Thread GitBox
aahmed-se commented on issue #2036: Add testcontainer based standalone test URL: https://github.com/apache/incubator-pulsar/pull/2036#issuecomment-404362142 retest this please This is an automated message from the Apache

[GitHub] aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore

2018-07-11 Thread GitBox
aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123#issuecomment-404362133 retest this please This is an automated message from the

[GitHub] sijie commented on issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic

2018-07-11 Thread GitBox
sijie commented on issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic URL: https://github.com/apache/incubator-pulsar/issues/1160#issuecomment-404320767 This was fixed by #1952

[GitHub] sijie closed issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic

2018-07-11 Thread GitBox
sijie closed issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic URL: https://github.com/apache/incubator-pulsar/issues/1160 This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #2130: Add function metrics with function-stats to get metrics on-demand

2018-07-11 Thread GitBox
merlimat commented on issue #2130: Add function metrics with function-stats to get metrics on-demand URL: https://github.com/apache/incubator-pulsar/pull/2130#issuecomment-404340510 @rdhabalia The test failure seems to be genuine

[GitHub] sijie closed issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster

2018-07-11 Thread GitBox
sijie closed issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster URL: https://github.com/apache/incubator-pulsar/issues/1014 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster

2018-07-11 Thread GitBox
sijie commented on issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster URL: https://github.com/apache/incubator-pulsar/issues/1014#issuecomment-404324040 This is implemented by #1059

[GitHub] rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-11 Thread GitBox
rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-404329829 retest this please This is an automated message

[GitHub] rdhabalia commented on issue #2114: Submit and run locally builtin connectors

2018-07-11 Thread GitBox
rdhabalia commented on issue #2114: Submit and run locally builtin connectors URL: https://github.com/apache/incubator-pulsar/pull/2114#issuecomment-404329973 retest this please This is an automated message from the Apache

[GitHub] merlimat opened a new pull request #2136: Moved RackawareTest to integration tests

2018-07-11 Thread GitBox
merlimat opened a new pull request #2136: Moved RackawareTest to integration tests URL: https://github.com/apache/incubator-pulsar/pull/2136 ### Motivation Moved Rackaware test as part of integration tests. This should address the test flakyness in the unit tests.

[GitHub] rdhabalia commented on issue #2130: Add function metrics with function-stats to get metrics on-demand

2018-07-11 Thread GitBox
rdhabalia commented on issue #2130: Add function metrics with function-stats to get metrics on-demand URL: https://github.com/apache/incubator-pulsar/pull/2130#issuecomment-404345018 `FunctionStatsGeneratorTest.testFunctionsStatsGenerate` yes, I have fixed it in previous PR #2128 so, it

[GitHub] aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore

2018-07-11 Thread GitBox
aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123#issuecomment-404346335 retest this please This is an automated message from the Apache

[GitHub] merlimat opened a new pull request #2138: Fixed mem leak when receiving unrecoverable fencing errors in managed ledger

2018-07-11 Thread GitBox
merlimat opened a new pull request #2138: Fixed mem leak when receiving unrecoverable fencing errors in managed ledger URL: https://github.com/apache/incubator-pulsar/pull/2138 ### Motivation In the code handling the fenced and terminated exception, we are calling `OpAddEntry` but

[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201851221 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@

[GitHub] rdhabalia commented on issue #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on issue #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#issuecomment-404347505 @srkukarni made change to keep schedule-task configurable.

[incubator-pulsar] branch master updated: Submit and run locally builtin connectors (#2114)

2018-07-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2147201 Submit and run locally

[GitHub] merlimat closed pull request #2114: Submit and run locally builtin connectors

2018-07-11 Thread GitBox
merlimat closed pull request #2114: Submit and run locally builtin connectors URL: https://github.com/apache/incubator-pulsar/pull/2114 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201879274 ## File path:

[GitHub] srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201879199 ## File path: conf/functions_worker.yml ## @@ -44,3 +44,4 @@ rescheduleTimeoutMs: 6

[GitHub] zhaijack removed a comment on issue #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-11 Thread GitBox
zhaijack removed a comment on issue #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#issuecomment-404328361 retest this please This

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-11 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-404325117 retest this please This is an automated

[GitHub] srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
srkukarni commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201828358 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@

[GitHub] sijie closed issue #1053: Move zookeeper/bookkeeper dependency back to dependency management

2018-07-11 Thread GitBox
sijie closed issue #1053: Move zookeeper/bookkeeper dependency back to dependency management URL: https://github.com/apache/incubator-pulsar/issues/1053 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #1016: Support bytes message key

2018-07-11 Thread GitBox
sijie commented on issue #1016: Support bytes message key URL: https://github.com/apache/incubator-pulsar/issues/1016#issuecomment-404323921 based on the discussion before, we don't want to support bytes key. current string key is already enough to support bytes. so close it for now.

[GitHub] sijie closed issue #1016: Support bytes message key

2018-07-11 Thread GitBox
sijie closed issue #1016: Support bytes message key URL: https://github.com/apache/incubator-pulsar/issues/1016 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] zhaijack commented on issue #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-11 Thread GitBox
zhaijack commented on issue #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#issuecomment-404328361 retest this please This is an

[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201879492 ## File path: conf/functions_worker.yml ## @@ -44,3 +44,4 @@ rescheduleTimeoutMs: 6

[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

2018-07-11 Thread GitBox
rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201879687 ## File path:

[GitHub] sijie commented on issue #1053: Move zookeeper/bookkeeper dependency back to dependency management

2018-07-11 Thread GitBox
sijie commented on issue #1053: Move zookeeper/bookkeeper dependency back to dependency management URL: https://github.com/apache/incubator-pulsar/issues/1053#issuecomment-404323385 This issue is not needed anymore. so close it.