sijie commented on a change in pull request #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468#discussion_r213576537
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##
@@ -477,9 +477,8
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 9c1503b [tiered storage] Use NAR plug
sijie commented on issue #2440: Issue 2313: create a JDBC sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#issuecomment-416859701
@jiazhai : when the CI passed, I will merge this PR and will address those
comments in a separate PR.
--
sijie closed pull request #2393: [tiered storage] Use NAR plugin to package
offloaders
URL: https://github.com/apache/incubator-pulsar/pull/2393
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
A
sijie commented on issue #2409: Added HDFS Sink
URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-416860145
@merlimat @david-streamlio @srkukarni what is the current status of this PR?
are we able to wrap this up by end of this week?
---
codelipenghui opened a new pull request #2471: Pulsar Java Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471
### Motivation
Support user to add interceptors to producer and consumer.
### Modifications
Add Consumer interceptors.
```java
guzuomuse commented on issue #2461: windows server support needed!
URL:
https://github.com/apache/incubator-pulsar/issues/2461#issuecomment-416888600
@merlimat @sijie
unfortunately. cause too many dependencies drive me crazy.
i will look back.but i have to give up for now.
-
guzuomuse edited a comment on issue #2461: windows server support needed!
URL:
https://github.com/apache/incubator-pulsar/issues/2461#issuecomment-416888600
@merlimat @sijie
unfortunately.after struggling for hours. too many dependencies drive me
crazy.
i will look back.but i have t
joefk edited a comment on issue #2462: Looks like a small user base on SO.
Marketing efforts? Will the project last?
URL:
https://github.com/apache/incubator-pulsar/issues/2462#issuecomment-416763442
Yahoo/Oath is running Pulsar in production at a large scale; and will
continue to do s
david-streamlio commented on issue #2409: Added HDFS Sink
URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-416994466
I have corrected all of the issues found during the code review, and have
conducted extensive testing locally. So, I believe the code is ready to go.
-
srkukarni commented on issue #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468#issuecomment-417013071
We might have, however the moot point of this pr is that the skipOutput flag
has become confusing. What do we really want to achieve here? If use
srkukarni commented on issue #2409: Added HDFS Sink
URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-417016218
run java8 tests
This is an automated message from the Apache Git Service.
To respond to the m
srkukarni commented on issue #2409: Added HDFS Sink
URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-417016173
run integration tests
This is an automated message from the Apache Git Service.
To respond to
pouledodue closed issue #2287: Provide a Rancher package for Pulsar
URL: https://github.com/apache/incubator-pulsar/issues/2287
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rdhabalia commented on issue #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468#issuecomment-417036641
> If users dont want to output anything, they can always set their output
topic to be empty or not set it at all. Why is there a need for extra f
sijie commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213765064
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##
@@ -1
sijie commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213765194
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/v1/V1_ReplicatorTest.java
##
@@ -
sijie commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213765156
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
##
@@ -242,7
srkukarni opened a new pull request #2472: Create function assignment topic
during standalone mode
URL: https://github.com/apache/incubator-pulsar/pull/2472
### Motivation
We moved to a new 'assignments' namespace for writing function assignments.
This pr creates this namespace in t
srkukarni commented on issue #2468: Fix semantics of skip output
URL: https://github.com/apache/incubator-pulsar/pull/2468#issuecomment-417040483
IIRC, in 2.1, if you dont specify an output topic, a topic was created for
you as the function output. I believe we wanted to change that by not
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213771388
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -435,7 +4
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213770348
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
##
@@ -
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213785491
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -204,10 +
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213771645
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -204,10 +
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213768670
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ProducerInterceptor.java
##
@@ -0,
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213769267
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainer.java
##
@@
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r21377
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
##
@@ -
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213774992
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerInterceptors.java
##
@@ -
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213785810
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -231,21 +
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213768368
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
##
@@ -0,
merlimat commented on a change in pull request #2471: Pulsar Java Client
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213767333
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
##
@@ -0,
merlimat opened a new pull request #2473: Downgrading ZK to stable version
3.4.13
URL: https://github.com/apache/incubator-pulsar/pull/2473
### Motivation
Ensure that we don't have dependency on a ZK version marked as "beta".
### Modifications
* Upgrade to BookKeeper 4
jerrypeng opened a new pull request #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474
This reverts commit b283ebd3e51aa86f6b9f0a6607f430996f0032f7.
### Motivation
The commit broke maste
aahmed-se opened a new pull request #2475: [WIP] Add host name verification
URL: https://github.com/apache/incubator-pulsar/pull/2475
Work in progress
This is an automated message from the Apache Git Service.
To respond to the
rdhabalia commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417097658
what is the other issue other than namespace creation in standalone broker
which will be address
RobIsHere commented on issue #2462: Looks like a small user base on SO.
Marketing efforts? Will the project last?
URL:
https://github.com/apache/incubator-pulsar/issues/2462#issuecomment-417100212
The fact that there is a growing number of mid-size companies and also a CE
company from out
jerrypeng commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417103554
@rdhabalia when starting up pulsar standalone I see:
12:34:10.207 [pool-49-thread-1] INFO
RobIsHere commented on issue #2463: Multitopic subscription missing in most
clients especially C++?
URL:
https://github.com/apache/incubator-pulsar/issues/2463#issuecomment-417103962
Thank you! That's great! I'll use the C++ API directly ;)
---
rdhabalia commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417104704
> when starting up pulsar standalone I see:
I see.. even though we create assignment names
jerrypeng commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417105137
```I see.. even though we create assignment namespace?```
Yes
---
jerrypeng commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417105009
Also discussing with @merlimat @srkukarni I don't think (#2438) is the best
design for solving t
jerrypeng edited a comment on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417105137
> I see.. even though we create assignment namespace?
Yes
rdhabalia commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417114755
> we will still have the inefficiency of submitting/updating one function
requiring the publishi
jerrypeng commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417116524
> yes, that could be a better approach. so, where this compaction will run?
within function work
rdhabalia commented on issue #2474: Revert "Fix: Function assignment can
support large number of topics (#2438)"
URL: https://github.com/apache/incubator-pulsar/pull/2474#issuecomment-417120570
> We should also do something similar in the function metadata topic, since
currently that grows
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13
URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-417123976
> However, this needs an integration test, that starts a 3.5 server, creates
contains, and uses create2, then rolls back to ensure we c
sijie opened a new issue #2476: PIP-23: Pulsar Interceptors
URL: https://github.com/apache/incubator-pulsar/issues/2476
This is the master ticket for tracking all the tasks for pulsar interceptors
- [ ] Producer & Consumer Interceptors #2471
- [ ] Reader Interceptor
- [ ] Clien
sijie opened a new issue #2477: Reader Interceptor
URL: https://github.com/apache/incubator-pulsar/issues/2477
This is part of #2476 for adding ReaderInterceptor to address comment :
https://github.com/apache/incubator-pulsar/pull/2471#pullrequestreview-150671948
--
sijie opened a new issue #2478: Pulsar Client Interceptor
URL: https://github.com/apache/incubator-pulsar/issues/2478
This is a sub task for #2476 for adding client-level interceptor, addressing
comment:
https://github.com/apache/incubator-pulsar/pull/2471#pullrequestreview-150671948
sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-417140833
@merlimat : created #2476 for tracking the tasks for interceptors. lets
focus on producer/consumer interceptor for this PR.
> One
nkurihar commented on issue #2464: Copy ByteBufPair buffers when using with SSL
(#2401)
URL: https://github.com/apache/incubator-pulsar/pull/2464#issuecomment-417143980
run integration tests
This is an automated message from
jerrypeng opened a new pull request #2479: Initial SQL documentation and
DataGeneratorSource
URL: https://github.com/apache/incubator-pulsar/pull/2479
This is an automated message from the Apache Git Service.
To respond to t
jiazhai commented on issue #2440: Issue 2313: create a JDBC sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#issuecomment-417149929
retest this please
This is an automated message from the Apache Git Se
jiazhai removed a comment on issue #2440: Issue 2313: create a JDBC sink
connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#issuecomment-417149929
retest this please
This is an automated message from the Apac
jiazhai closed pull request #2440: Issue 2313: create a JDBC sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fo
jiazhai opened a new pull request #2440: Issue 2313: create a JDBC sink
connector
URL: https://github.com/apache/incubator-pulsar/pull/2440
### Motivation
This change is trying to add a basic JDBC sink connector.
### Modifications
Add the jdbc module to the pulsar-io s
vli02 opened a new issue #2481: `./bin/pulsar-admin clusters list` failed with
`Error: Could not find or load main class "`
URL: https://github.com/apache/incubator-pulsar/issues/2481
Expected behavior
Expect to list the clusters I have created.
Actual behavior
merlimat opened a new pull request #2480: Allow to configure bookie settings
when running in standalone mode
URL: https://github.com/apache/incubator-pulsar/pull/2480
### Motivation
Most bookie configs are set in stone when running Pulsar in standalone mode.
We need to be able
merlimat commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-417154862
> @merlimat : created #2476 for tracking the tasks for interceptors. lets
focus on producer/consumer interceptor for this PR.
merlimat opened a new pull request #2482: Fix log4j conf
URL: https://github.com/apache/incubator-pulsar/pull/2482
### Motivation
Currently all `org.apache.bookkeeper` messages printed by broker are being
routed to a different log file `broker.log.bk`. Removing for now the special
c
codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java
Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213883438
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
#
codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java
Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213886276
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainer.java
##
srkukarni closed pull request #2457: Updated documentation about changed
arguments for functions, sources and sinks
URL: https://github.com/apache/incubator-pulsar/pull/2457
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
This is an automated email from the ASF dual-hosted git repository.
sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 87fb48f Updated documentation abou
codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java
Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r21326
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
codelipenghui commented on a change in pull request #2471: PIP-23: Pulsar Java
Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213889135
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
sijie commented on issue #2440: Issue 2313: create a JDBC sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#issuecomment-417187224
retest this please
This is an automated message from the Apache Git Serv
merlimat commented on a change in pull request #2471: PIP-23: Pulsar Java
Client Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213911333
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
##
ivankelly commented on issue #2464: Copy ByteBufPair buffers when using with
SSL (#2401)
URL: https://github.com/apache/incubator-pulsar/pull/2464#issuecomment-417208969
FYI, apache jenkins is down, so tests won't pass or even run, until it comes
back up (see https://status.apache.org).
-
69 matches
Mail list logo
