[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904692 ## File path: pulsar-connect/twitter/src/main/java/org/apache/pulsar/connect/twitter/TwitterFireHoseConfigKeys.java ## @@ -0

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904865 ## File path: pulsar-connect/twitter/src/main/java/org/apache/pulsar/connect/twitter/TwitterFireHose.java ## @@ -0,0 +1,172

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904748 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ## @@ -0,0 +1,46 @@ +/** + * Licens

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904588 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ## @@ -0,0 +1,46 @@ +/** + * Licens

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904923 ## File path: pulsar-connect/twitter/pom.xml ## @@ -0,0 +1,49 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://ww

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

2018-04-06 Thread GitBox
merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904898 ## File path: pulsar-connect/pom.xml ## @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org