sijie closed pull request #2548: Stop all functions gracefully on closing worker-service URL: https://github.com/apache/incubator-pulsar/pull/2548
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java index 93828de40d..75a70e0fb6 100644 --- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java +++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java @@ -403,6 +403,25 @@ public Response stopFunctionInstances(String tenant, String namespace, String fu return Response.status(Status.OK).build(); } + /** + * It stops all functions instances owned by current worker + * @throws Exception + */ + public void stopAllOwnedFunctions() throws Exception { + final String workerId = this.workerConfig.getWorkerId(); + Map<String, Assignment> assignments = workerIdToAssignments.get(workerId); + if (assignments != null) { + assignments.values().forEach(assignment -> { + String fullyQualifiedInstanceId = Utils.getFullyQualifiedInstanceId(assignment.getInstance()); + try { + stopFunction(fullyQualifiedInstanceId, false); + } catch (Exception e) { + log.warn("Failed to stop function {} - {}", fullyQualifiedInstanceId, e.getMessage()); + } + }); + } + } + private void stopFunction(String fullyQualifiedInstanceId, boolean restart) throws Exception { log.info("[{}] {}..", restart ? "restarting" : "stopping", fullyQualifiedInstanceId); FunctionRuntimeInfo functionRuntimeInfo = this.getFunctionRuntimeInfo(fullyQualifiedInstanceId); @@ -658,6 +677,7 @@ private void setFunctionRuntimeInfo(String fullyQualifiedInstanceId, FunctionRun @Override public void close() throws Exception { + stopAllOwnedFunctions(); this.functionActioner.close(); this.functionAssignmentTailer.close(); if (runtimeFactory != null) { ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services