[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-19 Thread GitBox
jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r368292387 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -1075,6 +1097,378 @@ def _mx_cond(inputs, attrs,

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-19 Thread GitBox
jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r368292444 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -1075,6 +1097,378 @@ def _mx_cond(inputs, attrs,

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-19 Thread GitBox
jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r368292112 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -44,8 +58,9 @@ "relu" : _op.nn.relu } + def

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-19 Thread GitBox
jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r368292864 ## File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py ## @@ -21,52 +21,95 @@ import numpy as np from

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-19 Thread GitBox
jackwish commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r368292195 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -1033,6 +1054,7 @@ def _mx_contrib_fifo_buffer(inputs,

[GitHub] [incubator-tvm] masahi commented on issue #4738: Fix padding in pooling op

2020-01-19 Thread GitBox
masahi commented on issue #4738: Fix padding in pooling op URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575998139 you can just a test case where pooling has different pad size in each dimension. This

[GitHub] [incubator-tvm] jackwish commented on issue #4732: [QNN] Conv2D type checking for kernel per-channel scales.

2020-01-19 Thread GitBox
jackwish commented on issue #4732: [QNN] Conv2D type checking for kernel per-channel scales. URL: https://github.com/apache/incubator-tvm/pull/4732#issuecomment-576003731 Thank you for ping, and sorry for missed this. I had a busy week. :)

[GitHub] [incubator-tvm] FrozenGene commented on issue #4102: [Relay] Support for Tensorflow 2.0

2020-01-19 Thread GitBox
FrozenGene commented on issue #4102: [Relay] Support for Tensorflow 2.0 URL: https://github.com/apache/incubator-tvm/issues/4102#issuecomment-575980609 Maybe we could boost the progress. I am told by many folks they are interested in Mobilenet V3 model. However, `HardSwish` is not defined

[GitHub] [incubator-tvm] masahi commented on issue #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on issue #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#issuecomment-576039103 I add a link below where I clarified my intention. Hopefully this clears up some confusion.

[GitHub] [incubator-tvm] masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#issuecomment-576039103 I add a link below where I clarified my intention. Hopefully this clears up some confusion.

[GitHub] [incubator-tvm] tqchen merged pull request #4742: [REFACTOR][CODEGEN] codegen->target, build_module->driver

2020-01-19 Thread GitBox
tqchen merged pull request #4742: [REFACTOR][CODEGEN] codegen->target, build_module->driver URL: https://github.com/apache/incubator-tvm/pull/4742 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] masahi commented on issue #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on issue #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#issuecomment-576030113 @zhiics I'm not trying to make DNNL backend more feature complete. I want to add examples and test cases of

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
zhiics commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368308285 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82

[incubator-tvm] branch master updated: [REFACTOR][CODEGEN] codegen->target, build_module->driver (#4742)

2020-01-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 33b0831 [REFACTOR][CODEGEN]

[GitHub] [incubator-tvm] tqchen commented on issue #4742: [REFACTOR][CODEGEN] codegen->target, build_module->driver

2020-01-19 Thread GitBox
tqchen commented on issue #4742: [REFACTOR][CODEGEN] codegen->target, build_module->driver URL: https://github.com/apache/incubator-tvm/pull/4742#issuecomment-576028959 Thanks @zhiics @ZihengJiang This is an automated

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368310856 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368310856 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368311255 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368311255 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82

[GitHub] [incubator-tvm] masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#issuecomment-576030113 @zhiics I'm not trying to make DNNL backend more feature complete. I want to add examples and test

[GitHub] [incubator-tvm] masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi edited a comment on issue #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#issuecomment-576030113 @zhiics I'm not trying to make DNNL backend more feature complete. I want to add examples and test

[GitHub] [incubator-tvm] tqchen commented on issue #4743: [Relay][ONNX]KeyError: 'input.1' when compiling ONNX model

2020-01-19 Thread GitBox
tqchen commented on issue #4743: [Relay][ONNX]KeyError: 'input.1' when compiling ONNX model URL: https://github.com/apache/incubator-tvm/issues/4743#issuecomment-576030588 Moved discussion to https://discuss.tvm.ai/t/keyerror-input-1-when-compiling-onnx-model/5333

[GitHub] [incubator-tvm] tqchen closed issue #4743: [Relay][ONNX]KeyError: 'input.1' when compiling ONNX model

2020-01-19 Thread GitBox
tqchen closed issue #4743: [Relay][ONNX]KeyError: 'input.1' when compiling ONNX model URL: https://github.com/apache/incubator-tvm/issues/4743 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (33b0831 -> ee0af84)

2020-01-19 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 33b0831 [REFACTOR][CODEGEN] codegen->target, build_module->driver (#4742) add ee0af84 Add CUDA conv2d

[GitHub] [incubator-tvm] vinx13 commented on issue #4737: Add CUDA conv2d for NHWC layout

2020-01-19 Thread GitBox
vinx13 commented on issue #4737: Add CUDA conv2d for NHWC layout URL: https://github.com/apache/incubator-tvm/pull/4737#issuecomment-576071428 @alexgl-github Thanks, this is merged This is an automated message from the Apache

[GitHub] [incubator-tvm] vinx13 merged pull request #4737: Add CUDA conv2d for NHWC layout

2020-01-19 Thread GitBox
vinx13 merged pull request #4737: Add CUDA conv2d for NHWC layout URL: https://github.com/apache/incubator-tvm/pull/4737 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on issue #4746: [REFACTOR][TYPE] Finish move all types to IR.

2020-01-19 Thread GitBox
tqchen commented on issue #4746: [REFACTOR][TYPE] Finish move all types to IR. URL: https://github.com/apache/incubator-tvm/pull/4746#issuecomment-576071957 cc @wweic @MarisaKirisame @jroesch @ZihengJiang This is an

[GitHub] [incubator-tvm] tqchen opened a new pull request #4746: [REFACTOR][TYPE] Finish move all types to IR.

2020-01-19 Thread GitBox
tqchen opened a new pull request #4746: [REFACTOR][TYPE] Finish move all types to IR. URL: https://github.com/apache/incubator-tvm/pull/4746 - Move definition of Ref and TensorType to ir - Move type_functor.h to public header. - Rename RefType -> RelayRefType for clarity.

[GitHub] [incubator-tvm] alexgl-github commented on a change in pull request #4737: Add CUDA conv2d for NHWC layout

2020-01-19 Thread GitBox
alexgl-github commented on a change in pull request #4737: Add CUDA conv2d for NHWC layout URL: https://github.com/apache/incubator-tvm/pull/4737#discussion_r368340774 ## File path: topi/python/topi/cuda/conv2d.py ## @@ -162,3 +164,37 @@ def _callback(op):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368360176 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368360353 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
comaniac commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368361331 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@

[GitHub] [incubator-tvm] CoinCheung commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist

2020-01-19 Thread GitBox
CoinCheung commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist URL: https://github.com/apache/incubator-tvm/pull/4671#issuecomment-576106701 Hi, Does this requires downloading from blocked websites. Do we need to download through the firewall?

[GitHub] [incubator-tvm] slyubomirsky commented on issue #4745: [Build][Bug] Updating CUDA from 10.0 to 10.1 resulted in a broken build even after running make clean

2020-01-19 Thread GitBox
slyubomirsky commented on issue #4745: [Build][Bug] Updating CUDA from 10.0 to 10.1 resulted in a broken build even after running make clean URL: https://github.com/apache/incubator-tvm/issues/4745#issuecomment-576091530 I see, so probably not a problem on TVM's end. Thanks for the

[GitHub] [incubator-tvm] slyubomirsky closed issue #4745: [Build][Bug] Updating CUDA from 10.0 to 10.1 resulted in a broken build even after running make clean

2020-01-19 Thread GitBox
slyubomirsky closed issue #4745: [Build][Bug] Updating CUDA from 10.0 to 10.1 resulted in a broken build even after running make clean URL: https://github.com/apache/incubator-tvm/issues/4745 This is an automated message

[GitHub] [incubator-tvm] eric-haibin-lin commented on issue #4332: [RFC] Support for Sparse Computation

2020-01-19 Thread GitBox
eric-haibin-lin commented on issue #4332: [RFC] Support for Sparse Computation URL: https://github.com/apache/incubator-tvm/issues/4332#issuecomment-576098432 Thanks for the proposal. In scipy sparse, the csr_matrix has a flag indicating whether the column indices are sorted per row. Such

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation

2020-01-19 Thread GitBox
masahi commented on a change in pull request #4741: [External codegen] Add test cases for fused ops with manual annotation URL: https://github.com/apache/incubator-tvm/pull/4741#discussion_r368367461 ## File path: src/relay/backend/contrib/dnnl/codegen.cc ## @@ -50,82