[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-02-20 Thread GitBox
siju-samuel commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r382052919 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -852,6 +855,193 @@ def

[GitHub] [incubator-tvm] Orion34C commented on a change in pull request #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore

2020-02-20 Thread GitBox
Orion34C commented on a change in pull request #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore URL: https://github.com/apache/incubator-tvm/pull/4546#discussion_r381993872 ## File path: include/tvm/runtime/data_type.h ## @@ -231,7 +231,15

[GitHub] [incubator-tvm] comaniac commented on issue #4917: [DOCS] Fix sphinx warnings

2020-02-20 Thread GitBox
comaniac commented on issue #4917: [DOCS] Fix sphinx warnings URL: https://github.com/apache/incubator-tvm/pull/4917#issuecomment-589175632 No the warnings you listed are not covered in this PR. This PR now only covers Python files. I was planning to send another PR for RST, but I can also

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-02-20 Thread GitBox
u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r381990653 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -852,6 +855,193 @@ def

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-02-20 Thread GitBox
u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r381991135 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -852,6 +855,193 @@ def

[GitHub] [incubator-tvm] cchung100m commented on issue #4917: [DOCS] Fix sphinx warnings

2020-02-20 Thread GitBox
cchung100m commented on issue #4917: [DOCS] Fix sphinx warnings URL: https://github.com/apache/incubator-tvm/pull/4917#issuecomment-589086644 Hi @comaniac Thanks for submitting the PR. I think that `virtual_machine.rst` and `deploy_vision_on_vta.rst` are not caught by this

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-02-20 Thread GitBox
cchung100m commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r381996637 ## File path: topi/tests/python/test_topi_sort.py ## @@ -27,6 +27,12 @@ def

[GitHub] [incubator-tvm] cchung100m commented on issue #4908: [DOCS] Fix Sphinx Warnings

2020-02-20 Thread GitBox
cchung100m commented on issue #4908: [DOCS] Fix Sphinx Warnings URL: https://github.com/apache/incubator-tvm/issues/4908#issuecomment-589088183 Hi all, I would go to check the target-related warnings, for example: `/tvm/docs/tutorials/autotvm/tune_relay_x86.rst:34: WARNING:

[GitHub] [incubator-tvm] comaniac commented on issue #4908: [DOCS] Fix Sphinx Warnings

2020-02-20 Thread GitBox
comaniac commented on issue #4908: [DOCS] Fix Sphinx Warnings URL: https://github.com/apache/incubator-tvm/issues/4908#issuecomment-589184548 FYI: I fixed some of them in the Python doc strings by changing them to `:py:class`.

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4890: LoopVectorizer depends on ifthenelse

2020-02-20 Thread GitBox
yongfeng-nv commented on issue #4890: LoopVectorizer depends on ifthenelse URL: https://github.com/apache/incubator-tvm/issues/4890#issuecomment-589236864 https://github.com/apache/incubator-tvm/pull/4916 fixed this issue. Close it now.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-02-20 Thread GitBox
tqchen commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r382175677 ## File path: topi/tests/python/test_topi_sort.py ## @@ -27,6 +27,12 @@ def

[GitHub] [incubator-tvm] yongfeng-nv closed issue #4890: LoopVectorizer depends on ifthenelse

2020-02-20 Thread GitBox
yongfeng-nv closed issue #4890: LoopVectorizer depends on ifthenelse URL: https://github.com/apache/incubator-tvm/issues/4890 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] comaniac commented on issue #4908: [DOCS] Fix Sphinx Warnings

2020-02-20 Thread GitBox
comaniac commented on issue #4908: [DOCS] Fix Sphinx Warnings URL: https://github.com/apache/incubator-tvm/issues/4908#issuecomment-589264500 @cchung100m I supposed you will also cover the Unknown target warning, such as `Unknown target name: src/relay/pass`. Am I understanding correctly?

[GitHub] [incubator-tvm] tqchen commented on issue #4644: [Relay][AutoTVM] Relay op strategy

2020-02-20 Thread GitBox
tqchen commented on issue #4644: [Relay][AutoTVM] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#issuecomment-589237682 @yzhliu @jwfromm Please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

[GitHub] [incubator-tvm] tqchen merged pull request #4917: [DOCS] Fix sphinx warnings

2020-02-20 Thread GitBox
tqchen merged pull request #4917: [DOCS] Fix sphinx warnings URL: https://github.com/apache/incubator-tvm/pull/4917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-tvm] tqchen commented on issue #4917: [DOCS] Fix sphinx warnings

2020-02-20 Thread GitBox
tqchen commented on issue #4917: [DOCS] Fix sphinx warnings URL: https://github.com/apache/incubator-tvm/pull/4917#issuecomment-589211524 Thanks @comaniac This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated: [DOCS] Fix sphinx warnings (#4917)

2020-02-20 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new fd6d783 [DOCS] Fix sphinx warnings

[GitHub] [incubator-tvm] tqchen merged pull request #4916: [Relay] Fix an assertion exposed by loop vectorizer

2020-02-20 Thread GitBox
tqchen merged pull request #4916: [Relay] Fix an assertion exposed by loop vectorizer URL: https://github.com/apache/incubator-tvm/pull/4916 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated: [Relay] Fix an assertion exposed by loop vectorizer (#4916)

2020-02-20 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new efd35e8 [Relay] Fix an assertion

[GitHub] [incubator-tvm] soiferj opened a new pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite

2020-02-20 Thread GitBox
soiferj opened a new pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919 Based on my post [here](https://discuss.tvm.ai/t/rfc-external-codegen-defining-composite-relay-operators/5470/9), if a

[GitHub] [incubator-tvm] comaniac opened a new pull request #4920: [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale)

2020-02-20 Thread GitBox
comaniac opened a new pull request #4920: [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale) URL: https://github.com/apache/incubator-tvm/pull/4920 Continue working for #4908. This PR fixed all indent/format warnings in RST doc files, doc cross-refernece, and image scale.

[incubator-tvm] branch master updated: [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale) (#4920)

2020-02-20 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 98e7709 [DOCS] Fix Sphinx Warnings (RST

[GitHub] [incubator-tvm] sjoshi30 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess

2020-02-20 Thread GitBox
sjoshi30 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess URL: https://github.com/apache/incubator-tvm/pull/4543#discussion_r382285883 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -1113,6

[GitHub] [incubator-tvm] masahi closed issue #4918: Please add support for ATen operator of onnx

2020-02-20 Thread GitBox
masahi closed issue #4918: Please add support for ATen operator of onnx URL: https://github.com/apache/incubator-tvm/issues/4918 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] masahi commented on issue #4918: Please add support for ATen operator of onnx

2020-02-20 Thread GitBox
masahi commented on issue #4918: Please add support for ATen operator of onnx URL: https://github.com/apache/incubator-tvm/issues/4918#issuecomment-589403954 This is a pytorch specific op that is not part of the official ONNX spec. This is out of scope for our onnx frontend. Try our

[GitHub] [incubator-tvm] anijain2305 commented on issue #4816: [TFLite] Using real image for QNN testing.

2020-02-20 Thread GitBox
anijain2305 commented on issue #4816: [TFLite] Using real image for QNN testing. URL: https://github.com/apache/incubator-tvm/pull/4816#issuecomment-589420523 @masahi You are right (as always :) ) @u99127 Let me look into this.

[GitHub] [incubator-tvm] tqchen merged pull request #4920: [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale)

2020-02-20 Thread GitBox
tqchen merged pull request #4920: [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale) URL: https://github.com/apache/incubator-tvm/pull/4920 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy

2020-02-20 Thread GitBox
merrymercy commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r382324425 ## File path: python/tvm/autotvm/record.py ## @@ -119,20 +124,29 @@ def decode(row, protocol='json'):

[GitHub] [incubator-tvm] masahi commented on issue #4816: [TFLite] Using real image for QNN testing.

2020-02-20 Thread GitBox
masahi commented on issue #4816: [TFLite] Using real image for QNN testing. URL: https://github.com/apache/incubator-tvm/pull/4816#issuecomment-589375235 @u99127 I figured the answer myself. QNN support for per channel quantization applies to only weight quantization (which is supposed to

[GitHub] [incubator-tvm] sjoshi30 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess

2020-02-20 Thread GitBox
sjoshi30 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess URL: https://github.com/apache/incubator-tvm/pull/4543#discussion_r382285883 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -1113,6

[GitHub] [incubator-tvm] u99127 commented on issue #4816: [TFLite] Using real image for QNN testing.

2020-02-20 Thread GitBox
u99127 commented on issue #4816: [TFLite] Using real image for QNN testing. URL: https://github.com/apache/incubator-tvm/pull/4816#issuecomment-589299264 > > > What happen if the zero point is a vector, as in per channel quantization? What should the pad value be? @masahi

[GitHub] [incubator-tvm] u99127 commented on issue #4816: [TFLite] Using real image for QNN testing.

2020-02-20 Thread GitBox
u99127 commented on issue #4816: [TFLite] Using real image for QNN testing. URL: https://github.com/apache/incubator-tvm/pull/4816#issuecomment-589299596 @anijain2305 - this needs a backport to 0.6 tag ? This is an

[GitHub] [incubator-tvm] tqchen opened a new pull request #4921: [COMMUNITY] @anijain2305 -> Committer

2020-02-20 Thread GitBox
tqchen opened a new pull request #4921: [COMMUNITY] @anijain2305 -> Committer URL: https://github.com/apache/incubator-tvm/pull/4921 Please join us to welcome @anijain2305 as a committer. He mainly works on the area of pre-quantized model support and helped to drive high quality code to

[incubator-tvm] branch master updated (98e7709 -> f23ac96)

2020-02-20 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 98e7709 [DOCS] Fix Sphinx Warnings (RST indent, cross-ref, and image scale) (#4920) add f23ac96

[GitHub] [incubator-tvm] vinx13 merged pull request #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore

2020-02-20 Thread GitBox
vinx13 merged pull request #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore URL: https://github.com/apache/incubator-tvm/pull/4546 This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] vinx13 commented on issue #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore

2020-02-20 Thread GitBox
vinx13 commented on issue #4546: [CODEGEN] Support cuda tensorcore subbyte int data type in auto tensorcore URL: https://github.com/apache/incubator-tvm/pull/4546#issuecomment-589471873 Thanks @Orion34C @masahi @Hzfengsy @Laurawly

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite

2020-02-20 Thread GitBox
zhiics commented on a change in pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919#discussion_r382398154 ## File path: src/relay/pass/merge_composite.cc ## @@ -162,9 +164,10 @@

[incubator-tvm] branch master updated (0e189f0 -> f47c38d)

2020-02-20 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 0e189f0 Fix tests for tflite unary elemwise operations (#4913) add f47c38d [COMMUNITY] @anijain2305 ->

[GitHub] [incubator-tvm] masahi merged pull request #4921: [COMMUNITY] @anijain2305 -> Committer

2020-02-20 Thread GitBox
masahi merged pull request #4921: [COMMUNITY] @anijain2305 -> Committer URL: https://github.com/apache/incubator-tvm/pull/4921 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] slyubomirsky commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker.

2020-02-20 Thread GitBox
slyubomirsky commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker. URL: https://github.com/apache/incubator-tvm/pull/4881#issuecomment-589454169 @MarisaKirisame are you planning to update, or should I make the changes myself?

[GitHub] [incubator-tvm] tqchen commented on issue #4843: Emscripten Runtime Error while linking

2020-02-20 Thread GitBox
tqchen commented on issue #4843: Emscripten Runtime Error while linking URL: https://github.com/apache/incubator-tvm/issues/4843#issuecomment-589495625 Sorry, the corresponding thread is here https://github.com/apache/incubator-tvm/issues/2425

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy

2020-02-20 Thread GitBox
icemelon9 commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r382400455 ## File path: python/tvm/autotvm/record.py ## @@ -119,20 +124,29 @@ def decode(row, protocol='json'):

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy

2020-02-20 Thread GitBox
icemelon9 commented on a change in pull request #4644: [Relay][AutoTVM] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r382400753 ## File path: python/tvm/autotvm/record.py ## @@ -119,20 +124,29 @@ def decode(row, protocol='json'):

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite

2020-02-20 Thread GitBox
zhiics commented on a change in pull request #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919#discussion_r382401041 ## File path: src/relay/pass/merge_composite.cc ## @@ -182,6 +185,27 @@

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4885: Split node min range is not stringent.

2020-02-20 Thread GitBox
yongfeng-nv commented on issue #4885: Split node min range is not stringent. URL: https://github.com/apache/incubator-tvm/pull/4885#issuecomment-589508677 Update this PR with the same change to the split node's nparts mode. It causes two more test failures: -

[GitHub] [incubator-tvm] anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh

2020-02-20 Thread GitBox
anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-589453847 I have rebased. I am not sure if opt_level=4 is the right way. There are other optimizations as well at opt_level=4,

[GitHub] [incubator-tvm] MarisaKirisame commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker.

2020-02-20 Thread GitBox
MarisaKirisame commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker. URL: https://github.com/apache/incubator-tvm/pull/4881#issuecomment-589510228 I will do it myself. Was hoping mike will try it...

[GitHub] [incubator-tvm] FrozenGene merged pull request #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations

2020-02-20 Thread GitBox
FrozenGene merged pull request #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations URL: https://github.com/apache/incubator-tvm/pull/4913 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] FrozenGene commented on issue #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations

2020-02-20 Thread GitBox
FrozenGene commented on issue #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations URL: https://github.com/apache/incubator-tvm/pull/4913#issuecomment-589489025 Thanks @inadob @wyc-ruiker merged. This is

[incubator-tvm] branch master updated: Fix tests for tflite unary elemwise operations (#4913)

2020-02-20 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 0e189f0 Fix tests for tflite unary

[GitHub] [incubator-tvm] CoinCheung opened a new issue #4918: Please add support for ATen operator of onnx

2020-02-20 Thread GitBox
CoinCheung opened a new issue #4918: Please add support for ATen operator of onnx URL: https://github.com/apache/incubator-tvm/issues/4918 I export an onnx model from pytorch, and after running the command: ``` mod, params = relay.frontend.from_onnx(model, shape_dict,

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-02-20 Thread GitBox
siju-samuel commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r381945909 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -267,6 +267,79 @@

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4915: [Frontend][TFLite] Add parser support for 'square' operator

2020-02-20 Thread GitBox
inadob commented on a change in pull request #4915: [Frontend][TFLite] Add parser support for 'square' operator URL: https://github.com/apache/incubator-tvm/pull/4915#discussion_r381949778 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -742,26 +742,35 @@

[GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #4915: [Frontend][TFLite] Add parser support for 'square' operator

2020-02-20 Thread GitBox
wyc-ruiker commented on a change in pull request #4915: [Frontend][TFLite] Add parser support for 'square' operator URL: https://github.com/apache/incubator-tvm/pull/4915#discussion_r381872475 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -742,26

[GitHub] [incubator-tvm] FrozenGene commented on issue #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations

2020-02-20 Thread GitBox
FrozenGene commented on issue #4913: [Frontend][TFLite] Fix tests for tflite unary elemwise operations URL: https://github.com/apache/incubator-tvm/pull/4913#issuecomment-588903942 @inadob Seems our CI has some problem. Could you upload one commit and trigger the CI again? Thanks.

[GitHub] [incubator-tvm] wweic commented on a change in pull request #4628: [Object] Add String container

2020-02-20 Thread GitBox
wweic commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r381955560 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] wweic commented on issue #4628: [Object] Add String container

2020-02-20 Thread GitBox
wweic commented on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-588986264 @FrozenGene I'll do compiler test and update comment soon. This is an automated