[GitHub] [incubator-tvm] roastduck commented on pull request #5664: [TIR] Remove useless if in Simplify

2020-05-23 Thread GitBox
roastduck commented on pull request #5664: URL: https://github.com/apache/incubator-tvm/pull/5664#issuecomment-633012705 Wait. It seems this simplification is already done in the pass. This is an automated message from the

[GitHub] [incubator-tvm] roastduck closed pull request #5664: [TIR] Remove useless if in Simplify

2020-05-23 Thread GitBox
roastduck closed pull request #5664: URL: https://github.com/apache/incubator-tvm/pull/5664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5663: [POC][PatternLang]Remove constants from partitioned functions

2020-05-23 Thread GitBox
mbrookhart opened a new pull request #5663: URL: https://github.com/apache/incubator-tvm/pull/5663 Address questions in #5662 cc @comaniac @masahi This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] mbrookhart edited a comment on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
mbrookhart edited a comment on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632992650 Hey Cody. This might just be a design misalignment. When writing the partition function, I explicitly dropped the constants from the inputs because I assumed

[GitHub] [incubator-tvm] masahi commented on pull request #5663: [POC][PatternLang]Remove constants from partitioned functions

2020-05-23 Thread GitBox
masahi commented on pull request #5663: URL: https://github.com/apache/incubator-tvm/pull/5663#issuecomment-633004751 Seems you've hit a flaky test, feel free to comment it out. This is an automated message from the Apache

[GitHub] [incubator-tvm] roastduck opened a new pull request #5664: [TIR] Remove useless if in Simplify

2020-05-23 Thread GitBox
roastduck opened a new pull request #5664: URL: https://github.com/apache/incubator-tvm/pull/5664 I improved the `Simplify` transformation to remove useless `IfThenElse` nodes. If the condition of a node can be proved true or false, the condition will be removed. For example, TVM often

[GitHub] [incubator-tvm] mbrookhart edited a comment on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
mbrookhart edited a comment on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632992650 Hey Cody. This might just be a design misalignment. When writing the partition function, I explicitly dropped the constants from the inputs because I assumed we'd

[GitHub] [incubator-tvm] mbrookhart edited a comment on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
mbrookhart edited a comment on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632992650 Hey Cody. This might just be a design misalignment. When writing the partition function, I explicitly dropped the constants from the inputs because I assumed

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-05-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5600: URL: https://github.com/apache/incubator-tvm/pull/5600#discussion_r429518516 ## File path: topi/python/topi/cuda/softmax.py ## @@ -53,13 +54,61 @@ def schedule_softmax(outs): raise ValueError('Tag is expected

[GitHub] [incubator-tvm] mbrookhart commented on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
mbrookhart commented on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632992650 Hey Cody. This might just be a design misalignment. When writing the partition function, I explicitly dropped the constants from the inputs because I assumed we'd want to

[GitHub] [incubator-tvm] comaniac commented on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
comaniac commented on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632996700 Thanks for the advise! This major difference affects how the constant values will be used in the runtime, and I consider Relay functions should be used as same as Relay

[GitHub] [incubator-tvm] comaniac edited a comment on issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-23 Thread GitBox
comaniac edited a comment on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632996700 Thanks for the advise! This major difference affects how the constant values will be used in the runtime, and I consider Relay functions should be used as same as

[incubator-tvm] branch master updated: [TIR][BUILD] Remove buffer params from pass config. (#5652)

2020-05-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 0833b07 [TIR][BUILD] Remove buffer

[GitHub] [incubator-tvm] tqchen merged pull request #5652: [TIR][BUILD] Remove buffer params from pass config.

2020-05-23 Thread GitBox
tqchen merged pull request #5652: URL: https://github.com/apache/incubator-tvm/pull/5652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on pull request #5661: add tvm.micro pydoc to sphinx

2020-05-23 Thread GitBox
tqchen commented on pull request #5661: URL: https://github.com/apache/incubator-tvm/pull/5661#issuecomment-633078437 Please add the micro to here https://raw.githubusercontent.com/apache/incubator-tvm/master/docs/api/python/index.rst possibly below rpc, you can also reproduce as per the

[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-05-23 Thread GitBox
tqchen commented on pull request #5600: URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-633078719 @Shawn-Inspur please followup and https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly

[incubator-tvm-site] branch asf-site updated (71a3f12 -> e039225)

2020-05-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-tvm-site.git. discard 71a3f12 Docs build at Sat May 23 08:42:38 PDT 2020 discard 27bbdbb Build at Wed May 20 17:08:55 PDT

[incubator-tvm-site] branch asf-site updated: Update blog.html

2020-05-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e116ed8 Update blog.html

[GitHub] [incubator-tvm] kazum commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-23 Thread GitBox
kazum commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429565777 ## File path: tests/python/contrib/test_onnx.py ## @@ -0,0 +1,393 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] kazum commented on pull request #5634: [CODEGEN][CONTRIB] CoreML codegen

2020-05-23 Thread GitBox
kazum commented on pull request #5634: URL: https://github.com/apache/incubator-tvm/pull/5634#issuecomment-633106498 @tqchen @mbaret I've updated per your comments. Could you take another look? This is an automated message