[GitHub] [incubator-tvm] zhanghaohit opened a new pull request #6126: Feature/intelfocl pr

2020-07-23 Thread GitBox
zhanghaohit opened a new pull request #6126: URL: https://github.com/apache/incubator-tvm/pull/6126 This is related to #5840 and split from PR #5842 This PR only keeps the modification to TVM for opencl support This

[GitHub] [incubator-tvm] zhanghaohit commented on pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-07-23 Thread GitBox
zhanghaohit commented on pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-662859131 > @zhanghaohit I took a second look at the changes in this PR, and I believe it would be best to break the PR down into separate, smaller PRs: > > (1) modificati

[GitHub] [incubator-tvm] mikeseven commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited

2020-07-23 Thread GitBox
mikeseven commented on issue #6090: URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-662860171 The script is simply test_pass_partition_graph.py is TVM tests. Replacing `mod=WhiteListAnnotator(["add","substract","multiply"], "ccompiler")(mod)` with `mod=WhiteList

[GitHub] [incubator-tvm] kazum commented on a change in pull request #6116: [Rust] Some rust cleanups

2020-07-23 Thread GitBox
kazum commented on a change in pull request #6116: URL: https://github.com/apache/incubator-tvm/pull/6116#discussion_r459278406 ## File path: rust/tvm-sys/Cargo.toml ## @@ -32,4 +32,4 @@ ndarray = "0.12" enumn = "^0.1" [build-dependencies] -bindgen = "0.51" +bindgen = { ver

[GitHub] [incubator-tvm] jroesch commented on pull request #6124: [Relay] change device annotation from post DFS to recursive

2020-07-23 Thread GitBox
jroesch commented on pull request #6124: URL: https://github.com/apache/incubator-tvm/pull/6124#issuecomment-662877111 cc @mbrookhart This is an automated message from the Apache Git Service. To respond to the message, pleas

[incubator-tvm] branch master updated (5046ff2 -> 06d7565)

2020-07-23 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 5046ff2 [DOCS][REFACTOR] Organize Design and Architectures (#6097) add 06d7565 [Rust] Clean up convers

[GitHub] [incubator-tvm] jroesch merged pull request #6114: [Rust] Clean up conversions between TVM and Rust functions

2020-07-23 Thread GitBox
jroesch merged pull request #6114: URL: https://github.com/apache/incubator-tvm/pull/6114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6116: [Rust] Some rust cleanups

2020-07-23 Thread GitBox
jroesch commented on a change in pull request #6116: URL: https://github.com/apache/incubator-tvm/pull/6116#discussion_r459284775 ## File path: rust/tvm-sys/Cargo.toml ## @@ -32,4 +32,4 @@ ndarray = "0.12" enumn = "^0.1" [build-dependencies] -bindgen = "0.51" +bindgen = { v

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459304915 ## File path: src/runtime/contrib/arm_compute_lib/acl_runtime.cc ## @@ -163,24 +149,61 @@ class ACLRuntime : public JSONRuntimeBase { struct Cac

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459321017 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen.cc ## @@ -78,57 +90,83 @@ class ACLJSONSerializer : public backend::contrib::JSONS

[GitHub] [incubator-tvm] d-smirnov opened a new pull request #6127: quanitze operation expanded to take const argument

2020-07-23 Thread GitBox
d-smirnov opened a new pull request #6127: URL: https://github.com/apache/incubator-tvm/pull/6127 https://www.tensorflow.org/lite/performance/quantization_spec#referencesQUANTIZE (Requantization) Input 0: data_type : int8 range : [-128, 127] granularity: per

[GitHub] [incubator-tvm] giuseros commented on pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
giuseros commented on pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#issuecomment-662986592 Hi @FrozenGene , Final changes to this PR. * Introducing the `compute_at` knobs forces us to use `xgb_knob` tuner which does not support `locate_cache` annotat

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
FrozenGene commented on a change in pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#discussion_r459441879 ## File path: topi/python/topi/arm_cpu/depthwise_conv2d.py ## @@ -181,6 +181,170 @@ def depthwise_conv2d_nchw_spatial_pack(cfg, data, kernel, st

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
giuseros commented on a change in pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#discussion_r459455600 ## File path: topi/python/topi/arm_cpu/depthwise_conv2d.py ## @@ -181,6 +181,170 @@ def depthwise_conv2d_nchw_spatial_pack(cfg, data, kernel, stri

[GitHub] [incubator-tvm] TaoLv commented on pull request #6115: [Topi, x86] Using MKL blas for quantized dense

2020-07-23 Thread GitBox
TaoLv commented on pull request #6115: URL: https://github.com/apache/incubator-tvm/pull/6115#issuecomment-663028130 Better to show the performance of TVM before using MKL s8u8s32 GEMM. This is an automated message from the A

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #6066: [TIR][Transform] HoistIfThenElse added

2020-07-23 Thread GitBox
ANSHUMAN87 commented on a change in pull request #6066: URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459506386 ## File path: src/tir/transforms/hoist_if_then_else.cc ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #6066: [TIR][Transform] HoistIfThenElse added

2020-07-23 Thread GitBox
ANSHUMAN87 commented on a change in pull request #6066: URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459506386 ## File path: src/tir/transforms/hoist_if_then_else.cc ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #6066: [TIR][Transform] HoistIfThenElse added

2020-07-23 Thread GitBox
ANSHUMAN87 commented on a change in pull request #6066: URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459511992 ## File path: src/tir/transforms/hoist_if_then_else.cc ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #6066: [TIR][Transform] HoistIfThenElse added

2020-07-23 Thread GitBox
ANSHUMAN87 commented on a change in pull request #6066: URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459511992 ## File path: src/tir/transforms/hoist_if_then_else.cc ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] hanzz2007 commented on pull request #6128: [Fix] avoid unexpected throw in AttrInitEntry

2020-07-23 Thread GitBox
hanzz2007 commented on pull request #6128: URL: https://github.com/apache/incubator-tvm/pull/6128#issuecomment-663060458 @tqchen This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] hanzz2007 opened a new pull request #6128: [Fix] avoid unexpected throw in AttrInitEntry

2020-07-23 Thread GitBox
hanzz2007 opened a new pull request #6128: URL: https://github.com/apache/incubator-tvm/pull/6128 avoid unexpected throw in AttrInitEntry, as discussed in #6093 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] cloud-mxd opened a new issue #6129: NotImplementedError: The following operators are not implemented: ['aten::values']

2020-07-23 Thread GitBox
cloud-mxd opened a new issue #6129: URL: https://github.com/apache/incubator-tvm/issues/6129 I'm using file /python/tvm/relay/frontend/pytorch.py to convert pytorch model, but raise error like this: ```text Traceback (most recent call last): File "apply_opt_torch.py", line 193, i

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6119: [QNN] Excluding most negative value

2020-07-23 Thread GitBox
anijain2305 commented on pull request #6119: URL: https://github.com/apache/incubator-tvm/pull/6119#issuecomment-663077305 I realized that this is more of scale calculation instead of quantize or dequantize calculation. Therefore, this should be considered where we are quantizing the model

[GitHub] [incubator-tvm] anijain2305 closed pull request #6119: [QNN] Excluding most negative value

2020-07-23 Thread GitBox
anijain2305 closed pull request #6119: URL: https://github.com/apache/incubator-tvm/pull/6119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] anijain2305 merged pull request #6110: Improve reduction schedule on arm CPUs

2020-07-23 Thread GitBox
anijain2305 merged pull request #6110: URL: https://github.com/apache/incubator-tvm/pull/6110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch master updated (06d7565 -> 9d34eaa)

2020-07-23 Thread anijain2305
This is an automated email from the ASF dual-hosted git repository. anijain2305 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 06d7565 [Rust] Clean up conversions between TVM and Rust functions (#6114) add 9d34eaa Improve re

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6110: Improve reduction schedule on arm CPUs

2020-07-23 Thread GitBox
anijain2305 commented on pull request #6110: URL: https://github.com/apache/incubator-tvm/pull/6110#issuecomment-663078598 Thanks @giuseros This is merged! This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] comaniac commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited

2020-07-23 Thread GitBox
comaniac commented on issue #6090: URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-663080925 The message you posted is expected. `ccompiler` is only used for demonstration purpose, and we don't expect to suppose more ops for it. The fallback mechanism on CPU is to use

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
anijain2305 commented on a change in pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#discussion_r459545611 ## File path: python/tvm/relay/op/strategy/arm_cpu.py ## @@ -161,11 +161,11 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type, target):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
comaniac commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459551485 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen.cc ## @@ -78,57 +90,83 @@ class ACLJSONSerializer : public backend::contrib::JSONS

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459571834 ## File path: src/runtime/contrib/arm_compute_lib/acl_runtime.cc ## @@ -163,24 +149,61 @@ class ACLRuntime : public JSONRuntimeBase { struct Cac

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459578673 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen.cc ## @@ -78,57 +90,83 @@ class ACLJSONSerializer : public backend::contrib::JSONS

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459603811 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
comaniac commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459604117 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen.cc ## @@ -78,57 +90,83 @@ class ACLJSONSerializer : public backend::contrib::JSONS

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459604438 ## File path: src/runtime/contrib/arm_compute_lib/acl_utils.cc ## @@ -108,6 +111,30 @@ arm_compute::PadStrideInfo ToACLPadStride(const std::vector

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6115: [Topi, x86] Using MKL blas for quantized dense

2020-07-23 Thread GitBox
anijain2305 commented on pull request #6115: URL: https://github.com/apache/incubator-tvm/pull/6115#issuecomment-663128946 @TaoLv Good point, I added the latency numbers for TVM alone. Thanks for pointing it out! This is an

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
comaniac commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459606833 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459608769 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np

[GitHub] [incubator-tvm] csullivan commented on a change in pull request #6085: [Relay][OP] Support NMSv4

2020-07-23 Thread GitBox
csullivan commented on a change in pull request #6085: URL: https://github.com/apache/incubator-tvm/pull/6085#discussion_r459608948 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -637,10 +637,11 @@ def _impl(inputs, attr, params, mod): iou_threshold = np.a

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
comaniac commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459616949 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
zhiics commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459618012 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np.r

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459624243 ## File path: src/runtime/contrib/arm_compute_lib/acl_utils.cc ## @@ -108,6 +111,30 @@ arm_compute::PadStrideInfo ToACLPadStride(const std::vector

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6109: [BYOC][ACL] Support asymmetric per-layer quantized operators

2020-07-23 Thread GitBox
lhutton1 commented on a change in pull request #6109: URL: https://github.com/apache/incubator-tvm/pull/6109#discussion_r459626275 ## File path: tests/python/contrib/test_arm_compute_lib/test_conv2d.py ## @@ -127,51 +241,31 @@ def test_conv2d(): device = Device() np

[GitHub] [incubator-tvm] trevor-m commented on pull request #6108: Fix CUDA Compute Function For `get_valid_counts` and `nms`

2020-07-23 Thread GitBox
trevor-m commented on pull request #6108: URL: https://github.com/apache/incubator-tvm/pull/6108#issuecomment-663152986 IIRC, data arrangement was removed from get_valid_counts to improve performance because the data arrangement would be done by NMS anyway. Does this PR maintain the perfor

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6118: Add 'get_num_inputs' to GraphRuntime

2020-07-23 Thread GitBox
junrushao1994 commented on pull request #6118: URL: https://github.com/apache/incubator-tvm/pull/6118#issuecomment-663159381 just curious, what is it used for? This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
junrushao1994 commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459194418 ## File path: tests/python/unittest/test_auto_scheduler_loop_state.py ## @@ -143,6 +143,282 @@ def test_compute_at_root_inline(): assert

[GitHub] [incubator-tvm] jwfromm commented on pull request #5235: [RELAY][Fix] i64 indices

2020-07-23 Thread GitBox
jwfromm commented on pull request #5235: URL: https://github.com/apache/incubator-tvm/pull/5235#issuecomment-663174713 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#discussion_r459691514 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -126,6 +555,7 @@ class FlopEstimator : public ExprFunctor { fail_ = true;

[GitHub] [incubator-tvm] jwfromm commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
jwfromm commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663203960 I did a few tests with the script you provided and I'm fairly certain this has nothing to do with `apply_history_best`. I think this is instead an issue of whether tophub sched

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5955: Register Shape Func for Some Operators to Handle Dynamic Shapes

2020-07-23 Thread GitBox
icemelon9 commented on pull request #5955: URL: https://github.com/apache/incubator-tvm/pull/5955#issuecomment-663214236 Thanks @lsy643 This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-tvm] branch master updated (9d34eaa -> fe76196)

2020-07-23 Thread haichen
This is an automated email from the ASF dual-hosted git repository. haichen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 9d34eaa Improve reduction schedule on arm CPUs (#6110) add fe76196 Register Shape Func for Some Operat

[GitHub] [incubator-tvm] icemelon9 merged pull request #5955: Register Shape Func for Some Operators to Handle Dynamic Shapes

2020-07-23 Thread GitBox
icemelon9 merged pull request #5955: URL: https://github.com/apache/incubator-tvm/pull/5955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-tvm] merrymercy commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663218666 I ran the code and found adding `compile_engine.get().clear()` before `with autotvm.apply_history_best(log_filename):` acutally fixes the issue. This issue is not related

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663218666 I ran the code and found adding `compile_engine.get().clear()` before `with autotvm.apply_history_best(log_filename):` acutally fixes the issue. This issue is not

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663218666 I ran the code and found adding `compile_engine.get().clear()` before `with autotvm.apply_history_best(log_filename):` acutally fixes the issue. This issue is not

[GitHub] [incubator-tvm] merrymercy commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663221391 To prevent such bugs happening again, we can force relay to clear the cache after every `relay.build` This

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663221391 To prevent such issues happening again, we can force relay to clear the cache after every `relay.build` -

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663221391 To prevent such issues from happening again, we can force relay to clear the cache after every `relay.build`

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663221391 To prevent such issues from happening again, we can force relay to clear the cache after every `relay.build`. So the cache mechanism in relay only works within a si

[GitHub] [incubator-tvm] tkonolige commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
tkonolige commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663223033 Now it is working with `compile_engine.get().clear()`, but I had to remove the tuning log first. This is an

[GitHub] [incubator-tvm] merrymercy commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663229677 What do you mean by `remove the tuning log`? If you add `compile_engine.get().clear()`, then the result of `python3 example.py extract` will match the result of `python3 e

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663229677 What do you mean by "remove the tuning log"? If you add `compile_engine.get().clear()`, then the result of `python3 example.py extract` will match the result of `py

[GitHub] [incubator-tvm] jwfromm commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
jwfromm commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663229748 @merrymercy, it seems like the keys are still being saved in the DispatchContext memory even after clearing the cache. An easy to way to see this is doing build twice on the sa

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
jroesch commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459719321 ## File path: src/auto_scheduler/loop_state.h ## @@ -358,19 +369,43 @@ class State : public ObjectRef { void compute_at(int stage_id, int target_

[GitHub] [incubator-tvm] zhiics commented on pull request #5235: [RELAY][Fix] i64 indices

2020-07-23 Thread GitBox
zhiics commented on pull request #5235: URL: https://github.com/apache/incubator-tvm/pull/5235#issuecomment-663231777 Thanks @hzfan @jwfromm @tqchen @kazum This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (fe76196 -> 6dbc344)

2020-07-23 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from fe76196 Register Shape Func for Some Operators to Handle Dynamic Shapes (#5955) add 6dbc344 [RELAY][Fix]

[GitHub] [incubator-tvm] jroesch commented on pull request #6116: [Rust] Some rust cleanups

2020-07-23 Thread GitBox
jroesch commented on pull request #6116: URL: https://github.com/apache/incubator-tvm/pull/6116#issuecomment-663231660 Thanks Jason! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] zhiics merged pull request #5235: [RELAY][Fix] i64 indices

2020-07-23 Thread GitBox
zhiics merged pull request #5235: URL: https://github.com/apache/incubator-tvm/pull/5235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch master updated (6dbc344 -> 0a1c4c2)

2020-07-23 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 6dbc344 [RELAY][Fix] i64 indices (#5235) add 0a1c4c2 [Rust] Some rust cleanups (#6116) No new revisio

[GitHub] [incubator-tvm] tkonolige commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
tkonolige commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663231546 @merrymercy When I tested `compile_engine.get().clear()` the first time I might have had a corrupted or incorrect tuning log. The second time I test `compile_engine.get().cle

[GitHub] [incubator-tvm] jroesch merged pull request #6116: [Rust] Some rust cleanups

2020-07-23 Thread GitBox
jroesch merged pull request #6116: URL: https://github.com/apache/incubator-tvm/pull/6116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] merrymercy commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663232365 @jroesch Yes, the behavior you mentioned is desired. That is designed by me to mimic the behavior of `logging.warning` in python's built-in library. The principle is that a

[GitHub] [incubator-tvm] merrymercy edited a comment on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy edited a comment on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663232365 @jroesch Yes, the behavior you mentioned is desired. That is designed by me to mimic the behavior of `logging.warning` in python's built-in library. The principle is

[GitHub] [incubator-tvm] jwfromm commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
jwfromm commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663233076 ok that all makes sense to me, thanks for the clarification @merrymercy! This is an automated message from the

[GitHub] [incubator-tvm] jwfromm commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
jwfromm commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663233439 We should probably try to upstream a PR that adds `compile_engine.get().clear()` to the end of the `relay.build` function.

[GitHub] [incubator-tvm] giuseros commented on pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
giuseros commented on pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#issuecomment-663233922 I probably enabled a CUDA test that was making the CI hang. I reverted the test hoping that this was the issue --

[GitHub] [incubator-tvm] jroesch commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
jroesch commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663234072 @tkonolige @jwfromm yeah the caching makes sense to me, this is why I was against it a long time ago 😆 . I think we should add to the C++ implementation of `build` to ensure th

[GitHub] [incubator-tvm] merrymercy commented on issue #6096: apply_history_best requires extract_from_program to be run even if log file already exists

2020-07-23 Thread GitBox
merrymercy commented on issue #6096: URL: https://github.com/apache/incubator-tvm/issues/6096#issuecomment-663238657 To conclude, the current cache mechanism in relay works globally across different calls to `relay.build`. If we want to use two different schedules for the same relay subgra

[GitHub] [incubator-tvm] ymwangg opened a new pull request #6130: [AutoTVM][BugFix] Fix autotvm on the conv2d_nchw_winograd.mali operator

2020-07-23 Thread GitBox
ymwangg opened a new pull request #6130: URL: https://github.com/apache/incubator-tvm/pull/6130 This PR fixes two bugs related to autotvm on the `conv2d_nchw_winograd.mali` operator. - KeyError when computing`kvshape` - Duplicate args returned by `autotvm.task.task.TaskTemplate.get_in

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#discussion_r459749490 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -114,7 +118,432 @@ Array TopoSortOps(const Array& tensors) { return ops; } -// Estim

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#discussion_r459749921 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -114,7 +118,432 @@ Array TopoSortOps(const Array& tensors) { return ops; } -// Estim

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#discussion_r459749921 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -114,7 +118,432 @@ Array TopoSortOps(const Array& tensors) { return ops; } -// Estim

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#discussion_r459750828 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -114,7 +118,432 @@ Array TopoSortOps(const Array& tensors) { return ops; } -// Estim

[GitHub] [incubator-tvm] giuseros commented on pull request #6095: Improve NHWC depthwise convolution for AArch64

2020-07-23 Thread GitBox
giuseros commented on pull request #6095: URL: https://github.com/apache/incubator-tvm/pull/6095#issuecomment-663266858 @FrozenGene , @anijain2305 , This is my last commit before holidays. I enabled only the `arm_cpu` tests (everything passes locally). The case with `dilation>1` will be

[GitHub] [incubator-tvm] tkonolige opened a new pull request #6131: [FIX] Fixes #6096

2020-07-23 Thread GitBox
tkonolige opened a new pull request #6131: URL: https://github.com/apache/incubator-tvm/pull/6131 Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops. Note: this

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6131: [FIX] Fixes #6096

2020-07-23 Thread GitBox
jroesch commented on a change in pull request #6131: URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r459773263 ## File path: src/relay/backend/build_module.cc ## @@ -225,6 +226,8 @@ class RelayBuildModule : public runtime::ModuleNode { targets_ = targets

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6131: [FIX] Fixes #6096

2020-07-23 Thread GitBox
comaniac commented on a change in pull request #6131: URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r459777668 ## File path: python/tvm/autotvm/task/relay_integration.py ## @@ -140,6 +140,11 @@ def extract_from_multiple_program(mods, params, target, target_

[GitHub] [incubator-tvm] merrymercy commented on pull request #6103: [Ansor][AutoTVM v2.0] Phase 1: Access Analyzer

2020-07-23 Thread GitBox
merrymercy commented on pull request #6103: URL: https://github.com/apache/incubator-tvm/pull/6103#issuecomment-663276179 @junrushao1994 @jcf94 @comaniac Most of the comments are addressed. I added more doc and make the name convention more consistent and meaningful. Please take another l

[GitHub] [incubator-tvm] zhiics commented on pull request #6118: Add 'get_num_inputs' to GraphRuntime

2020-07-23 Thread GitBox
zhiics commented on pull request #6118: URL: https://github.com/apache/incubator-tvm/pull/6118#issuecomment-663303284 The number contains both inputs and weights. Is that what you want? This is an automated message from the A

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459808071 ## File path: python/tvm/auto_scheduler/loop_state.py ## @@ -351,6 +351,72 @@ def compute_root(self, stage): self.state_object = _ffi_ap

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459808071 ## File path: python/tvm/auto_scheduler/loop_state.py ## @@ -351,6 +351,72 @@ def compute_root(self, stage): self.state_object = _ffi_ap

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459808071 ## File path: python/tvm/auto_scheduler/loop_state.py ## @@ -351,6 +351,72 @@ def compute_root(self, stage): self.state_object = _ffi_ap

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459808487 ## File path: python/tvm/auto_scheduler/loop_state.py ## @@ -351,6 +351,72 @@ def compute_root(self, stage): self.state_object = _ffi_ap

[GitHub] [incubator-tvm] leonwanghui commented on a change in pull request #5892: Add TVM application extension with WASM runtime

2020-07-23 Thread GitBox
leonwanghui commented on a change in pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#discussion_r459808855 ## File path: apps/wasm-standalone/wasm-graph/src/utils.rs ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
jcf94 commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459809086 ## File path: tests/python/unittest/test_auto_scheduler_loop_state.py ## @@ -143,6 +143,282 @@ def test_compute_at_root_inline(): assert s0[conv]

[GitHub] [incubator-tvm] leonwanghui commented on a change in pull request #5892: Add TVM application extension with WASM runtime

2020-07-23 Thread GitBox
leonwanghui commented on a change in pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#discussion_r459809422 ## File path: apps/wasm-standalone/wasm-graph/src/utils.rs ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
jcf94 commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459809462 ## File path: src/auto_scheduler/loop_state.h ## @@ -195,6 +197,17 @@ class AttachMap : public ObjectRef { void UpdateIters(const std::vector& orig

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459809485 ## File path: src/auto_scheduler/loop_state.h ## @@ -225,6 +238,13 @@ class StateNode : public Object { * operation. */ AttachMap atta

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459809485 ## File path: src/auto_scheduler/loop_state.h ## @@ -225,6 +238,13 @@ class StateNode : public Object { * operation. */ AttachMap atta

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6107: [Ansor][AutoTVM v2.0] Phase 1: Add cache_read/cache_write steps

2020-07-23 Thread GitBox
merrymercy commented on a change in pull request #6107: URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r459810059 ## File path: src/auto_scheduler/transform_step.cc ## @@ -923,5 +958,272 @@ String ComputeRootStepNode::PrintAsPythonAPI(Array* stages, retur

  1   2   >