[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6965: [AutoScheduler] Fix task extraction

2020-11-23 Thread GitBox
merrymercy commented on a change in pull request #6965: URL: https://github.com/apache/incubator-tvm/pull/6965#discussion_r529263752 ## File path: python/tvm/relay/backend/compile_engine.py ## @@ -186,6 +186,11 @@ def select_implementation(op, attrs, inputs, out_type, target,

[GitHub] [incubator-tvm] areusch commented on pull request #6948: [µTVM] Allow for platform-specific malloc in runtime

2020-11-23 Thread GitBox
areusch commented on pull request #6948: URL: https://github.com/apache/incubator-tvm/pull/6948#issuecomment-732693961 @tqchen @liangfu @u99127 @manupa-arm @tom-gall This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6899: Add initial support for quantized transpose convolution in Relay

2020-11-23 Thread GitBox
mbaret commented on a change in pull request #6899: URL: https://github.com/apache/incubator-tvm/pull/6899#discussion_r528696443 ## File path: python/tvm/relay/qnn/op/legalizations.py ## @@ -46,6 +52,25 @@ def qnn_conv2d_legalize(attrs, inputs, types): return None +#

[GitHub] [incubator-tvm] manupa-arm opened a new pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
manupa-arm opened a new pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950 * Current flow uses saves the module as a c source and compiles it seperately. This blocks multi-module compilation. * This patch upgrades it to use export_library which supports external

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
tqchen commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528718197 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #6899: Add initial support for quantized transpose convolution in Relay

2020-11-23 Thread GitBox
giuseros commented on a change in pull request #6899: URL: https://github.com/apache/incubator-tvm/pull/6899#discussion_r528801570 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -1124,53 +1126,124 @@ def _test_transpose_conv(tensor_in_sizes, filter_in_sizes,

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528759768 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,32 @@ class AnnotateTargetRewriter : public ExprRewriter { *

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528787976 ## File path: src/relay/transforms/annotate_target.cc ## @@ -146,13 +179,19 @@ class AnnotateTargetRewriter : public ExprRewriter { //

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #6949: [TF frontend] add support for StridedSlice to input a single constant

2020-11-23 Thread GitBox
giuseros commented on a change in pull request #6949: URL: https://github.com/apache/incubator-tvm/pull/6949#discussion_r528806931 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1599,6 +1599,9 @@ def _impl(inputs, attr, params, mod): data_shape =

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528697334 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,32 @@ class AnnotateTargetRewriter : public ExprRewriter { *

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528775498 ## File path: src/relay/transforms/annotate_target.cc ## @@ -161,8 +200,9 @@ class AnnotateTargetRewriter : public ExprRewriter { const

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528788103 ## File path: src/relay/transforms/annotate_target.cc ## @@ -93,18 +106,20 @@ class AnnotateTargetRewriter : public ExprRewriter { if

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528806349 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6907: AArch64 base algorithm refactoring in LLVM

2020-11-23 Thread GitBox
mbaret commented on a change in pull request #6907: URL: https://github.com/apache/incubator-tvm/pull/6907#discussion_r528691885 ## File path: python/tvm/topi/arm_cpu/tensor_intrin.py ## @@ -447,28 +97,317 @@ def gemm_quantized(M, N, K, unroll, interleave, in_type, out_type):

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
kparzysz-quic commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528746281 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [incubator-tvm] tom-gall opened a new pull request #6957: Fix #6954 uTVM, fix when building the runtime for native hardware

2020-11-23 Thread GitBox
tom-gall opened a new pull request #6957: URL: https://github.com/apache/incubator-tvm/pull/6957 with -march= is missing. This fix: 1) adds support for march 2) picks a senable setting for f746 discovery There is an interesting downside to this fix involving scheduling

[GitHub] [incubator-tvm] manupa-arm edited a comment on pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
manupa-arm edited a comment on pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#issuecomment-732372088 @comaniac , Likewise this is also for demonstration purpose but in the uTVM contex. i.e., if we can annotate and offload a set of operations and produce a

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528967519 ## File path: src/relay/transforms/annotate_target.cc ## @@ -61,20 +67,27 @@ class AnnotateTargetRewriter : public ExprRewriter { std::pair>

[GitHub] [incubator-tvm] tqchen commented on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen commented on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time of libtvm (since the popen worker also import tvm during startup). Otherwise it won't be available

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time of libtvm (since the popen worker also import tvm during startup). Otherwise it won't be

[GitHub] [incubator-tvm] tqchen commented on pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
tqchen commented on pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953#issuecomment-732434059 It might be helpful to discuss a scenario when this happens. Since in many cases we would indeed want to abort, as opposed to retry when an interrupt happens

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
tqchen commented on a change in pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953#discussion_r528996912 ## File path: src/support/socket.h ## @@ -68,6 +68,28 @@ static inline int poll(struct pollfd* pfd, int nfds, int timeout) { namespace tvm {

[GitHub] [incubator-tvm] tqchen merged pull request #6947: [µTVM] Remove binutils module, no longer needed after microTVM refactor.

2020-11-23 Thread GitBox
tqchen merged pull request #6947: URL: https://github.com/apache/incubator-tvm/pull/6947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch main updated: [µTVM] Remove binutils module, no longer needed after microTVM refactor. (#6947)

2020-11-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/main by this push: new 1541c76 [µTVM] Remove binutils module, no

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528781372 ## File path: src/relay/transforms/annotate_target.cc ## @@ -203,16 +242,18 @@ class AnnotateTargetRewriter : public ExprRewriter { }

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6945: [AutoScheduler] Task scheduler callbacks

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#discussion_r528923005 ## File path: tutorials/auto_scheduler/tune_network_cuda.py ## @@ -186,7 +189,9 @@ def run_tuning(): print("Begin tuning...")

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6945: [AutoScheduler] Task scheduler callbacks

2020-11-23 Thread GitBox
merrymercy commented on a change in pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#discussion_r528946151 ## File path: tutorials/auto_scheduler/tune_network_cuda.py ## @@ -168,6 +168,10 @@ def get_network(name, batch_size, layout="NHWC",

[GitHub] [incubator-tvm] tqchen commented on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen commented on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732382694 cc @merrymercy @tkonolige @junrushao1994 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen commented on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732391402 Additional note: the system overhead of the popen pool and multiprocess.Pool is around 1e-4 sec/item. Which means they can be used to perform heavy duty tasks like

[GitHub] [incubator-tvm] tkonolige commented on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tkonolige commented on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732394788 How does this work when a user registers a function? Will the registered function be available in the subprocess?

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#discussion_r528914198 ## File path: python/tvm/micro/build.py ## @@ -162,7 +158,12 @@ def build_static_runtime( libs.append(compiler.library(lib_build_dir,

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time of libtvm (since the popen worker also import tvm during startup). Otherwise it won't be

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time when tvm is imported (since the popen worker also import tvm during startup). Otherwise it

[GitHub] [incubator-tvm] tom-gall opened a new pull request #6961: Fixes #6960 - strncpy destination size warning

2020-11-23 Thread GitBox
tom-gall opened a new pull request #6961: URL: https://github.com/apache/incubator-tvm/pull/6961 The destination of the strncpy has to be larger then the source, otherwise specified bound 1024 equals destination size [-Werror=stringop-truncation] will occur. Signed-off-by: Tom

[GitHub] [incubator-tvm] hypercubestart opened a new pull request #6963: [Frontend][Relay][Parser] fix unparsable yolo formals

2020-11-23 Thread GitBox
hypercubestart opened a new pull request #6963: URL: https://github.com/apache/incubator-tvm/pull/6963 fix #6962 , replaces the "." character from modules imported using the darknet frontend, which is unparsable by the relay parser. Replaces with the "_" character. cc: @jroesch

[GitHub] [incubator-tvm] comaniac commented on pull request #6945: [AutoScheduler] Task scheduler callbacks

2020-11-23 Thread GitBox
comaniac commented on pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#issuecomment-732359484 @merrymercy @FrozenGene PTAL. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] comaniac opened a new pull request #6958: [PatternLang] Remove unnecessary check

2020-11-23 Thread GitBox
comaniac opened a new pull request #6958: URL: https://github.com/apache/incubator-tvm/pull/6958 Fix the problem reported by https://discuss.tvm.apache.org/t/mergecomposite-error-when-defining-custom-pattern/8505 This is an

[GitHub] [incubator-tvm] tqchen opened a new pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen opened a new pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959 PopenPoolExecutor implements a ProcessPoolExecutor backed by popen. - Only handles invoking functions in tvm namespace. - Unlike multiprocessing, does not require __main__ block,

[GitHub] [incubator-tvm] mbaret merged pull request #6907: AArch64 base algorithm refactoring in LLVM

2020-11-23 Thread GitBox
mbaret merged pull request #6907: URL: https://github.com/apache/incubator-tvm/pull/6907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch main updated (1541c76 -> 5423ffe)

2020-11-23 Thread mbaret
This is an automated email from the ASF dual-hosted git repository. mbaret pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 1541c76 [µTVM] Remove binutils module, no longer needed after microTVM refactor. (#6947) add 5423ffe

[GitHub] [incubator-tvm] mbaret commented on pull request #6899: Add initial support for quantized transpose convolution in Relay

2020-11-23 Thread GitBox
mbaret commented on pull request #6899: URL: https://github.com/apache/incubator-tvm/pull/6899#issuecomment-732404232 cc @siju-samuel @FrozenGene if you're interested This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time when tvm is imported (since the popen worker also import tvm during startup). Otherwise it

[GitHub] [incubator-tvm] hypercubestart opened a new issue #6962: [Frontend][Relay] YOLO module is unparsable

2020-11-23 Thread GitBox
hypercubestart opened a new issue #6962: URL: https://github.com/apache/incubator-tvm/issues/6962 The module generated from the code in this tutorial: https://tvm.apache.org/docs/tutorials/frontend/from_darknet.html causes the following error when parsed by: ``` import tvm

[GitHub] [incubator-tvm] comaniac opened a new pull request #6956: [Bugfix][AutoScheduler] Strictly select impl using plevel

2020-11-23 Thread GitBox
comaniac opened a new pull request #6956: URL: https://github.com/apache/incubator-tvm/pull/6956 Fix the issue that auto_scheduler selects the implementation based on AutoTVM logs. This is an automated message from the

[GitHub] [incubator-tvm] manupa-arm commented on pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
manupa-arm commented on pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#issuecomment-732372088 @comaniac , Likewise this is also for demonstration purpose but in the uTVM contex. i.e., if we can annotate and offload a set of operations and produce a c-source

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#discussion_r528963561 ## File path: src/relay/backend/contrib/codegen_c/codegen_c.h ## @@ -235,14 +289,14 @@ class CodegenCBase { continue; }

[GitHub] [incubator-tvm] mbaret commented on pull request #6907: AArch64 base algorithm refactoring in LLVM

2020-11-23 Thread GitBox
mbaret commented on pull request #6907: URL: https://github.com/apache/incubator-tvm/pull/6907#issuecomment-732401816 This is now merged, thanks @giuseros ! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time when tvm is imported (since the popen worker also import tvm during startup). Otherwise it

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time when tvm is imported (since the popen worker also import tvm during startup). Otherwise it

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6959: [CONTRIB] PopenPoolExecutor

2020-11-23 Thread GitBox
tqchen edited a comment on pull request #6959: URL: https://github.com/apache/incubator-tvm/pull/6959#issuecomment-732405908 In that case the function will need to be registered at the startup time when tvm is imported (since the popen worker also import tvm during startup). Otherwise it

[GitHub] [incubator-tvm] tom-gall opened a new issue #6960: strncpy in TVMAPISetLastError needs to make sure that the copied string is less then the size of the destination

2020-11-23 Thread GitBox
tom-gall opened a new issue #6960: URL: https://github.com/apache/incubator-tvm/issues/6960 When building the micro tvm runtime with Zephyr Including boilerplate (Zephyr base): /lkft/tgall/zephyrproject/zephyr/cmake/app/boilerplate.cmake In file included from

[GitHub] [incubator-tvm] tom-gall commented on issue #6960: strncpy in TVMAPISetLastError needs to make sure that the copied string is less then the size of the destination

2020-11-23 Thread GitBox
tom-gall commented on issue #6960: URL: https://github.com/apache/incubator-tvm/issues/6960#issuecomment-732414013 @areusch - minor bug This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528990741 ## File path: src/relay/transforms/annotate_target.cc ## @@ -61,20 +67,27 @@ class AnnotateTargetRewriter : public ExprRewriter { std::pair>

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528787976 ## File path: src/relay/transforms/annotate_target.cc ## @@ -146,13 +179,19 @@ class AnnotateTargetRewriter : public ExprRewriter { //

[GitHub] [incubator-tvm] comaniac commented on pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
comaniac commented on pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#issuecomment-732342167 I'm not familiar with uTVM. Out of curiosity, how uTVM uses BYOC codegen C? I ask because BYOC codegen C is just for demonstration purpose so its functionality is not

[GitHub] [incubator-tvm] rkimball opened a new pull request #6952: Fix code to work with cmake 3.2

2020-11-23 Thread GitBox
rkimball opened a new pull request #6952: URL: https://github.com/apache/incubator-tvm/pull/6952 tvm minimum cmake is 3.2 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] tom-gall opened a new issue #6954: uTVM fails to build runtime for Arm Target

2020-11-23 Thread GitBox
tom-gall opened a new issue #6954: URL: https://github.com/apache/incubator-tvm/issues/6954 given: TARGET = tvm.target.target.micro("stm32f746xx") with tvm.transform.PassContext( opt_level=3, config={"tir.disable_vectorize": True}, disabled_pass=["FuseOps"] ):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528914573 ## File path: src/relay/transforms/annotate_target.cc ## @@ -61,20 +67,27 @@ class AnnotateTargetRewriter : public ExprRewriter { std::pair>

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528871200 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -212,9 +212,12 @@ def after(): mod = tvm.IRModule.from_expr(f)

[GitHub] [incubator-tvm] manupa-arm commented on pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-23 Thread GitBox
manupa-arm commented on pull request #6950: URL: https://github.com/apache/incubator-tvm/pull/6950#issuecomment-732326410 cc: @tqchen @areusch @zhiics @comaniac This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r528879637 ## File path: src/relay/transforms/annotate_target.cc ## @@ -93,18 +106,20 @@ class AnnotateTargetRewriter : public ExprRewriter { if

[GitHub] [incubator-tvm] rkimball opened a new pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
rkimball opened a new pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953 Long-running system calls like socket recv or send may be interrupted and should be retried. If a call is interrupted errno is set to EINTR. Added retry_call which retries a call in hopes of

[GitHub] [incubator-tvm] codeislife99 opened a new pull request #6955: Dynamic Batch Support for TRT

2020-11-23 Thread GitBox
codeislife99 opened a new pull request #6955: URL: https://github.com/apache/incubator-tvm/pull/6955 This PR adds support for dynamic batch size for dense, conv , conv_transpose and ops surrounding them This is an

[GitHub] [incubator-tvm] rkimball opened a new pull request #6951: Cleanup comments in partition pass

2020-11-23 Thread GitBox
rkimball opened a new pull request #6951: URL: https://github.com/apache/incubator-tvm/pull/6951 Minor comment cleanup This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r529032585 ## File path: src/relay/transforms/annotate_target.cc ## @@ -61,20 +67,27 @@ class AnnotateTargetRewriter : public ExprRewriter { std::pair>

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529054684 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[incubator-tvm] branch main updated (5423ffe -> f2532fa)

2020-11-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 5423ffe AArch64 base algorithm refactoring in LLVM (#6907) add f2532fa Fix code to work with cmake 3.2

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-23 Thread GitBox
d-smirnov commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r529015930 ## File path: src/relay/transforms/annotate_target.cc ## @@ -61,20 +67,27 @@ class AnnotateTargetRewriter : public ExprRewriter { std::pair>

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529046179 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529046435 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529054544 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529055404 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,90 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529045831 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-732493735 @kparzysz-quic addressed those comments. @manupa-arm @tqchen @ZihengJiang please take another look when you have a minute and explicit approve if you're ok with this

[GitHub] [incubator-tvm] zhiics commented on pull request #6951: Cleanup comments in partition pass

2020-11-23 Thread GitBox
zhiics commented on pull request #6951: URL: https://github.com/apache/incubator-tvm/pull/6951#issuecomment-732636211 Thanks @rkimball, @comaniac This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] zhiics merged pull request #6951: Cleanup comments in partition pass

2020-11-23 Thread GitBox
zhiics merged pull request #6951: URL: https://github.com/apache/incubator-tvm/pull/6951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch main updated (9d71cea -> b2e418c)

2020-11-23 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 9d71cea [AutoScheduler] Task scheduler callbacks (#6945) add b2e418c Cleanup comments (#6951) No new

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
FrozenGene commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529190766 ## File path: pyproject.toml ## @@ -46,3 +46,95 @@ exclude = ''' )/ ) ''' +[tool.poetry] +name = "incubator-tvm" +version = "0.1.0"

[GitHub] [incubator-tvm] areusch opened a new pull request #6964: [µTVM] Add platform timer and RPCTimeEvaluator to enable AutoTVM

2020-11-23 Thread GitBox
areusch opened a new pull request #6964: URL: https://github.com/apache/incubator-tvm/pull/6964 This PR adds a platform-specific timing function plus a device-side implementation of RPCTimeEvaluator. In a follow-on, an AutoTVM test will be added (there are a few different dependent PRs in

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529196680 ## File path: src/relay/backend/build_module.cc ## @@ -443,16 +456,35 @@ class RelayBuildModule : public runtime::ModuleNode { auto

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529196981 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] merrymercy opened a new pull request #6965: [AutoScheduler] Fix task extraction

2020-11-23 Thread GitBox
merrymercy opened a new pull request #6965: URL: https://github.com/apache/incubator-tvm/pull/6965 Followup of #6956 . The previous PR does not work for the cases where `select_implementation` is during alter op layout in TOPI.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
tqchen commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529091748 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen commented on pull request #6963: [Frontend][Relay][Parser] fix unparsable yolo formals

2020-11-23 Thread GitBox
tqchen commented on pull request #6963: URL: https://github.com/apache/incubator-tvm/pull/6963#issuecomment-732515210 opencv is only available in ci-gpu but not ci-cpu This is an automated message from the Apache Git

[GitHub] [incubator-tvm] areusch commented on pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-732517715 @tqchen it seems like the main benefit is supporting bfloat16...i'd like to argue that's out of scope for this PR. further, we don't really have a big-endian board handy

[incubator-tvm] branch main updated (f2532fa -> 4191ae5)

2020-11-23 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f2532fa Fix code to work with cmake 3.2 (#6952) add 4191ae5 [PatternLang] Remove unnecessary check

[GitHub] [incubator-tvm] comaniac merged pull request #6958: [PatternLang] Remove unnecessary check

2020-11-23 Thread GitBox
comaniac merged pull request #6958: URL: https://github.com/apache/incubator-tvm/pull/6958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] tqchen commented on pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
tqchen commented on pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953#issuecomment-732435998 cc @areusch This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] areusch edited a comment on pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
areusch edited a comment on pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953#issuecomment-732439367 hey @rkimball one case where this may occur is a Ctrl+C-triggered SIGINT. are you encountering that case? if so, this is the mechanism by which we decide to

[GitHub] [incubator-tvm] areusch commented on pull request #6953: Add retry to sockets on EINTR error

2020-11-23 Thread GitBox
areusch commented on pull request #6953: URL: https://github.com/apache/incubator-tvm/pull/6953#issuecomment-732439367 hey @rkimball one case where this may occur is a Ctrl+C-triggered SIGINT. are you encountering that case? if so, this is the mechanism by which we decide to terminate TVM

[GitHub] [incubator-tvm] tqchen merged pull request #6952: Fix code to work with cmake 3.2

2020-11-23 Thread GitBox
tqchen merged pull request #6952: URL: https://github.com/apache/incubator-tvm/pull/6952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
tqchen commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529090811 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
tqchen commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-732512517 I still think we can print all values by their bits and print via uint. Unless there is a very strange endian being used. It would also helps us to support types that are

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-23 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r529096993 ## File path: src/target/source/codegen_params.cc ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] comaniac merged pull request #6956: [Bugfix][AutoScheduler] Strictly select impl using plevel

2020-11-23 Thread GitBox
comaniac merged pull request #6956: URL: https://github.com/apache/incubator-tvm/pull/6956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] comaniac commented on pull request #6956: [Bugfix][AutoScheduler] Strictly select impl using plevel

2020-11-23 Thread GitBox
comaniac commented on pull request #6956: URL: https://github.com/apache/incubator-tvm/pull/6956#issuecomment-732542593 Thanks @merrymercy This is an automated message from the Apache Git Service. To respond to the message,

[incubator-tvm] branch main updated (4191ae5 -> 48f9135)

2020-11-23 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4191ae5 [PatternLang] Remove unnecessary check (#6958) add 48f9135 [Bugfix][AutoScheduler] Strictly

[GitHub] [incubator-tvm] alter-xp commented on a change in pull request #6949: [TF frontend] add support for StridedSlice to input a single constant

2020-11-23 Thread GitBox
alter-xp commented on a change in pull request #6949: URL: https://github.com/apache/incubator-tvm/pull/6949#discussion_r529162488 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1599,6 +1599,9 @@ def _impl(inputs, attr, params, mod): data_shape =

[GitHub] [incubator-tvm] merrymercy merged pull request #6945: [AutoScheduler] Task scheduler callbacks

2020-11-23 Thread GitBox
merrymercy merged pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >