[GitHub] [tvm] manupa-arm commented on a change in pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
manupa-arm commented on a change in pull request #7266: URL: https://github.com/apache/tvm/pull/7266#discussion_r561233084 ## File path: src/runtime/crt/host/main.cc ## @@ -93,6 +94,20 @@ tvm_crt_error_t TVMPlatformTimerStop(double* elapsed_time_seconds) {

[GitHub] [tvm] manupa-arm commented on a change in pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
manupa-arm commented on a change in pull request #7266: URL: https://github.com/apache/tvm/pull/7266#discussion_r561233084 ## File path: src/runtime/crt/host/main.cc ## @@ -93,6 +94,20 @@ tvm_crt_error_t TVMPlatformTimerStop(double* elapsed_time_seconds) {

[GitHub] [tvm] jchia opened a new pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia opened a new pull request #7320: URL: https://github.com/apache/tvm/pull/7320 IsNan was added to tensorflow.rst in fa1b859f but this commit makes IsNan actually work This is an automated message from the Apache

[GitHub] [tvm] t-vi commented on pull request #7231: Adding aten::unsqueeze_ to PT Frontend

2021-01-21 Thread GitBox
t-vi commented on pull request #7231: URL: https://github.com/apache/tvm/pull/7231#issuecomment-764527672 To keep things transparent, I'm copying a terse bit of explanation from slack: To see what goes wrong and why the test doesn't catch it, compare the graph for traced and

[GitHub] [tvm] manupa-arm commented on a change in pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
manupa-arm commented on a change in pull request #7266: URL: https://github.com/apache/tvm/pull/7266#discussion_r561233084 ## File path: src/runtime/crt/host/main.cc ## @@ -93,6 +94,20 @@ tvm_crt_error_t TVMPlatformTimerStop(double* elapsed_time_seconds) {

[tvm] branch main updated (f829403 -> 20e03bc)

2021-01-21 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from f829403 [TOPI] Rewrite GPU argwhere using exclusive scan (#7314) add 20e03bc [COMMUNITY] @jwfromm -> Committer

[GitHub] [tvm] masahi merged pull request #7316: [COMMUNITY] @jwfromm -> Committer

2021-01-21 Thread GitBox
masahi merged pull request #7316: URL: https://github.com/apache/tvm/pull/7316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia edited a comment on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518 > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? I'm not familiar with the code base, but I think the test

[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
leandron commented on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764707942 > > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? > > I'm not familiar with the code base, but I think the

[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia edited a comment on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518 > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? I'm not familiar with the code base, but I think the test

[GitHub] [tvm] jchia commented on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia commented on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518 > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? I'm not familiar with the code base. Where can I add this test? I

[tvm] branch main updated: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator. (#7266)

2021-01-21 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 8524b28 [µTVM] Add TVMPlatformGenerateRandom, a

[GitHub] [tvm] tqchen merged pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
tqchen merged pull request #7266: URL: https://github.com/apache/tvm/pull/7266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
leandron commented on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764674422 Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? This

[GitHub] [tvm] hzfan opened a new pull request #7321: [TE] stable gradient

2021-01-21 Thread GitBox
hzfan opened a new pull request #7321: URL: https://github.com/apache/tvm/pull/7321 `te.gradient` may generate different (but equivalent) backward compute for a single forward, which may result in Ansor miss. This pr makes sure `te.gradient` always generates the same backward. cc

[GitHub] [tvm] tkonolige commented on a change in pull request #7287: [PRNG] Add check to PRNG to make sure that unsigned integer arithmetic is wrapping

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7287: URL: https://github.com/apache/tvm/pull/7287#discussion_r562038095 ## File path: python/tvm/topi/random/kernel.py ## @@ -234,6 +242,18 @@ def gen_ir(gen_ptr, out_gen_ptr, out_array_ptr): out_gen =

[GitHub] [tvm] SebastianBoblestETAS opened a new issue #7322: [BUG] tvmc runner: print_top sorts output causing sorted output to be stored.

2021-01-21 Thread GitBox
SebastianBoblestETAS opened a new issue #7322: URL: https://github.com/apache/tvm/issues/7322 The options print_top and outputs are currently incompatible, get_top_results should work on a copy of outputs. Otherwise sorted outputs are stored in .npz

[GitHub] [tvm] tkonolige commented on a change in pull request #7308: [FIX] Infer input shape in sparse_dense_padded's alter_op if one does not exist

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7308: URL: https://github.com/apache/tvm/pull/7308#discussion_r562019758 ## File path: python/tvm/topi/cuda/sparse.py ## @@ -295,7 +295,14 @@ def is_valid_for_sparse_dense_padded(data, weight_data): """ #

[GitHub] [tvm] comaniac commented on issue #7322: [BUG] tvmc runner: print_top sorts output causing sorted output to be stored.

2021-01-21 Thread GitBox
comaniac commented on issue #7322: URL: https://github.com/apache/tvm/issues/7322#issuecomment-764806994 Thanks for pointing out. Would you send a PR to fix it? Also cc @leandron This is an automated message from the

[tvm] branch main updated: add a shape function and dynamic test for round (#7324)

2021-01-21 Thread jwfromm
This is an automated email from the ASF dual-hosted git repository. jwfromm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 17ae44d add a shape function and dynamic test for

[GitHub] [tvm] jwfromm merged pull request #7324: Add a shape function and dynamic test for round

2021-01-21 Thread GitBox
jwfromm merged pull request #7324: URL: https://github.com/apache/tvm/pull/7324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] slyubomirsky commented on pull request #7323: [Relay][Training] Add more gradients

2021-01-21 Thread GitBox
slyubomirsky commented on pull request #7323: URL: https://github.com/apache/tvm/pull/7323#issuecomment-765089486 I've also been bitten by `TupleWrapper`s lol, maybe it shouldn't be the default, since it's only intended as a convenience when working with the Python APIs.

[GitHub] [tvm] comaniac commented on a change in pull request #7313: [AutoSchedule] Sparse dense tuning support with custom sketch rule

2021-01-21 Thread GitBox
comaniac commented on a change in pull request #7313: URL: https://github.com/apache/tvm/pull/7313#discussion_r561459545 ## File path: tutorials/auto_scheduler/tune_sparse_x86.py ## @@ -0,0 +1,331 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] tqchen commented on a change in pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
tqchen commented on a change in pull request #7152: URL: https://github.com/apache/tvm/pull/7152#discussion_r562270981 ## File path: include/tvm/runtime/packed_func.h ## @@ -1377,7 +1449,7 @@ inline TObjectRef TVMPODValue_::AsObjectRef() const { using ContainerType =

[GitHub] [tvm] liangfu commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library

2021-01-21 Thread GitBox
liangfu commented on a change in pull request #7286: URL: https://github.com/apache/tvm/pull/7286#discussion_r562358753 ## File path: tests/python/contrib/test_verilator/infrastructure.py ## @@ -66,10 +68,43 @@ def offload(mod): return mod +def verilator_app_path():

[GitHub] [tvm] vegaluisjose commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library

2021-01-21 Thread GitBox
vegaluisjose commented on a change in pull request #7286: URL: https://github.com/apache/tvm/pull/7286#discussion_r562375277 ## File path: tests/python/contrib/test_verilator/infrastructure.py ## @@ -66,10 +68,43 @@ def offload(mod): return mod +def

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] masahi merged pull request #7325: [TEST] Relax tolerance for dlpack <-> pytorch test

2021-01-21 Thread GitBox
masahi merged pull request #7325: URL: https://github.com/apache/tvm/pull/7325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] tmoreau89 opened a new pull request #7326: [Tutorial] Autoscheduler on ARM devices

2021-01-21 Thread GitBox
tmoreau89 opened a new pull request #7326: URL: https://github.com/apache/tvm/pull/7326 This tutorial adapts the x86 autoscheduler tutorial to work over RPC and target aarch64-based Rapsberry Pi. This is an automated

[GitHub] [tvm] tmoreau89 merged pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
tmoreau89 merged pull request #7295: URL: https://github.com/apache/tvm/pull/7295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] comaniac commented on a change in pull request #7321: [TE] stable gradient

2021-01-21 Thread GitBox
comaniac commented on a change in pull request #7321: URL: https://github.com/apache/tvm/pull/7321#discussion_r562115763 ## File path: tests/python/unittest/test_te_autodiff.py ## @@ -343,7 +343,23 @@ def test_reduction_init(): check_grad(B, A0) +def test_stable(): +

[GitHub] [tvm] tkonolige commented on a change in pull request #7308: [FIX] Infer input shape in sparse_dense_padded's alter_op if one does not exist

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7308: URL: https://github.com/apache/tvm/pull/7308#discussion_r562019758 ## File path: python/tvm/topi/cuda/sparse.py ## @@ -295,7 +295,14 @@ def is_valid_for_sparse_dense_padded(data, weight_data): """ #

[GitHub] [tvm] icemelon9 commented on a change in pull request #7316: [COMMUNITY] @jwfromm -> Committer

2021-01-21 Thread GitBox
icemelon9 commented on a change in pull request #7316: URL: https://github.com/apache/tvm/pull/7316#discussion_r561357994 ## File path: CONTRIBUTORS.md ## @@ -47,6 +47,7 @@ We do encourage everyone to work anything they are interested in. - [Wei

[GitHub] [tvm] codeislife99 commented on pull request #7231: Adding aten::unsqueeze_ to PT Frontend

2021-01-21 Thread GitBox
codeislife99 commented on pull request #7231: URL: https://github.com/apache/tvm/pull/7231#issuecomment-764424330 ``` class Unsqueeze3(Module): def forward(self, *args): _ = args[0].unsqueeze_(2) y = args[0] * 2 return y ```

[GitHub] [tvm] altanh commented on pull request #7323: [Relay][Training] Add more gradients

2021-01-21 Thread GitBox
altanh commented on pull request #7323: URL: https://github.com/apache/tvm/pull/7323#issuecomment-765102893 > I've also been bitten by `TupleWrapper`s lol, maybe it shouldn't be the default, since it's only intended as a convenience when working with the Python APIs. Indeed, it

[GitHub] [tvm] icemelon9 merged pull request #7311: [COMMUNITY] @tkonolige -> Reviewer

2021-01-21 Thread GitBox
icemelon9 merged pull request #7311: URL: https://github.com/apache/tvm/pull/7311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] tkonolige commented on a change in pull request #7267: [Frontend][Tensorflow] Sparse dense matmul adjoint option added

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7267: URL: https://github.com/apache/tvm/pull/7267#discussion_r562220135 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -942,7 +942,10 @@ def _impl(inputs, attr, params, mod): ) if sparse_lhs: -

[GitHub] [tvm] liangfu commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library

2021-01-21 Thread GitBox
liangfu commented on a change in pull request #7286: URL: https://github.com/apache/tvm/pull/7286#discussion_r562358753 ## File path: tests/python/contrib/test_verilator/infrastructure.py ## @@ -66,10 +68,43 @@ def offload(mod): return mod +def verilator_app_path():

[GitHub] [tvm] masahi merged pull request #7325: [TEST] Relax tolerance for dlpack <-> pytorch test

2021-01-21 Thread GitBox
masahi merged pull request #7325: URL: https://github.com/apache/tvm/pull/7325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: relax tolerance for dlpack test (#7325)

2021-01-21 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 790344c relax tolerance for dlpack test (#7325)

[GitHub] [tvm] masahi closed issue #7312: [FLAKY] test_dlpack.py

2021-01-21 Thread GitBox
masahi closed issue #7312: URL: https://github.com/apache/tvm/issues/7312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] altanh commented on pull request #7323: [Relay][Training] Add more gradients

2021-01-21 Thread GitBox
altanh commented on pull request #7323: URL: https://github.com/apache/tvm/pull/7323#issuecomment-765102893 > I've also been bitten by `TupleWrapper`s lol, maybe it shouldn't be the default, since it's only intended as a convenience when working with the Python APIs. Indeed, it

[GitHub] [tvm] t-vi commented on pull request #7231: Adding aten::unsqueeze_ to PT Frontend

2021-01-21 Thread GitBox
t-vi commented on pull request #7231: URL: https://github.com/apache/tvm/pull/7231#issuecomment-764446329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] ZihengJiang commented on a change in pull request #6370: [TOPI] Add einsum operator

2021-01-21 Thread GitBox
ZihengJiang commented on a change in pull request #6370: URL: https://github.com/apache/tvm/pull/6370#discussion_r562280157 ## File path: python/tvm/topi/einsum.py ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [tvm] tkonolige commented on a change in pull request #7287: [PRNG] Add check to PRNG to make sure that unsigned integer arithmetic is wrapping

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7287: URL: https://github.com/apache/tvm/pull/7287#discussion_r562038095 ## File path: python/tvm/topi/random/kernel.py ## @@ -234,6 +242,18 @@ def gen_ir(gen_ptr, out_gen_ptr, out_array_ptr): out_gen =

[GitHub] [tvm] vegaluisjose commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library

2021-01-21 Thread GitBox
vegaluisjose commented on a change in pull request #7286: URL: https://github.com/apache/tvm/pull/7286#discussion_r562375277 ## File path: tests/python/contrib/test_verilator/infrastructure.py ## @@ -66,10 +68,43 @@ def offload(mod): return mod +def

[GitHub] [tvm] masahi closed issue #7312: [FLAKY] test_dlpack.py

2021-01-21 Thread GitBox
masahi closed issue #7312: URL: https://github.com/apache/tvm/issues/7312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] areusch commented on a change in pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
areusch commented on a change in pull request #7152: URL: https://github.com/apache/tvm/pull/7152#discussion_r56226 ## File path: include/tvm/runtime/packed_func.h ## @@ -1377,7 +1449,7 @@ inline TObjectRef TVMPODValue_::AsObjectRef() const { using ContainerType =

[GitHub] [tvm] tqchen merged pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
tqchen merged pull request #7266: URL: https://github.com/apache/tvm/pull/7266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] mbrookhart commented on pull request #7314: [TOPI] Rewrite GPU argwhere using exclusive scan

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7314: URL: https://github.com/apache/tvm/pull/7314#issuecomment-764001126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] tkonolige commented on a change in pull request #7267: [Frontend][Tensorflow] Sparse dense matmul adjoint option added

2021-01-21 Thread GitBox
tkonolige commented on a change in pull request #7267: URL: https://github.com/apache/tvm/pull/7267#discussion_r562220135 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -942,7 +942,10 @@ def _impl(inputs, attr, params, mod): ) if sparse_lhs: -

[GitHub] [tvm] tqchen commented on a change in pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
tqchen commented on a change in pull request #7152: URL: https://github.com/apache/tvm/pull/7152#discussion_r562270981 ## File path: include/tvm/runtime/packed_func.h ## @@ -1377,7 +1449,7 @@ inline TObjectRef TVMPODValue_::AsObjectRef() const { using ContainerType =

[GitHub] [tvm] tqchen commented on a change in pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
tqchen commented on a change in pull request #7152: URL: https://github.com/apache/tvm/pull/7152#discussion_r562281721 ## File path: include/tvm/runtime/packed_func.h ## @@ -229,13 +229,13 @@ class TypedPackedFunc { * \endcode * * \param typed_lambda typed lambda

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-765001735 Yes, my originally attempt failed a bunch prelude/adt tests because I didn't support that :) This is an

[GitHub] [tvm] ZihengJiang commented on a change in pull request #6370: [TOPI] Add einsum operator

2021-01-21 Thread GitBox
ZihengJiang commented on a change in pull request #6370: URL: https://github.com/apache/tvm/pull/6370#discussion_r562280157 ## File path: python/tvm/topi/einsum.py ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [tvm] tkonolige commented on pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
tkonolige commented on pull request #7152: URL: https://github.com/apache/tvm/pull/7152#issuecomment-764964882 @tqchen @areusch @junrushao1994 I think this PR is in a good state to merge. Could you review again? This is an

[GitHub] [tvm] areusch commented on a change in pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
areusch commented on a change in pull request #7152: URL: https://github.com/apache/tvm/pull/7152#discussion_r56226 ## File path: include/tvm/runtime/packed_func.h ## @@ -1377,7 +1449,7 @@ inline TObjectRef TVMPODValue_::AsObjectRef() const { using ContainerType =

[GitHub] [tvm] mbrookhart opened a new pull request #7324: Add a shape function and dynamic test for round

2021-01-21 Thread GitBox
mbrookhart opened a new pull request #7324: URL: https://github.com/apache/tvm/pull/7324 @jwfromm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665 @jroesch @tmoreau89 Hit a driver bug in a CI node last night than Tianqi fixed, otherwise this passed tests, I think it's ready for review while the rebase runs.

[GitHub] [tvm] masahi opened a new pull request #7325: [TEST] Relax tolerance for dlpack <-> pytorch test

2021-01-21 Thread GitBox
masahi opened a new pull request #7325: URL: https://github.com/apache/tvm/pull/7325 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7303/12/pipeline/ This is an automated message from the Apache Git Service.

[tvm] branch main updated (8524b28 -> fc9e264)

2021-01-21 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 8524b28 [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator. (#7266) add fc9e264

[GitHub] [tvm] tqchen merged pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
tqchen merged pull request #7320: URL: https://github.com/apache/tvm/pull/7320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: Fix an issue with dynamic functions overwritting call arg types (#7295)

2021-01-21 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 7b6a1a7 Fix an issue with dynamic functions

[GitHub] [tvm] tmoreau89 commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
tmoreau89 commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-765022117 Thank you @mbrookhart and @altanh the PR has been merged. This is an automated message from the Apache Git

[GitHub] [tvm] tmoreau89 merged pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
tmoreau89 merged pull request #7295: URL: https://github.com/apache/tvm/pull/7295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] t-vi edited a comment on pull request #7231: Adding aten::unsqueeze_ to PT Frontend

2021-01-21 Thread GitBox
t-vi edited a comment on pull request #7231: URL: https://github.com/apache/tvm/pull/7231#issuecomment-756764112 I don't want to ruin the party, but does `unsqueeze_` work as is? We would want to update future use of the input to refer to the output (same for any of the "simple"

[GitHub] [tvm] luyaor commented on issue #7262: [Bug] Error when compiling a ONNX model with Gemm operator

2021-01-21 Thread GitBox
luyaor commented on issue #7262: URL: https://github.com/apache/tvm/issues/7262#issuecomment-765198567 @jwfromm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] tqchen commented on issue #7319: GCC10: warning: catching polymorphic type 'struct dmlc::Error' by value

2021-01-21 Thread GitBox
tqchen commented on issue #7319: URL: https://github.com/apache/tvm/issues/7319#issuecomment-764896482 thanks @ggardet can you send a new PR ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] FrozenGene merged pull request #6998: [TFLite] Strided slice handling of shrink_axis_mask improved

2021-01-21 Thread GitBox
FrozenGene merged pull request #6998: URL: https://github.com/apache/tvm/pull/6998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] d-smirnov commented on pull request #7114: [TFLite] Added check for dynamic range quantization

2021-01-21 Thread GitBox
d-smirnov commented on pull request #7114: URL: https://github.com/apache/tvm/pull/7114#issuecomment-763957745 @FrozenGene please, take a look This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] masahi merged pull request #7316: [COMMUNITY] @jwfromm -> Committer

2021-01-21 Thread GitBox
masahi merged pull request #7316: URL: https://github.com/apache/tvm/pull/7316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia edited a comment on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] masahi commented on pull request #7316: [COMMUNITY] @jwfromm -> Committer

2021-01-21 Thread GitBox
masahi commented on pull request #7316: URL: https://github.com/apache/tvm/pull/7316#issuecomment-764154479 @icemelon9 please kick again This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] tkonolige commented on pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-21 Thread GitBox
tkonolige commented on pull request #7152: URL: https://github.com/apache/tvm/pull/7152#issuecomment-764964882 @tqchen @areusch @junrushao1994 I think this PR is in a good state to merge. Could you review again? This is an

[GitHub] [tvm] monklof commented on pull request #6898: add ShapeFunc for tanh

2021-01-21 Thread GitBox
monklof commented on pull request #6898: URL: https://github.com/apache/tvm/pull/6898#issuecomment-765199446 > @monklof any updates? Thanks in advance! updated, check the lastest commit This is an automated message

[GitHub] [tvm] slyubomirsky commented on pull request #7323: [Relay][Training] Add more gradients

2021-01-21 Thread GitBox
slyubomirsky commented on pull request #7323: URL: https://github.com/apache/tvm/pull/7323#issuecomment-765089486 I've also been bitten by `TupleWrapper`s lol, maybe it shouldn't be the default, since it's only intended as a convenience when working with the Python APIs.

[GitHub] [tvm] tqchen merged pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
tqchen merged pull request #7320: URL: https://github.com/apache/tvm/pull/7320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] jchia commented on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
jchia commented on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518 > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future? I'm not familiar with the code base. Where can I add this test? I

[GitHub] [tvm] masahi commented on pull request #7314: [TOPI] Rewrite GPU argwhere using exclusive scan

2021-01-21 Thread GitBox
masahi commented on pull request #7314: URL: https://github.com/apache/tvm/pull/7314#issuecomment-764009115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] manupa-arm commented on a change in pull request #7266: [µTVM] Add TVMPlatformGenerateRandom, a non-cryptographic random number generator.

2021-01-21 Thread GitBox
manupa-arm commented on a change in pull request #7266: URL: https://github.com/apache/tvm/pull/7266#discussion_r561233084 ## File path: src/runtime/crt/host/main.cc ## @@ -93,6 +94,20 @@ tvm_crt_error_t TVMPlatformTimerStop(double* elapsed_time_seconds) {

[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work

2021-01-21 Thread GitBox
leandron commented on pull request #7320: URL: https://github.com/apache/tvm/pull/7320#issuecomment-764674422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] comaniac commented on issue #7322: [BUG] tvmc runner: print_top sorts output causing sorted output to be stored.

2021-01-21 Thread GitBox
comaniac commented on issue #7322: URL: https://github.com/apache/tvm/issues/7322#issuecomment-764806994 Thanks for pointing out. Would you send a PR to fix it? Also cc @leandron This is an automated message from the

[GitHub] [tvm] tqchen commented on a change in pull request #7316: [COMMUNITY] @jwfromm -> Committer

2021-01-21 Thread GitBox
tqchen commented on a change in pull request #7316: URL: https://github.com/apache/tvm/pull/7316#discussion_r561346329 ## File path: CONTRIBUTORS.md ## @@ -47,6 +47,7 @@ We do encourage everyone to work anything they are interested in. - [Wei Chen](https://github.com/wweic):

[GitHub] [tvm] monklof commented on a change in pull request #6898: add ShapeFunc for tanh

2021-01-21 Thread GitBox
monklof commented on a change in pull request #6898: URL: https://github.com/apache/tvm/pull/6898#discussion_r562437313 ## File path: python/tvm/topi/cuda/dense.py ## @@ -77,8 +77,8 @@ def _callback(op): def _schedule_dense_small_batch(cfg, s, C): -A, _ =

[GitHub] [tvm] tmoreau89 commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
tmoreau89 commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-765022117 Thank you @mbrookhart and @altanh the PR has been merged. This is an automated message from the Apache Git

[GitHub] [tvm] masahi merged pull request #7314: [TOPI] Rewrite GPU argwhere using exclusive scan

2021-01-21 Thread GitBox
masahi merged pull request #7314: URL: https://github.com/apache/tvm/pull/7314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] luyaor commented on issue #7270: [Bug] Wrong result with model contains Flatten and Reduce

2021-01-21 Thread GitBox
luyaor commented on issue #7270: URL: https://github.com/apache/tvm/issues/7270#issuecomment-765198018 @jwfromm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] zhanghaohit commented on pull request #6126: [VTA][OpenCL] intelfocl

2021-01-21 Thread GitBox
zhanghaohit commented on pull request #6126: URL: https://github.com/apache/tvm/pull/6126#issuecomment-764175758 @tqchen seems CI is hang? Could you take a look at it? Thanks. This is an automated message from the Apache Git

[GitHub] [tvm] jwfromm merged pull request #7324: Add a shape function and dynamic test for round

2021-01-21 Thread GitBox
jwfromm merged pull request #7324: URL: https://github.com/apache/tvm/pull/7324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] tqchen commented on issue #7312: [FLAKY] test_dlpack.py

2021-01-21 Thread GitBox
tqchen commented on issue #7312: URL: https://github.com/apache/tvm/issues/7312#issuecomment-764898503 i see, @masahi can you send a PR to fix it? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] tqchen commented on issue #7319: GCC10: warning: catching polymorphic type 'struct dmlc::Error' by value

2021-01-21 Thread GitBox
tqchen commented on issue #7319: URL: https://github.com/apache/tvm/issues/7319#issuecomment-764896482 thanks @ggardet can you send a new PR ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] tqchen commented on issue #7312: [FLAKY] test_dlpack.py

2021-01-21 Thread GitBox
tqchen commented on issue #7312: URL: https://github.com/apache/tvm/issues/7312#issuecomment-764898503 i see, @masahi can you send a PR to fix it? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] comaniac commented on a change in pull request #7321: [TE] stable gradient

2021-01-21 Thread GitBox
comaniac commented on a change in pull request #7321: URL: https://github.com/apache/tvm/pull/7321#discussion_r562115763 ## File path: tests/python/unittest/test_te_autodiff.py ## @@ -343,7 +343,23 @@ def test_reduction_init(): check_grad(B, A0) +def test_stable(): +

[GitHub] [tvm] altanh opened a new pull request #7323: [Relay][Training] Add more gradients

2021-01-21 Thread GitBox
altanh opened a new pull request #7323: URL: https://github.com/apache/tvm/pull/7323 Added gradients for: - `concatenate` - `reshape_like` - `where` - `less_equal` cc @antinucleon @MarisaKirisame Somewhat tangential: the behavior for `split` in Python Relay is