[GitHub] [incubator-weex] weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex
weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 335addd3ac0120842a67dd896abab9b70374f264 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex
weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 5f2212512fc6911055fa3844736d265bec0ff4a8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex
weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 0cac4c34a0d890c5a6ab44e32ba778ee4d660fe9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex
weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 89ec540930e64d6e0ec9655cb1b68c7f347b7d14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex
weex-bot edited a comment on issue #2940: * [Android] Remove shared library from binary of Weex URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 1bc106e8d9eac5c3f5bffdf81e7e0cd4d8b4c28e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
