Hadoop coding style guideline

2009-11-20 Thread Cosmin Lehene
Hi, I was trying to make a patch and looking over the Hadoop guidelines for code at http://wiki.apache.org/hadoop/CodeReviewChecklist, trying to follow the conventions. Looking through code I found a few patterns, however, these differ even in the same class sometimes. Here's a collection of

Re: Hadoop coding style guideline

2009-11-20 Thread Konstantin Boudnik
So, IMO, the goal should be the examples on 10-24 or 31-36. +1 I agree with Todd: the highlighted snippets are most appropriate as Java coding style. On 11/20/09 10:54 , Todd Lipcon wrote: My opinions on the groups of line numbers from that pastebin: 1-3: Definitely not - no reason for )