Re: Have we shipped Hadoop 2.5.2

2014-11-22 Thread Steve Loughran
OK, it's made the way over to the UK now. On 21 November 2014 at 17:45, Karthik Kambatla ka...@cloudera.com wrote: I announced the release yesterday on general@. To limit the visibility of the vulnerability, the vote was done on security@ instead of dev lists. To post the bits, I pushed them

Re: a friendly suggestion for developers when uploading patches

2014-11-22 Thread Steve Loughran
can we do HADOOP--001.patch with the 001 being the revision. -That numbering scheme guarantees listing order in directories c -having .patch come after ensures that those people who have .patch bound in their browser to a text editor (e.g. textmate) can view the patch with ease I know

Re: a friendly suggestion for developers when uploading patches

2014-11-22 Thread Ted Yu
For patch viewing, David Deng has a Chrome extension for rendering patch on JIRA. See this thread: http://search-hadoop.com/m/DHED4LHEYI FYI On Sat, Nov 22, 2014 at 10:24 AM, Steve Loughran ste...@hortonworks.com wrote: can we do HADOOP--001.patch with the 001 being the revision. -That

Re: a friendly suggestion for developers when uploading patches

2014-11-22 Thread Yongjun Zhang
Hi Steve, Thanks for the good suggestion. I like the idea to have even a more specific guideline for patch file naming, and I agree using 3-digit is a good choice here: *projectName*-*jiraNum*-*revNum*.patch where revNum is 3-digit, in the format of 001, 002, ..., 010, 011, ... Thanks.

Re: a friendly suggestion for developers when uploading patches

2014-11-22 Thread Yongjun Zhang
Hi Ted, Thanks for sharing, this is a good tool to view the patch. For those who haven't tried: once you install it, then when you mouse-click on an uploaded patch in Chrome, Chrome will render the patch as if you are diffing the patch against the base side by side, with left side showing the