On Mon, Sep 12, 2011 at 9:33 AM, Eric Payne wrote:
> So, if a patch is the same for trunk plus one or more branches, would we need
> to upload multiple patches?
>
Correct. In my experience its been very rare that one patch applies
to trunk and a stable branch, and trunk to a feature branch is
n
osen branch/tag. Besides, a cp shouldn't be that
hard, and with sorting on, they arrange nicely on JIRA as well :-)
> -Original Message-
> From: Eli Collins [mailto:e...@cloudera.com]
> Sent: Friday, September 09, 2011 1:11 PM
> To: common-dev@hadoop.apache.org
> Subject:
So, if a patch is the same for trunk plus one or more branches, would we need
to upload multiple patches?
Thanks,
-Eric Payne
-Original Message-
From: Eli Collins [mailto:e...@cloudera.com]
Sent: Friday, September 09, 2011 1:11 PM
To: common-dev@hadoop.apache.org
Subject: Re: JIRA
he.org]
Sent: Friday, September 09, 2011 10:48 AM
To: common-dev@hadoop.apache.org
Subject: Re: JIRA attachments order
On 09/09/2011 07:27 AM, Ted Dunning wrote:
> If you post the same patch with the same name, JIRA helps you out by greying
> all the earlier versions out.
Indeed. That's
On 09/10/2011 01:32 AM, Vinod Kumar Vavilapalli wrote:
> Regarding patch names, I too agree with Allen that extension should be .txt.
> I do run into patches every now and then which aren't interpreted as text
> files, so there are people out there using browsers that don't properly set
> the conte
Alas, my original request about changing the default sort order to be by
date doesn't seem to be satisfiable as Doug mentioned. I also searched
around on Atlassian forums and JIRA tracker for the JIRA project itself,
seems like an issue that isn't fixed yet.
Regarding patch names, I too agree with
I updated HowToContribute, it people like this prose I'll advertise
the change to *-dev.
Thanks,
Eli
On Fri, Sep 9, 2011 at 2:53 PM, Eli Collins wrote:
> On Fri, Sep 9, 2011 at 1:15 PM, Aaron T. Myers wrote:
>> On Fri, Sep 9, 2011 at 12:57 PM, Eli Collins wrote:
>>
>>> Patches for a specific b
On Fri, Sep 9, 2011 at 1:15 PM, Aaron T. Myers wrote:
> On Fri, Sep 9, 2011 at 12:57 PM, Eli Collins wrote:
>
>> Patches for a specific branch should be named: jira-xyz-branch.patch
>> where "branch" may be abbreviated, eg hdfs-123-security.patch
>>
>
> +1, if we ever hope to implement HADOOP-74
Review board already works. Hbase uses it extensively.
On Fri, Sep 9, 2011 at 2:15 PM, Kirby Bohling wrote:
> On Fri, Sep 9, 2011 at 4:04 PM, Doug Cutting wrote:
> > On 09/09/2011 01:38 PM, Kirby Bohling wrote:
> >> Someday I wish Apache would find/adopt a distributed version control
> >> syste
On 09/09/2011 02:15 PM, Kirby Bohling wrote:
> Fair enough Doug. Somebody else will have to do that, I don't have
> commit access (a pre-requisite for access to the private lists). I'd
> make the suggestion there, but I literally can't.
Such suggestions have been made before. What's lacking are
On Fri, Sep 9, 2011 at 4:04 PM, Doug Cutting wrote:
> On 09/09/2011 01:38 PM, Kirby Bohling wrote:
>> Someday I wish Apache would find/adopt a distributed version control
>> system (I know about git.apache.org, but I mean pushing that further),
>> and use something like gerrit or review board. So
On 09/09/2011 01:38 PM, Kirby Bohling wrote:
> Someday I wish Apache would find/adopt a distributed version control
> system (I know about git.apache.org, but I mean pushing that further),
> and use something like gerrit or review board. So if you have a
> patch, or a series of patches, you'd just
On Fri, Sep 9, 2011 at 3:15 PM, Aaron T. Myers wrote:
> On Fri, Sep 9, 2011 at 12:57 PM, Eli Collins wrote:
>
>> Patches for a specific branch should be named: jira-xyz-branch.patch
>> where "branch" may be abbreviated, eg hdfs-123-security.patch
>>
>
> +1, if we ever hope to implement HADOOP-74
On Fri, Sep 9, 2011 at 12:57 PM, Eli Collins wrote:
> Patches for a specific branch should be named: jira-xyz-branch.patch
> where "branch" may be abbreviated, eg hdfs-123-security.patch
>
+1, if we ever hope to implement HADOOP-7435 [1], it will be necessary to
standardize the branch-name-in-p
On 09/09/2011 01:08 PM, Allen Wittenauer wrote:
> s,patch,txt, since jira doesn't appear to pass a content-type to indicate it
> is readable by the browser (as you mentioned earlier).
I think Jira uses the content-type that the browser posts with. My
browser (Chrome on Ubuntu) posts .patch files
On Sep 9, 2011, at 12:57 PM, Eli Collins wrote:
>
> Patches for trunk should be named: jira-xyz.patch
> eg hdfs-123.patch
s,patch,txt, since jira doesn't appear to pass a content-type to indicate it is
readable by the browser (as you mentioned earlier).
On Fri, Sep 9, 2011 at 12:52 PM, Doug Cutting wrote:
> On 09/09/2011 11:12 AM, Eli Collins wrote:
>> Personally I like version numbers as well, it allows me to refer to a
>> specific version of the patch (vs a patch on a given time of
>> date/date).
>
> Re-using the name doesn't hide the old vers
On 09/09/2011 11:12 AM, Eli Collins wrote:
> Personally I like version numbers as well, it allows me to refer to a
> specific version of the patch (vs a patch on a given time of
> date/date).
Re-using the name doesn't hide the old versions, it just makes them
gray. They're still listed, with dat
Agreed. Furthermore, if I have 10+ versions of a patch, when getting
feedback knowing for with version would be handy, having a single name makes
this correlation difficult.
Thxs.
Alejandro
[PS: I know, I should code better not have to go thru several versions]
On Fri, Sep 9, 2011 at 11:08 AM,
On Fri, Sep 9, 2011 at 11:38 PM, Ravi Prakash wrote:
> But what if I want to see an incremental diff between two patches? I don't
> want to review the whole patch everytime. Maybe I just want to re-review the
> changes made to a patch. I would then have sort the patches manually using
> time. I th
Personally I like version numbers as well, it allows me to refer to a
specific version of the patch (vs a patch on a given time of
date/date).
I also notice some people use .txt which browsers can view in place vs
.patch which will download by default unless you register a viewer.
Thanks,
Eli
O
How about we the how to contribute page with a simple standard?
jira-xyz.patch # for trunk
jira-xyz-branch.patch # for a release branch, could use a shortened
name, eg "20x" for branch-20-security and "append" for
branch-20-append.
Thanks,
Eli
On Fri, Sep 9, 2011 at 10:32 AM, Robert Evans wro
But what if I want to see an incremental diff between two patches? I don't
want to review the whole patch everytime. Maybe I just want to re-review the
changes made to a patch. I would then have sort the patches manually using
time. I think its better to have version numbers in that case
On Fri,
Can I ask, though that we do add branch information in the patches. Too often
a patch is intended to apply to some branch other then trunk, and there is no
easy way to tell what branch it was intended for.
--Bobby Evans
On 9/9/11 10:52 AM, "Mattmann, Chris A (388J)"
wrote:
Wow, I didn't kn
Wow, I didn't know that!
Learn something new everyday, thanks guys.
Cheers,
Chris
On Sep 9, 2011, at 9:48 AM, Doug Cutting wrote:
> On 09/09/2011 07:27 AM, Ted Dunning wrote:
>> If you post the same patch with the same name, JIRA helps you out by greying
>> all the earlier versions out.
>
> In
On 09/09/2011 07:27 AM, Ted Dunning wrote:
> If you post the same patch with the same name, JIRA helps you out by greying
> all the earlier versions out.
Indeed. That's the best practice, not to add version numbers to patch
files, for this very reason. We should perhaps note this on:
http://wik
If you post the same patch with the same name, JIRA helps you out by greying
all the earlier versions out.
On Fri, Sep 9, 2011 at 7:03 AM, John George wrote:
> +1. Changing default to 'sorted by date' helps.
>
> John Vijoe George Edackattukudy
>
> On Sep 9, 2011, at 9:01 AM, "Uma Maheswara Rao G
+1. Changing default to 'sorted by date' helps.
John Vijoe George Edackattukudy
On Sep 9, 2011, at 9:01 AM, "Uma Maheswara Rao G 72686"
wrote:
>
> +1, that is nice point.
>
> Thanks,
> Uma
> - Original Message -
> From: Vinod Kumar Vavilapalli
> Date: Friday, September 9, 2011 3:09
+1, that is nice point.
Thanks,
Uma
- Original Message -
From: Vinod Kumar Vavilapalli
Date: Friday, September 9, 2011 3:09 pm
Subject: JIRA attachments order
To: common-dev@hadoop.apache.org
> Can someone with JIRA admin privileges see if the default sorting
> order for
> attachments
+1. In addition, I've found easier for identifying the right patch to use a
version suffix, like HADOOP-1234v2.patch. Maybe we should recommend
something like that as a naming convention in the HowToContribute
On Fri, Sep 9, 2011 at 2:38 AM, Vinod Kumar Vavilapalli <
vino...@hortonworks.com> wrote
30 matches
Mail list logo
