---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/
---
(Updated 2011-06-16 12:13:34.081758)
Review request for hadoop-common and Todd Li
ue to the libs missing from the actual jvm that executes the job?
>
> Sudhan S
>
> -Original Message-
> From: Harsh J [mailto:ha...@cloudera.com]
> Sent: Tuesday, June 14, 2011 12:42 AM
> To: Todd Lipcon
> Cc: hadoop-common; Harsh J; Matt Foley
> Subject: Re: Revi
to:ha...@cloudera.com]
Sent: Tuesday, June 14, 2011 12:42 AM
To: Todd Lipcon
Cc: hadoop-common; Harsh J; Matt Foley
Subject: Re: Review Request: HADOOP-7328. Improve the SerializationFactory
functions.
> On 2011-06-13 18:23:35, Matt Foley wrote:
> > Sorry if this is out of context, but is
> On 2011-06-13 18:23:35, Matt Foley wrote:
> > Sorry if this is out of context, but is it really best to also return a
> > null here? Shouldn't it check for null result from getSerialization(),
> > then throw a (non-NPE) exception? Or do you prefer to do that check and
> > throw at a higher
> On 2011-06-13 18:23:35, Matt Foley wrote:
> > Sorry if this is out of context, but is it really best to also return a
> > null here? Shouldn't it check for null result from getSerialization(),
> > then throw a (non-NPE) exception? Or do you prefer to do that check and
> > throw at a higher
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/#review817
---
Sorry if this is out of context, but is it really best to also return a
> On 2011-06-12 02:24:55, Todd Lipcon wrote:
> > Looks good to me. Can you upload this rev of the patch to the JIRA so the
> > QA Bot runs on it?
Submitted on JIRA. Thanks for the review Todd!
- Harsh
---
This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/#review805
---
Ship it!
Looks good to me. Can you upload this rev of the patch to the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/
---
Review request for hadoop-common and Todd Lipcon.
Summary
---
Since getSeria
