Re: Solaris Port SOLVED!

2014-12-16 Thread malcolm
the call to strerror(). Please check the code snippet I sent earlier for HPUX. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Saturday, December 13, 2014 3:13 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port SOLVED! Wiping egg off

Re: Solaris Port SOLVED!

2014-12-16 Thread Charles Lamb
On 12/16/2014 11:01 AM, malcolm wrote: This is weird, Jenkins complains about: 1. Findbugs , 3 warnings in Java code (which of course I did not touch) The FB warnings seem to be a recent phenomenon. I have seen them on a recent test run of my own and they come and go depending on the run. I

Re: Solaris Port SOLVED!

2014-12-16 Thread Steve Loughran
On 16 December 2014 at 16:01, malcolm malcolm.kaval...@oracle.com wrote: 1. Findbugs , 3 warnings in Java code (which of course I did not touch) 2. Test failures also with no connection to terror: A java socket timeout, ongoing issues with (1) transition to java 7 builds and (2) some

Re: Solaris Port

2014-12-15 Thread Steve Loughran
On 14 December 2014 at 16:52, Allen Wittenauer a...@altiscale.com wrote: Well, slight correction: only one thing in the code that has been replaced. There are a two patches waiting to get reviewed and applied that fix the rest of the shipping shell code: HADOOP-10788 and HADOOP-11346.

Re: Solaris Port SOLVED!

2014-12-15 Thread Colin McCabe
sent earlier for HPUX. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Saturday, December 13, 2014 3:13 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port SOLVED! Wiping egg off face ... After consulting with the Solaris

Re: Solaris Port SOLVED!

2014-12-15 Thread malcolm
for HPUX. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Saturday, December 13, 2014 3:13 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port SOLVED! Wiping egg off face ... After consulting with the Solaris team (and looking

Re: Solaris Port

2014-12-14 Thread Allen Wittenauer
On Dec 13, 2014, at 4:05 AM, Steve Loughran ste...@hortonworks.com wrote: The shell scripts are also undertested and only intermittently maintained —there's been recent work there in HADOOP-9902(?) which is a great improvement to trunk. If you can help test the CLI on your OS, that will

Re: Solaris Port

2014-12-14 Thread Allen Wittenauer
On Dec 14, 2014, at 8:38 AM, Allen Wittenauer a...@altiscale.com wrote: On Dec 13, 2014, at 4:05 AM, Steve Loughran ste...@hortonworks.com wrote: The shell scripts are also undertested and only intermittently maintained —there's been recent work there in HADOOP-9902(?) which is a great

Re: Solaris Port

2014-12-13 Thread malcolm
, December 11, 2014 4:04 PM To:common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror, and strerror_s (which is the strerror_r equivalent). Is there a reason why you didn't use this call ? On 12/11/2014 06:27 PM, Asokan, M wrote: Hi Malcom

Re: Solaris Port

2014-12-13 Thread Asokan, M
@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror, and strerror_s (which is the strerror_r equivalent). Is there a reason why you didn't use this call ? On 12/11/2014 06:27 PM, Asokan, M wrote: Hi Malcom, Recently, I had to work on a function

Re: Solaris Port

2014-12-13 Thread malcolm
From: malcolm [malcolm.kaval...@oracle.commailto:malcolm.kaval...@oracle.com] Sent: Thursday, December 11, 2014 4:04 PM To:common-dev@hadoop.apache.orgmailto:To:common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror

Re: Solaris Port

2014-12-13 Thread Steve Loughran
On 13 December 2014 at 09:29, malcolm malcolm.kaval...@oracle.com wrote: I am not sure what you mean by a thread-local buffer (in native code). In Java this is pretty standard, but I couldn't find any implementation for C code. There's stuff around; I don't know how well it works across

Re: Solaris Port SOLVED!

2014-12-13 Thread malcolm
[malcolm.kaval...@oracle.commailto:malcolm.kaval...@oracle.com] Sent: Thursday, December 11, 2014 4:04 PM To:common-dev@hadoop.apache.orgmailto:To:common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror, and strerror_s (which is the strerror_r

RE: Solaris Port SOLVED!

2014-12-13 Thread Asokan, M
earlier for HPUX. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Saturday, December 13, 2014 3:13 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port SOLVED! Wiping egg off face ... After consulting with the Solaris team (and looking

Re: Solaris Port SOLVED!

2014-12-13 Thread malcolm
sent earlier for HPUX. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Saturday, December 13, 2014 3:13 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port SOLVED! Wiping egg off face ... After consulting with the Solaris team

Re: Solaris Port

2014-12-12 Thread Colin McCabe
To: common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror, and strerror_s (which is the strerror_r equivalent). Is there a reason why you didn't use this call ? On 12/11/2014 06:27 PM, Asokan, M wrote: Hi Malcom, Recently, I

Re: Solaris Port

2014-12-11 Thread malcolm
FYI, there are a couple more files that reference sys_errlist directly (not just terror within exception.c) , but also hdfs_http_client.c and NativeiO.c On 12/11/2014 07:38 AM, malcolm wrote: Hi Colin, Exactly, as you noticed, the problem is the thread-local buffer needed to return from

Re: Solaris Port

2014-12-11 Thread Allen Wittenauer
sys_errlist was removed for a reason. Creating a fake sys_errlist on Solaris will mean the libhadoop.so will need to be tied a specific build (kernel/include pairing) and therefore limits upward mobility/compatibility. That doesn’t seem like a very good idea. IMO, switching to strerror_r

Re: Solaris Port

2014-12-11 Thread malcolm
Fine with me, I volunteer to do this, if accepted. On 12/11/2014 05:48 PM, Allen Wittenauer wrote: sys_errlist was removed for a reason. Creating a fake sys_errlist on Solaris will mean the libhadoop.so will need to be tied a specific build (kernel/include pairing) and therefore limits

RE: Solaris Port

2014-12-11 Thread Asokan, M
a subtle difference in its interface. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Thursday, December 11, 2014 11:02 AM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port Fine with me, I volunteer to do this, if accepted. On 12/11/2014 05

Re: Solaris Port

2014-12-11 Thread malcolm
From: malcolm [malcolm.kaval...@oracle.com] Sent: Thursday, December 11, 2014 11:02 AM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port Fine with me, I volunteer to do this, if accepted. On 12/11/2014 05:48 PM, Allen Wittenauer wrote: sys_errlist

RE: Solaris Port

2014-12-11 Thread Asokan, M
was to return messages in current system locale. -- Asokan From: malcolm [malcolm.kaval...@oracle.com] Sent: Thursday, December 11, 2014 4:04 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror

Re: Solaris Port

2014-12-11 Thread malcolm
11, 2014 4:04 PM To: common-dev@hadoop.apache.org Subject: Re: Solaris Port Hi Asok, I googled and found that windows has strerror, and strerror_s (which is the strerror_r equivalent). Is there a reason why you didn't use this call ? On 12/11/2014 06:27 PM, Asokan, M wrote: Hi Malcom

Re: Solaris Port

2014-12-10 Thread Colin McCabe
Hi Malcolm, In general we file JIRAs for particular issues. So if one issue is handling errlist on Solaris, that might be one JIRA. Another issue might be handling socket write timeouts on Solaris. And so on. Most of these should probably be HADOOP tickets since they sound like they are

Re: Solaris Port

2014-12-10 Thread malcolm
Hi Colin, Thanks for the hints around JIRAs. You are correct errno still exists, however sys_errlist does not. Hadoop uses a function terror (defined in exception.c) which indexes sys_errlist by errno to return the error message from the array. This function is called 26 times in various

Re: Solaris Port

2014-12-10 Thread Steve Loughran
On 10 December 2014 at 10:31, malcolm malcolm.kaval...@oracle.com wrote: Also, I have been requested to ensure my port is available on 2.4, perceived as a more stable release. If I make changes to this branch are they automatically available for 2.6, or will I need multiple JIRAs ? nobody is

Re: Solaris Port

2014-12-10 Thread Colin McCabe
On Wed, Dec 10, 2014 at 2:31 AM, malcolm malcolm.kaval...@oracle.com wrote: Hi Colin, Thanks for the hints around JIRAs. You are correct errno still exists, however sys_errlist does not. Hadoop uses a function terror (defined in exception.c) which indexes sys_errlist by errno to return the

Solaris Port

2014-12-08 Thread malcolm
I have ported Hadoop native libraries to Solaris 11 (both Sparc and Intel ) Oracle have agreed to release my changes to the community so that Solaris platforms can benefit. Reading the HowToContribute and GitandHadoop documents, I am not 100% clear on how to get my changes into the main tree.

Re: Solaris Port

2014-12-08 Thread Colin McCabe
Hi Malcolm, It's great that you are going to contribute! Please make your patches against trunk. 2.2 is fairly old at this point. It hasn't been the focus of development in more than a year. We don't use github or pull requests. Check the section on

Re: Solaris Port

2014-12-08 Thread malcolm
Hi Colin, A short summary of my changes are as follows: - Native C source files: added 5, modified 6, requiring also changes to CMakeLists.txt. Of course, all changes are ifdeffed for Solaris appropriately and new files, are prefixed with solaris_ as well. For example, Solaris does not