Re: Status: hadoop-common precommit

2015-10-23 Thread Mingliang Liu
Thank you Allen for the detailed explanation, and thank you Haohui for moving the jira under HADOOP. Best, Mingliang Liu Member of Technical Staff - HDFS, Hortonworks Inc. m...@hortonworks.com > On Oct 23, 2015, at 7:34 AM, Allen Wittenauer wrote: > > > On Oct 23,

Re: Status: hadoop-common precommit

2015-10-23 Thread Allen Wittenauer
On Oct 23, 2015, at 7:17 AM, Allen Wittenauer wrote: > > On Oct 22, 2015, at 11:37 PM, Mingliang Liu wrote: > >> Thanks for your reply and investigation, Allen. >> >> Yes, the HDFS-Build/13119 did fail because of the git plugin was not able to >>

Re: Status: hadoop-common precommit

2015-10-23 Thread Allen Wittenauer
On Oct 22, 2015, at 11:37 PM, Mingliang Liu wrote: > Thanks for your reply and investigation, Allen. > > Yes, the HDFS-Build/13119 did fail because of the git plugin was not able to > clean workspace. > > The early build HDFS-Build/13114 and latest builds >

Re: Status: hadoop-common precommit

2015-10-23 Thread Mingliang Liu
Thanks for your reply and investigation, Allen. Yes, the HDFS-Build/13119 did fail because of the git plugin was not able to clean workspace. The early build HDFS-Build/13114 and latest builds (HDFS-Build/13134 and

Re: Status: hadoop-common precommit

2015-10-22 Thread Allen Wittenauer
On Oct 22, 2015, at 11:46 AM, Allen Wittenauer wrote: > > On Oct 22, 2015, at 11:35 AM, Mingliang Liu wrote: >> >> Yes it’s trunk’s test-patch. I’m able to compile the patch locally but >> Jenkins failed to build. As the latest patch did not trigger

Re: Status: hadoop-common precommit

2015-10-22 Thread Allen Wittenauer
On Oct 22, 2015, at 11:35 AM, Mingliang Liu wrote: > > Yes it’s trunk’s test-patch. I’m able to compile the patch locally but > Jenkins failed to build. As the latest patch did not trigger Jenkins again, I > don’t know whether Jenkins fails to build patches like this

Re: Status: hadoop-common precommit

2015-10-22 Thread Haohui Mai
bq. It’s an extremely rare event that this type of re-ordering occurs, so risk/reward favors risk. Unfortunately HDFS-9214 requires building hadoop-hdfs-client before building hadoop-hdfs, which leads to the failure. Same problem for HADOOP-12500 as it introduces a new module

Re: Status: hadoop-common precommit

2015-10-22 Thread Mingliang Liu
Mingliang Liu Member of Technical Staff - HDFS, Hortonworks Inc. m...@hortonworks.com > On Oct 21, 2015, at 5:11 PM, Allen Wittenauer wrote: > > > On Oct 21, 2015, at 4:57 PM, Haohui Mai wrote: > >> It seems like changes that involve multiple

Re: Status: hadoop-common precommit

2015-10-21 Thread Allen Wittenauer
On Oct 21, 2015, at 4:57 PM, Haohui Mai wrote: > It seems like changes that involve multiple modules are failing consistently. > >

Re: Status: hadoop-common precommit

2015-10-20 Thread Steve Loughran
> On 19 Oct 2015, at 19:09, Andrew Wang wrote: > > These tests should still be fixed up to use target/ instead of > build/test/data though. Steve, I'm happy to review if you're chasing these > down, or we could trade roles. I'm not going to look at it today, I've

Re: Status: hadoop-common precommit

2015-10-19 Thread Steve Loughran
> On 18 Oct 2015, at 16:59, Allen Wittenauer wrote: > > > An update: > > * Parallel tests for Hadoop have been turned on. I missed that > HDFS-9139 enabled them globally. > * The bug preventing Docker mode has been fixed and now enabled. Note > that this

Re: Status: hadoop-common precommit

2015-10-19 Thread Allen Wittenauer
On Oct 19, 2015, at 5:44 AM, Steve Loughran wrote: > > as noted there, we're not seeing find bugs reports Whoops, fixed. > > +whatever HDFS test has hard code buid/test/data path needs to be found and > fixed >

Re: Status: hadoop-common precommit

2015-10-19 Thread Steve Loughran
> On 19 Oct 2015, at 19:09, Andrew Wang wrote: > > Could we make it so we run RAT after building docs but before running > tests? I think that's what's causing these issues, it looks like temp > output from running tests. This would be a nice intermediate step toward >

Re: Status: hadoop-common precommit

2015-10-19 Thread Allen Wittenauer
On Oct 19, 2015, at 1:20 PM, Steve Loughran wrote: > I've ended up doing a more brutal change than just > s/"build/test/data"/r/"target/test/data"/, as there was a more fundamental > issue with temp directory setup. There are now some methods in > GenericTestUtils to

Re: Status: hadoop-common precommit

2015-10-19 Thread Andrew Wang
On Mon, Oct 19, 2015 at 12:39 PM, Allen Wittenauer wrote: > > On Oct 19, 2015, at 12:25 PM, Andrew Wang > wrote: > >> > > I do agree we should fix these usages of build/test/data, but I don't > > follow the logic regarding running RAT after tests.

Re: Status: hadoop-common precommit

2015-10-19 Thread Allen Wittenauer
On Oct 19, 2015, at 12:25 PM, Andrew Wang wrote: >> > I do agree we should fix these usages of build/test/data, but I don't > follow the logic regarding running RAT after tests. The point of the > precommit RAT check is to avoid introducing things to the source tarball

Re: Status: hadoop-common precommit

2015-10-19 Thread Andrew Wang
Could we make it so we run RAT after building docs but before running tests? I think that's what's causing these issues, it looks like temp output from running tests. This would be a nice intermediate step toward that plug-in you mentioned, since test output is certainly not part of the release

Re: Status: hadoop-common precommit

2015-10-19 Thread Andrew Wang
On Mon, Oct 19, 2015 at 11:24 AM, Allen Wittenauer wrote: > > On Oct 19, 2015, at 11:09 AM, Andrew Wang > wrote: > > > Could we make it so we run RAT after building docs but before running > > tests? I think that's what's causing these issues, it

Re: Status: hadoop-common precommit

2015-10-19 Thread Allen Wittenauer
On Oct 19, 2015, at 11:09 AM, Andrew Wang wrote: > Could we make it so we run RAT after building docs but before running > tests? I think that's what's causing these issues, it looks like temp > output from running tests. This would be a nice intermediate step toward >

Re: Status: hadoop-common precommit

2015-10-19 Thread Andrew Wang
On Mon, Oct 19, 2015 at 1:53 PM, Sean Busbey wrote: > Andrew / Allen, > > Could one of you file a YETUS ticket for a plugin that detects when > the source tree is changed as a result of running the build? That > sounds like a general error (for maven projects) that I'd like

Re: Status: hadoop-common precommit

2015-10-19 Thread Andrew Wang
Question, are these errors from running apache-rat:check after running tests? build/test/data looks like a carry-over from the ant days, where it was used instead of target/blah/blah. Point being, I thought we only needed to run RAT on a clean source directory. On Mon, Oct 19, 2015 at 9:17 AM,

Re: Status: hadoop-common precommit

2015-10-19 Thread Allen Wittenauer
On Oct 19, 2015, at 9:21 AM, Andrew Wang wrote: > Question, are these errors from running apache-rat:check after running > tests? build/test/data looks like a carry-over from the ant days, where it > was used instead of target/blah/blah. Point being, I thought we only

Re: Status: hadoop-common precommit

2015-10-18 Thread Allen Wittenauer
An update: * Parallel tests for Hadoop have been turned on. I missed that HDFS-9139 enabled them globally. * The bug preventing Docker mode has been fixed and now enabled. Note that this will likely hide broken tests that misuse ports... * We’re using Yetus’ default

Status: hadoop-common precommit

2015-10-17 Thread Allen Wittenauer
There is literally months worth of differences between the test-patch in trunk vs. what is in Apache Yetus. There are too many changes to list, but some highlights/most impactful for Hadoop: * The YETUS-83 branch is being downloaded from github prior to every run. This will