[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=583146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583146 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-820126450 Build#8 has timed-out after 20 hr and has these test failures recorded. Pasting screenshots here as the build data will be archived very soon.

[jira] [Work logged] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=583145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583145 ] ASF GitHub Bot logged work on HADOOP-17524: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2909: HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics

2021-04-14 Thread GitBox
virajjasani commented on pull request #2909: URL: https://github.com/apache/hadoop/pull/2909#issuecomment-820124354 Test failure has been taken care of in recent commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Work logged] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=583144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583144 ] ASF GitHub Bot logged work on HADOOP-17524: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2909: HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics

2021-04-14 Thread GitBox
virajjasani commented on pull request #2909: URL: https://github.com/apache/hadoop/pull/2909#issuecomment-820123401 @Apache9 @aajisaka Could you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] functioner commented on pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
functioner commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-820106508 @Hexiaoqiao thanks for the reminder. I've added: 1. comments for removing `logSyncNotifyExecutor.shutdown()` 2. configuration for the size of `logSyncNotifyExecutor`

[GitHub] [hadoop] Hexiaoqiao commented on pull request #2889: HDFS-15963. Unreleased volume references cause an infinite loop.

2021-04-14 Thread GitBox
Hexiaoqiao commented on pull request #2889: URL: https://github.com/apache/hadoop/pull/2889#issuecomment-820096203 Thanks @zhangshuyan0 for your great catch here. LGTM. +1 from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] Hexiaoqiao commented on pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
Hexiaoqiao commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-820080877 @functioner after review code, comment from Yiqun seems not resolved yet, do you mind to make thread pool size be configurable? -- This is an automated message from the

[GitHub] [hadoop] qizhu-lucas opened a new pull request #2911: YARN-10737: Fix typos in CapacityScheduler#schedule.

2021-04-14 Thread GitBox
qizhu-lucas opened a new pull request #2911: URL: https://github.com/apache/hadoop/pull/2911 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number.

[GitHub] [hadoop] ferhui merged pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-14 Thread GitBox
ferhui merged pull request #2902: URL: https://github.com/apache/hadoop/pull/2902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hadoop] cxorm commented on a change in pull request #2910: HDFS-15810. RBF: Use BigInteger for Router capacity metrics

2021-04-14 Thread GitBox
cxorm commented on a change in pull request #2910: URL: https://github.com/apache/hadoop/pull/2910#discussion_r613727691 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java ## @@ -371,13 +372,13 @@

[GitHub] [hadoop] ferhui commented on pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-14 Thread GitBox
ferhui commented on pull request #2902: URL: https://github.com/apache/hadoop/pull/2902#issuecomment-820025360 @jojochuang Thanks for this PR. @virajjasani Thanks for review! merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] hadoop-yetus commented on pull request #2910: HDFS-15810. RBF: Use BigInteger for Router capacity metrics

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2910: URL: https://github.com/apache/hadoop/pull/2910#issuecomment-820010002 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tomscut commented on pull request #2896: HDFS-15970. Print network topology on the web

2021-04-14 Thread GitBox
tomscut commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-819960710 Hi @tasanuma , could you please do another review? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] tomscut commented on pull request #2907: HDFS-15975. Use LongAdder instead of AtomicLong

2021-04-14 Thread GitBox
tomscut commented on pull request #2907: URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819959935 Those failed unit tests were unrelated to the change. And they work fine locally. Hi @goiri @tasanuma , could you please review the code? Thanks very much. -- This is

[GitHub] [hadoop] fengnanli opened a new pull request #2910: HDFS-15810 RBF: Use BigInteger for Router capacity metrics

2021-04-14 Thread GitBox
fengnanli opened a new pull request #2910: URL: https://github.com/apache/hadoop/pull/2910 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hadoop] hadoop-yetus commented on pull request #2907: HDFS-15975. Use LongAdder instead of AtomicLong

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2907: URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819897893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819872752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819811557 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=582862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582862 ] ASF GitHub Bot logged work on HADOOP-17524: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2909: HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2909: URL: https://github.com/apache/hadoop/pull/2909#issuecomment-819810914 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Assigned] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2021-04-14 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein reassigned HADOOP-16206: -- Assignee: Duo Zhang > Migrate from Log4j1 to Log4j2 > -

[GitHub] [hadoop] jbrennan333 merged pull request #2899: YARN-10733. TimelineService Hbase tests failing with timeouts

2021-04-14 Thread GitBox
jbrennan333 merged pull request #2899: URL: https://github.com/apache/hadoop/pull/2899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2908: HDFS-15976. Make mkdtemp cross platform

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2908: URL: https://github.com/apache/hadoop/pull/2908#issuecomment-819729658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2908: HDFS-15976. Make mkdtemp cross platform

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2908: URL: https://github.com/apache/hadoop/pull/2908#issuecomment-819718466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work started] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-17524 started by Viraj Jasani. - > Remove EventCounter > --- > > Key:

[jira] [Updated] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-17524: -- Status: Patch Available (was: In Progress) > Remove EventCounter > --- > >

[jira] [Updated] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17524: Labels: pull-request-available (was: ) > Remove EventCounter > --- > >

[jira] [Work logged] (HADOOP-17524) Remove EventCounter

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=582719=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582719 ] ASF GitHub Bot logged work on HADOOP-17524: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani opened a new pull request #2909: HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics

2021-04-14 Thread GitBox
virajjasani opened a new pull request #2909: URL: https://github.com/apache/hadoop/pull/2909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop] hadoop-yetus commented on pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2902: URL: https://github.com/apache/hadoop/pull/2902#issuecomment-819685591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] amahussein commented on a change in pull request #2878: HDFS-15957. The ignored IOException in the RPC response sent by FSEditLogAsync can cause the HDFS client to hang

2021-04-14 Thread GitBox
amahussein commented on a change in pull request #2878: URL: https://github.com/apache/hadoop/pull/2878#discussion_r613382377 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java ## @@ -378,13 +381,18 @@ public

[jira] [Work logged] (HADOOP-17471) ABFS to collect IOStatistics

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17471?focusedWorklogId=582646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582646 ] ASF GitHub Bot logged work on HADOOP-17471: --- Author: ASF GitHub Bot

[GitHub] [hadoop] functioner commented on a change in pull request #2878: HDFS-15957. The ignored IOException in the RPC response sent by FSEditLogAsync can cause the HDFS client to hang

2021-04-14 Thread GitBox
functioner commented on a change in pull request #2878: URL: https://github.com/apache/hadoop/pull/2878#discussion_r613361072 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java ## @@ -378,13 +381,18 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#issuecomment-819633848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] functioner commented on a change in pull request #2878: HDFS-15957. The ignored IOException in the RPC response sent by FSEditLogAsync can cause the HDFS client to hang

2021-04-14 Thread GitBox
functioner commented on a change in pull request #2878: URL: https://github.com/apache/hadoop/pull/2878#discussion_r613361072 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java ## @@ -378,13 +381,18 @@ public

[GitHub] [hadoop] Hexiaoqiao commented on pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
Hexiaoqiao commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819615655 > I think we also need to add some comments in the code to show why we don't shutdown this executor, in case some developers may get confused, because at the first glance

[GitHub] [hadoop] functioner commented on pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
functioner commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819605128 @Hexiaoqiao Thanks for the comment, I removed `logSyncNotifyExecutor.shutdown()`. I think we also need to add some comments in the code to show why we don't shutdown

[GitHub] [hadoop] szilard-nemeth merged pull request #2906: YARN-10736. Fix GetApplicationsRequest JavaDoc. Contributed by Miklos Gergely.

2021-04-14 Thread GitBox
szilard-nemeth merged pull request #2906: URL: https://github.com/apache/hadoop/pull/2906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] szilard-nemeth commented on pull request #2906: YARN-10736. Fix GetApplicationsRequest JavaDoc. Contributed by Miklos Gergely.

2021-04-14 Thread GitBox
szilard-nemeth commented on pull request #2906: URL: https://github.com/apache/hadoop/pull/2906#issuecomment-819599123 @miklosgergely Thanks for working on this patch. The build only fails because of test4tests, which is okay in this case. LGTM, committed to trunk. Thanks

[GitHub] [hadoop] tomscut commented on pull request #2907: HDFS-15975. Use LongAdder instead of AtomicLong

2021-04-14 Thread GitBox
tomscut commented on pull request #2907: URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819592967 > Nice one. For metrics and statistics, `LongAdder` provides much better throughput. Thanks @virajjasani for the review. -- This is an automated message from the Apache

[GitHub] [hadoop] daryn-sharp commented on a change in pull request #2878: HDFS-15957. The ignored IOException in the RPC response sent by FSEditLogAsync can cause the HDFS client to hang

2021-04-14 Thread GitBox
daryn-sharp commented on a change in pull request #2878: URL: https://github.com/apache/hadoop/pull/2878#discussion_r61355 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java ## @@ -378,13 +381,18 @@

[GitHub] [hadoop] GauthamBanasandra opened a new pull request #2908: HDFS-15976. Make mkdtemp cross platform

2021-04-14 Thread GitBox
GauthamBanasandra opened a new pull request #2908: URL: https://github.com/apache/hadoop/pull/2908 * mkdtemp is used for creating temporary directory, adhering to the given pattern. It's not available on Visual C++. Need to make this cross platform. -- This is an automated

[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

2021-04-14 Thread GitBox
Hexiaoqiao commented on a change in pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#discussion_r613305815 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java ## @@ -117,6 +125,7 @@ void

[GitHub] [hadoop] tomscut opened a new pull request #2907: HDFS-15975. Use LongAdder instead of AtomicLong

2021-04-14 Thread GitBox
tomscut opened a new pull request #2907: URL: https://github.com/apache/hadoop/pull/2907 JIRA: [HDFS-15975](https://issues.apache.org/jira/browse/HDFS-15975) When counting some indicators, we can use LongAdder instead of AtomicLong to improve performance. The long value is not an

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582539 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2906: YARN-10736. Fix GetApplicationsRequest JavaDoc. Contributed by Miklos Gergely.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2906: URL: https://github.com/apache/hadoop/pull/2906#issuecomment-819559929 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani commented on a change in pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani commented on a change in pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#discussion_r613292135 ## File path: hadoop-project/pom.xml ## @@ -210,6 +210,8 @@ 1.0.7.Final 1.0.2 5.3.0 +2.4.2 +9.8 Review comment: That's

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582537=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582537 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on a change in pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani commented on a change in pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#discussion_r613292135 ## File path: hadoop-project/pom.xml ## @@ -210,6 +210,8 @@ 1.0.7.Final 1.0.2 5.3.0 +2.4.2 +9.8 Review comment: That's

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819551391 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582532=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582532 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ayushtkn commented on a change in pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
ayushtkn commented on a change in pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#discussion_r613280902 ## File path: hadoop-project/pom.xml ## @@ -210,6 +210,8 @@ 1.0.7.Final 1.0.2 5.3.0 +2.4.2 +9.8 Review comment: Guess

[jira] [Work logged] (HADOOP-11245) Update NFS gateway to use Netty4

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11245?focusedWorklogId=582476=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582476 ] ASF GitHub Bot logged work on HADOOP-11245: --- Author: ASF GitHub Bot

[GitHub] [hadoop] szetszwo commented on a change in pull request #2832: HADOOP-11245. Update NFS gateway to use Netty4

2021-04-14 Thread GitBox
szetszwo commented on a change in pull request #2832: URL: https://github.com/apache/hadoop/pull/2832#discussion_r613193567 ## File path: hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/SimpleTcpServer.java ## @@ -59,35 +64,41 @@ public

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=582464=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582464 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=582463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582463 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-14 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818230736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-14 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818255439 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] miklosgergely opened a new pull request #2906: YARN-10736. Fix GetApplicationsRequest JavaDoc. Contributed by Miklos Gergely.

2021-04-14 Thread GitBox
miklosgergely opened a new pull request #2906: URL: https://github.com/apache/hadoop/pull/2906 getName and setName javadoc comments are mixed up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] jojochuang commented on pull request #2889: HDFS-15963. Unreleased volume references cause an infinite loop.

2021-04-14 Thread GitBox
jojochuang commented on pull request #2889: URL: https://github.com/apache/hadoop/pull/2889#issuecomment-819475596 Please fix the spotbugs warning. Other than that I am +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-14 Thread GitBox
bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819454476 > > I think We should hold this off, I think the code has issues, as I said. Earlier I thought, there is some catch but I don’t think. It is misbehaving only. Ideally such

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582400 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819448373 > And I now know how to force a full retest after a JAR update. +1, I also feel so good to know about this. -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582388 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
steveloughran commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819437080 well, we did successfully run the full 17+ build test run. And I now know how to force a full retest after a JAR update. Looking at the test failures, I'm going to say

[GitHub] [hadoop] hadoop-yetus commented on pull request #2819: HDFS-15923. Authentication failed when rename accross sub clusters.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2819: URL: https://github.com/apache/hadoop/pull/2819#issuecomment-819407274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17611) Distcp parallel file copy breaks the modification time

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=582333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582333 ] ASF GitHub Bot logged work on HADOOP-17611: --- Author: ASF GitHub Bot

[GitHub] [hadoop] amaroti edited a comment on pull request #2897: HADOOP-17611 Restore modification and access times after concat

2021-04-14 Thread GitBox
amaroti edited a comment on pull request #2897: URL: https://github.com/apache/hadoop/pull/2897#issuecomment-819387790 @bgaborg I have tested this manully by hand using two clusters. I have not yet looked into how the unit tests look like for hadoop. I will take a look at it. Also

[jira] [Work logged] (HADOOP-17611) Distcp parallel file copy breaks the modification time

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=582330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582330 ] ASF GitHub Bot logged work on HADOOP-17611: --- Author: ASF GitHub Bot

[GitHub] [hadoop] amaroti commented on pull request #2897: HADOOP-17611 Restore modification and access times after concat

2021-04-14 Thread GitBox
amaroti commented on pull request #2897: URL: https://github.com/apache/hadoop/pull/2897#issuecomment-819387790 @bgaborg I have tested this manully with hand using two clusters. I have not yet looked into how the unit tests look like for hadoop. I will take a look at it. Also Ayush

[jira] [Work logged] (HADOOP-17604) Separate string metric from tag in hadoop metrics2

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17604?focusedWorklogId=582307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582307 ] ASF GitHub Bot logged work on HADOOP-17604: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2904: HADOOP-17604 Fix method metric prefix for string type

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2904: URL: https://github.com/apache/hadoop/pull/2904#issuecomment-819357312 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17613) Log not flushed fully when daemon shutdown

2021-04-14 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320748#comment-17320748 ] Xiaoqiao He commented on HADOOP-17613: -- [~prasad-acit] cherry-pick to branch-3.3. Thanks. > Log

[jira] [Updated] (HADOOP-17613) Log not flushed fully when daemon shutdown

2021-04-14 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He updated HADOOP-17613: - Fix Version/s: 3.3.1 > Log not flushed fully when daemon shutdown >

[GitHub] [hadoop] bshashikant edited a comment on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-14 Thread GitBox
bshashikant edited a comment on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819258964 > I think We should hold this off, I think the code has issues, as I said. Earlier I thought, there is some catch but I don’t think. It is misbehaving only. Ideally

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582237=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582237 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani edited a comment on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani edited a comment on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819251359 It looks like, since we touched `LICENSE-binary` with this PR, the build is running tests for all modules and hence taking 17+ hr ? -- This is an automated message

[jira] [Updated] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-17633: -- Target Version/s: 3.3.1, 3.4.0, 3.1.5, 3.2.3 (was: 3.3.0, 3.4.0) > Please upgrade

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-14 Thread GitBox
bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819258964 > I think We should hold this off, I think the code has issues, as I said. Earlier I thought, there is some catch but I don’t think. It is misbehaving only. Ideally such

[jira] [Assigned] (HADOOP-17611) Distcp parallel file copy breaks the modification time

2021-04-14 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-17611: Assignee: Adam Maroti > Distcp parallel file copy breaks the modification time

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582228 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] jojochuang commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
jojochuang commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819256687 I don't worry too much about these two dependency bump. Netty, Jetty and jackson-databind are usually more brittle. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-14 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819251753 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Work logged] (HADOOP-17633) Please upgrade json-smart dependency to the latest version

2021-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582219 ] ASF GitHub Bot logged work on HADOOP-17633: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs

2021-04-14 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819251359 It looks like, since we touched `LICENSE-binary` with this PR, the build is running tests for all modules and hence taking 17+ hr. -- This is an automated message from the