[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=583146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583146
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-820126450
Build#8 has timed-out after 20 hr and has these test failures recorded.
Pasting screenshots here as the build data will be archived very soon.
[
https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=583145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583145
]
ASF GitHub Bot logged work on HADOOP-17524:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2909:
URL: https://github.com/apache/hadoop/pull/2909#issuecomment-820124354
Test failure has been taken care of in recent commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=583144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583144
]
ASF GitHub Bot logged work on HADOOP-17524:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2909:
URL: https://github.com/apache/hadoop/pull/2909#issuecomment-820123401
@Apache9 @aajisaka Could you please take a look?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-820106508
@Hexiaoqiao thanks for the reminder. I've added:
1. comments for removing `logSyncNotifyExecutor.shutdown()`
2. configuration for the size of `logSyncNotifyExecutor`
Hexiaoqiao commented on pull request #2889:
URL: https://github.com/apache/hadoop/pull/2889#issuecomment-820096203
Thanks @zhangshuyan0 for your great catch here. LGTM. +1 from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Hexiaoqiao commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-820080877
@functioner after review code, comment from Yiqun seems not resolved yet, do
you mind to make thread pool size be configurable?
--
This is an automated message from the
qizhu-lucas opened a new pull request #2911:
URL: https://github.com/apache/hadoop/pull/2911
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number.
ferhui merged pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
cxorm commented on a change in pull request #2910:
URL: https://github.com/apache/hadoop/pull/2910#discussion_r613727691
##
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java
##
@@ -371,13 +372,13 @@
ferhui commented on pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902#issuecomment-820025360
@jojochuang Thanks for this PR. @virajjasani Thanks for review!
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hadoop-yetus commented on pull request #2910:
URL: https://github.com/apache/hadoop/pull/2910#issuecomment-820010002
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
tomscut commented on pull request #2896:
URL: https://github.com/apache/hadoop/pull/2896#issuecomment-819960710
Hi @tasanuma , could you please do another review? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tomscut commented on pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819959935
Those failed unit tests were unrelated to the change. And they work fine
locally.
Hi @goiri @tasanuma , could you please review the code? Thanks very much.
--
This is
fengnanli opened a new pull request #2910:
URL: https://github.com/apache/hadoop/pull/2910
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g.
hadoop-yetus commented on pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819897893
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819872752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819811557
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=582862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582862
]
ASF GitHub Bot logged work on HADOOP-17524:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2909:
URL: https://github.com/apache/hadoop/pull/2909#issuecomment-819810914
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Hussein reassigned HADOOP-16206:
--
Assignee: Duo Zhang
> Migrate from Log4j1 to Log4j2
> -
jbrennan333 merged pull request #2899:
URL: https://github.com/apache/hadoop/pull/2899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hadoop-yetus commented on pull request #2908:
URL: https://github.com/apache/hadoop/pull/2908#issuecomment-819729658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2908:
URL: https://github.com/apache/hadoop/pull/2908#issuecomment-819718466
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HADOOP-17524 started by Viraj Jasani.
-
> Remove EventCounter
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HADOOP-17524:
--
Status: Patch Available (was: In Progress)
> Remove EventCounter
> ---
>
>
[
https://issues.apache.org/jira/browse/HADOOP-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-17524:
Labels: pull-request-available (was: )
> Remove EventCounter
> ---
>
>
[
https://issues.apache.org/jira/browse/HADOOP-17524?focusedWorklogId=582719=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582719
]
ASF GitHub Bot logged work on HADOOP-17524:
---
Author: ASF GitHub Bot
virajjasani opened a new pull request #2909:
URL: https://github.com/apache/hadoop/pull/2909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
hadoop-yetus commented on pull request #2902:
URL: https://github.com/apache/hadoop/pull/2902#issuecomment-819685591
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
amahussein commented on a change in pull request #2878:
URL: https://github.com/apache/hadoop/pull/2878#discussion_r613382377
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##
@@ -378,13 +381,18 @@ public
[
https://issues.apache.org/jira/browse/HADOOP-17471?focusedWorklogId=582646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582646
]
ASF GitHub Bot logged work on HADOOP-17471:
---
Author: ASF GitHub Bot
functioner commented on a change in pull request #2878:
URL: https://github.com/apache/hadoop/pull/2878#discussion_r613361072
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##
@@ -378,13 +381,18 @@ public
hadoop-yetus commented on pull request #2731:
URL: https://github.com/apache/hadoop/pull/2731#issuecomment-819633848
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
functioner commented on a change in pull request #2878:
URL: https://github.com/apache/hadoop/pull/2878#discussion_r613361072
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##
@@ -378,13 +381,18 @@ public
Hexiaoqiao commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819615655
> I think we also need to add some comments in the code to show why we don't
shutdown this executor, in case some developers may get confused, because at
the first glance
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819605128
@Hexiaoqiao Thanks for the comment, I removed
`logSyncNotifyExecutor.shutdown()`.
I think we also need to add some comments in the code to show why we don't
shutdown
szilard-nemeth merged pull request #2906:
URL: https://github.com/apache/hadoop/pull/2906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
szilard-nemeth commented on pull request #2906:
URL: https://github.com/apache/hadoop/pull/2906#issuecomment-819599123
@miklosgergely
Thanks for working on this patch.
The build only fails because of test4tests, which is okay in this case.
LGTM, committed to trunk.
Thanks
tomscut commented on pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#issuecomment-819592967
> Nice one. For metrics and statistics, `LongAdder` provides much better
throughput.
Thanks @virajjasani for the review.
--
This is an automated message from the Apache
daryn-sharp commented on a change in pull request #2878:
URL: https://github.com/apache/hadoop/pull/2878#discussion_r61355
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##
@@ -378,13 +381,18 @@
GauthamBanasandra opened a new pull request #2908:
URL: https://github.com/apache/hadoop/pull/2908
* mkdtemp is used for creating temporary
directory, adhering to the given pattern.
It's not available on Visual C++. Need
to make this cross platform.
--
This is an automated
Hexiaoqiao commented on a change in pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#discussion_r613305815
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##
@@ -117,6 +125,7 @@ void
tomscut opened a new pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907
JIRA: [HDFS-15975](https://issues.apache.org/jira/browse/HDFS-15975)
When counting some indicators, we can use LongAdder instead of AtomicLong to
improve performance. The long value is not an
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582539
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2906:
URL: https://github.com/apache/hadoop/pull/2906#issuecomment-819559929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
virajjasani commented on a change in pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#discussion_r613292135
##
File path: hadoop-project/pom.xml
##
@@ -210,6 +210,8 @@
1.0.7.Final
1.0.2
5.3.0
+2.4.2
+9.8
Review comment:
That's
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582537=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582537
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on a change in pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#discussion_r613292135
##
File path: hadoop-project/pom.xml
##
@@ -210,6 +210,8 @@
1.0.7.Final
1.0.2
5.3.0
+2.4.2
+9.8
Review comment:
That's
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819551391
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582532=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582532
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
ayushtkn commented on a change in pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#discussion_r613280902
##
File path: hadoop-project/pom.xml
##
@@ -210,6 +210,8 @@
1.0.7.Final
1.0.2
5.3.0
+2.4.2
+9.8
Review comment:
Guess
[
https://issues.apache.org/jira/browse/HADOOP-11245?focusedWorklogId=582476=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582476
]
ASF GitHub Bot logged work on HADOOP-11245:
---
Author: ASF GitHub Bot
szetszwo commented on a change in pull request #2832:
URL: https://github.com/apache/hadoop/pull/2832#discussion_r613193567
##
File path:
hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/SimpleTcpServer.java
##
@@ -59,35 +64,41 @@ public
[
https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=582464=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582464
]
ASF GitHub Bot logged work on HADOOP-17511:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=582463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582463
]
ASF GitHub Bot logged work on HADOOP-17511:
---
Author: ASF GitHub Bot
hadoop-yetus removed a comment on pull request #2807:
URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818230736
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
hadoop-yetus removed a comment on pull request #2807:
URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818255439
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
miklosgergely opened a new pull request #2906:
URL: https://github.com/apache/hadoop/pull/2906
getName and setName javadoc comments are mixed up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jojochuang commented on pull request #2889:
URL: https://github.com/apache/hadoop/pull/2889#issuecomment-819475596
Please fix the spotbugs warning. Other than that I am +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bshashikant commented on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819454476
> > I think We should hold this off, I think the code has issues, as I said.
Earlier I thought, there is some catch but I don’t think. It is misbehaving
only. Ideally such
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582400
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819448373
> And I now know how to force a full retest after a JAR update.
+1, I also feel so good to know about this.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582388
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
steveloughran commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819437080
well, we did successfully run the full 17+ build test run. And I now know
how to force a full retest after a JAR update. Looking at the test failures,
I'm going to say
hadoop-yetus commented on pull request #2819:
URL: https://github.com/apache/hadoop/pull/2819#issuecomment-819407274
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=582333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582333
]
ASF GitHub Bot logged work on HADOOP-17611:
---
Author: ASF GitHub Bot
amaroti edited a comment on pull request #2897:
URL: https://github.com/apache/hadoop/pull/2897#issuecomment-819387790
@bgaborg
I have tested this manully by hand using two clusters. I have not yet looked
into how the unit tests look like for hadoop. I will take a look at it. Also
[
https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=582330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582330
]
ASF GitHub Bot logged work on HADOOP-17611:
---
Author: ASF GitHub Bot
amaroti commented on pull request #2897:
URL: https://github.com/apache/hadoop/pull/2897#issuecomment-819387790
@bgaborg
I have tested this manully with hand using two clusters. I have not yet
looked into how the unit tests look like for hadoop. I will take a look at it.
Also Ayush
[
https://issues.apache.org/jira/browse/HADOOP-17604?focusedWorklogId=582307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582307
]
ASF GitHub Bot logged work on HADOOP-17604:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2904:
URL: https://github.com/apache/hadoop/pull/2904#issuecomment-819357312
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320748#comment-17320748
]
Xiaoqiao He commented on HADOOP-17613:
--
[~prasad-acit] cherry-pick to branch-3.3. Thanks.
> Log
[
https://issues.apache.org/jira/browse/HADOOP-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoqiao He updated HADOOP-17613:
-
Fix Version/s: 3.3.1
> Log not flushed fully when daemon shutdown
>
bshashikant edited a comment on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819258964
> I think We should hold this off, I think the code has issues, as I said.
Earlier I thought, there is some catch but I don’t think. It is misbehaving
only. Ideally
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582237=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582237
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani edited a comment on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819251359
It looks like, since we touched `LICENSE-binary` with this PR, the build is
running tests for all modules and hence taking 17+ hr ?
--
This is an automated message
[
https://issues.apache.org/jira/browse/HADOOP-17633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HADOOP-17633:
--
Target Version/s: 3.3.1, 3.4.0, 3.1.5, 3.2.3 (was: 3.3.0, 3.4.0)
> Please upgrade
bshashikant commented on pull request #2881:
URL: https://github.com/apache/hadoop/pull/2881#issuecomment-819258964
> I think We should hold this off, I think the code has issues, as I said.
Earlier I thought, there is some catch but I don’t think. It is misbehaving
only. Ideally such
[
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang reassigned HADOOP-17611:
Assignee: Adam Maroti
> Distcp parallel file copy breaks the modification time
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582228
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
jojochuang commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819256687
I don't worry too much about these two dependency bump. Netty, Jetty and
jackson-databind are usually more brittle.
--
This is an automated message from the Apache Git
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819251753
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
[
https://issues.apache.org/jira/browse/HADOOP-17633?focusedWorklogId=582219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582219
]
ASF GitHub Bot logged work on HADOOP-17633:
---
Author: ASF GitHub Bot
virajjasani commented on pull request #2895:
URL: https://github.com/apache/hadoop/pull/2895#issuecomment-819251359
It looks like, since we touched `LICENSE-binary` with this PR, the build is
running tests for all modules and hence taking 17+ hr.
--
This is an automated message from the
87 matches
Mail list logo