[GitHub] [hadoop] virajjasani commented on pull request #2998: HDFS-16016. BPServiceActor to provide new thread to handle IBR

2021-05-24 Thread GitBox
virajjasani commented on pull request #2998: URL: https://github.com/apache/hadoop/pull/2998#issuecomment-847554213 @liuml07 would you like to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] zhuxiangyi commented on a change in pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-24 Thread GitBox
zhuxiangyi commented on a change in pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#discussion_r638469781 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java ## @@ -0,0 +1,263

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601526=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601526 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on a change in pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
virajjasani commented on a change in pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#discussion_r638467252 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java ## @@ -192,7 +191,7

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=601522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601522 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub Bot

[GitHub] [hadoop] liuml07 edited a comment on pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread GitBox
liuml07 edited a comment on pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#issuecomment-847527081 Thanks for including me, @steveloughran Let me first understand the problem: unless new reference object is available in the queue (Java code calling `enqueue()`),

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=601521=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601521 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub Bot

[GitHub] [hadoop] liuml07 commented on pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread GitBox
liuml07 commented on pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#issuecomment-847527081 Thanks for including me, @steveloughran Let me first understand the problem: unless new reference object is available in the queue (Java code calling `enqueue()`), those

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=601516=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601516 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub Bot

[GitHub] [hadoop] yikf commented on a change in pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread GitBox
yikf commented on a change in pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#discussion_r638417055 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ## @@ -4004,12 +4004,14 @@ public void cleanUp() {

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=601507=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601507 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub Bot

[GitHub] [hadoop] yikf commented on a change in pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread GitBox
yikf commented on a change in pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#discussion_r638417055 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ## @@ -4004,12 +4004,14 @@ public void cleanUp() {

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=601506=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601506 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub Bot

[GitHub] [hadoop] yikf commented on a change in pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-24 Thread GitBox
yikf commented on a change in pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#discussion_r638417055 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ## @@ -4004,12 +4004,14 @@ public void cleanUp() {

[GitHub] [hadoop] hadoop-yetus commented on pull request #3046: HDFS-16037. Possible Resource Leak in org.apache.hadoop.hdfs.tools.offlineImageViewer#FSImageLoader

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3046: URL: https://github.com/apache/hadoop/pull/3046#issuecomment-847473771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601491=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601491 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[jira] [Resolved] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma resolved HADOOP-17720. --- Fix Version/s: 3.4.0 Resolution: Fixed > Replace Guava Sets usage by

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601490 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[GitHub] [hadoop] tasanuma commented on pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
tasanuma commented on pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#issuecomment-847471868 Merged. Thanks for your contribution, @virajjasani. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] tasanuma merged pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
tasanuma merged pull request #3031: URL: https://github.com/apache/hadoop/pull/3031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601488=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601488 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[GitHub] [hadoop] tasanuma commented on a change in pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
tasanuma commented on a change in pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#discussion_r638399025 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java ## @@ -192,7 +191,7 @@

[jira] [Commented] (HADOOP-17708) Fail to build hadoop-common from source on Fedora

2021-05-24 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350720#comment-17350720 ] Masatake Iwasaki commented on HADOOP-17708: --- [~bioinfornatics] The fix version/s of

[jira] [Work logged] (HADOOP-17722) Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17722?focusedWorklogId=601478=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601478 ] ASF GitHub Bot logged work on HADOOP-17722: --- Author: ASF GitHub Bot

[jira] [Resolved] (HADOOP-17722) Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma resolved HADOOP-17722. --- Fix Version/s: 3.4.0 Resolution: Fixed > Replace Guava Sets usage by

[jira] [Work logged] (HADOOP-17722) Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17722?focusedWorklogId=601477=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601477 ] ASF GitHub Bot logged work on HADOOP-17722: --- Author: ASF GitHub Bot

[GitHub] [hadoop] tasanuma commented on pull request #3032: HADOOP-17722. Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread GitBox
tasanuma commented on pull request #3032: URL: https://github.com/apache/hadoop/pull/3032#issuecomment-847455982 Merged. Thanks for your contribution, @virajjasani. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] tasanuma merged pull request #3032: HADOOP-17722. Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread GitBox
tasanuma merged pull request #3032: URL: https://github.com/apache/hadoop/pull/3032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] hadoop-yetus commented on pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#issuecomment-847444940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17343) Upgrade aws-java-sdk to 1.11.901

2021-05-24 Thread Jason Wen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350689#comment-17350689 ] Jason Wen commented on HADOOP-17343: It list 3.2.2 as 'Fix Version', but actually it's not fixed in

[GitHub] [hadoop] goiri commented on a change in pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-24 Thread GitBox
goiri commented on a change in pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#discussion_r638296038 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/RemoteLocation.java ## @@ -80,6 +94,14 @@

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601401 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847334987 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601374=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601374 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847305964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=601358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601358 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-847290916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3005: HDFS-13522. RBF: Support observer node from Router-Based Federation

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3005: URL: https://github.com/apache/hadoop/pull/3005#issuecomment-847278788 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17721) Replace Guava Sets usage by Hadoop's own Sets in hadoop-yarn-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17721?focusedWorklogId=601344=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601344 ] ASF GitHub Bot logged work on HADOOP-17721: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3033: HADOOP-17721. Replace Guava Sets usage by Hadoop's own Sets in hadoop-yarn-project

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3033: URL: https://github.com/apache/hadoop/pull/3033#issuecomment-847272999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=601343=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601343 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub Bot

[GitHub] [hadoop] goiri commented on a change in pull request #3043: HADOOP-17727. Modularize docker images

2021-05-24 Thread GitBox
goiri commented on a change in pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#discussion_r638210967 ## File path: dev-support/docker/pkg-resolver/install-common-pkgs.sh ## @@ -0,0 +1,98 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software

[GitHub] [hadoop] Nargeshdb opened a new pull request #3046: HDFS-16037. Possible Resource Leak in org.apache.hadoop.hdfs.tools.offlineImageViewer#FSImageLoader

2021-05-24 Thread GitBox
Nargeshdb opened a new pull request #3046: URL: https://github.com/apache/hadoop/pull/3046 This PR fixes the issue mentioned [here](https://issues.apache.org/jira/browse/HDFS-16037). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=601321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601321 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-847236819 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2021-05-24 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350561#comment-17350561 ] Ahmed Hussein commented on HADOOP-16206: {quote}The problem is about compatibility... I'm sure

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601312=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601312 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847222690 not sure what is up with yetus there. Submitted again, with some updated docs -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Work logged] (HADOOP-17722) Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17722?focusedWorklogId=601300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601300 ] ASF GitHub Bot logged work on HADOOP-17722: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3032: HADOOP-17722. Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3032: URL: https://github.com/apache/hadoop/pull/3032#issuecomment-847205247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#issuecomment-847204048 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601297 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=601289=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601289 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3041: HADOOP-17725. Improve error message for token providers in ABFS

2021-05-24 Thread GitBox
virajjasani commented on pull request #3041: URL: https://github.com/apache/hadoop/pull/3041#issuecomment-847197229 @aajisaka would you like to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] Nargeshdb commented on a change in pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-24 Thread GitBox
Nargeshdb commented on a change in pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#discussion_r638117441 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap/InMemoryAliasMap.java ## @@ -320,21 +320,18 @@

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601269 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#issuecomment-847168809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] Nargeshdb commented on a change in pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-24 Thread GitBox
Nargeshdb commented on a change in pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#discussion_r638098989 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap/InMemoryAliasMap.java ## @@ -320,21 +320,18 @@

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601264 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847159189 rebased to trunk again after the AWS region patch from mehakmeet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HADOOP-17731) IPC client is stuck, waiting for connections map to be empty

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HADOOP-17731: - Component/s: ipc > IPC client is stuck, waiting for connections map to be

[jira] [Moved] (HADOOP-17731) IPC client is stuck, waiting for connections map to be empty

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell moved HDFS-16036 to HADOOP-17731: - Key: HADOOP-17731 (was: HDFS-16036)

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601255=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601255 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601253 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847149166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847148990 Somehow the header test had failed on the principal. Changes * how the principal is added has changed * fixed up the referrer entry which adding a hadoop/1 prefix

[jira] [Updated] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17730: - Priority: Major (was: Blocker) > [thirdparty] Do not exclude error_prone >

[jira] [Updated] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17730: - Priority: Blocker (was: Major) > [thirdparty] Do not exclude error_prone >

[jira] [Updated] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17730: Labels: pull-request-available (was: ) > [thirdparty] Do not exclude error_prone >

[jira] [Updated] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17730: - Affects Version/s: (was: 1.1.0) 3.3.1

[jira] [Assigned] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-17730: Target Version/s: thirdparty-1.1.1 Assignee: Wei-Chiu Chuang >

[jira] [Created] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2021-05-24 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-17730: Summary: [thirdparty] Do not exclude error_prone Key: HADOOP-17730 URL: https://issues.apache.org/jira/browse/HADOOP-17730 Project: Hadoop Common

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601235 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847125985 legit test regression. The code to determine the principal is returning null ``` [ERROR]

[jira] [Commented] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2021-05-24 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350474#comment-17350474 ] Duo Zhang commented on HADOOP-16206: I do not think it is about the difficulty, if we choose to do

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601216=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601216 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847092269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17115) Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-24 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350467#comment-17350467 ] Ahmed Hussein commented on HADOOP-17115: Apologies for not following up with reviews as I was

[jira] [Commented] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2021-05-24 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350465#comment-17350465 ] Ahmed Hussein commented on HADOOP-16206: {quote}So any suggestions here? Should we do the same

[jira] [Work logged] (HADOOP-17722) Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17722?focusedWorklogId=601206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601206 ] ASF GitHub Bot logged work on HADOOP-17722: --- Author: ASF GitHub Bot

[GitHub] [hadoop] tasanuma commented on pull request #3032: HADOOP-17722. Replace Guava Sets usage by Hadoop's own Sets in hadoop-mapreduce-project

2021-05-24 Thread GitBox
tasanuma commented on pull request #3032: URL: https://github.com/apache/hadoop/pull/3032#issuecomment-847070533 +1, pending Jenkins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (HADOOP-17666) Update LICENSE for 3.3.1

2021-05-24 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-17666. -- Fix Version/s: 3.4.0 3.3.1 Resolution: Fixed > Update

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601165 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=601163=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601163 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran edited a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran edited a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847009025 tests aws london `-Dparallel-tests -DtestsThreadCount=5 -Dmarkers=delete -Dscale` run all good, getting a bit slow (tombstones?) ``` [INFO] [WARNING]

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-24 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-847009025 test run all good, getting a bit slow (tombstones?) ``` [INFO] [WARNING] Tests run: 151, Failures: 0, Errors: 0, Skipped: 17 [INFO] [INFO]

[jira] [Work logged] (HADOOP-17720) Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17720?focusedWorklogId=601162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601162 ] ASF GitHub Bot logged work on HADOOP-17720: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3031: HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project

2021-05-24 Thread GitBox
virajjasani commented on pull request #3031: URL: https://github.com/apache/hadoop/pull/3031#issuecomment-847005879 Thanks for the reviews @tasanuma. When you get time, please take a look at #3032 and #3033 , updated them with import order changes. -- This is an automated message from

[jira] [Updated] (HADOOP-17670) S3AFS and ABFS to log IOStats at DEBUG mode or optionally at INFO level in close()

2021-05-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17670: Component/s: fs/s3 fs/azure > S3AFS and ABFS to log IOStats at DEBUG

[jira] [Updated] (HADOOP-17670) S3AFS and ABFS to log IOStats at DEBUG mode or optionally at INFO level in close()

2021-05-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17670: Priority: Minor (was: Major) > S3AFS and ABFS to log IOStats at DEBUG mode or

[jira] [Resolved] (HADOOP-17670) S3AFS and ABFS to log IOStats at DEBUG mode or optionally at INFO level in close()

2021-05-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-17670. - Fix Version/s: 3.3.2 Resolution: Fixed > S3AFS and ABFS to log IOStats at DEBUG

[jira] [Resolved] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-24 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-17705. - Fix Version/s: 3.3.2 Resolution: Fixed merged to trunk and branch-3.3. Which I

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=601156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601156 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-24 Thread GitBox
steveloughran commented on pull request #3020: URL: https://github.com/apache/hadoop/pull/3020#issuecomment-847001337 merged to trunk, backporting if the new test runs OK there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=601153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601153 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran merged pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-24 Thread GitBox
steveloughran merged pull request #3020: URL: https://github.com/apache/hadoop/pull/3020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=601150=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601150 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=601151=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601151 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-24 Thread GitBox
hadoop-yetus removed a comment on pull request #3020: URL: https://github.com/apache/hadoop/pull/3020#issuecomment-844077830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-24 Thread GitBox
hadoop-yetus removed a comment on pull request #3020: URL: https://github.com/apache/hadoop/pull/3020#issuecomment-843060447 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

  1   2   >