[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637926=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637926
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898811923
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
lzx404243 commented on pull request #2968:
URL: https://github.com/apache/hadoop/pull/2968#issuecomment-898794250
Hi @aajisaka , could you please help reviewing this change? It resolves
similar issues as #2499 . Thanks!
--
This is an automated message from the Apache Git Service.
To
lzx404243 commented on pull request #2500:
URL: https://github.com/apache/hadoop/pull/2500#issuecomment-898794132
Hi @aajisaka , could you please help reviewing this change? It resolves
similar issues as #2499 . Thanks!
--
This is an automated message from the Apache Git Service.
To
lzx404243 commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-898793941
Hi @aajisaka , could you please help reviewing this change? It resolves
similar issues as https://github.com/apache/hadoop/pull/2499 . Thanks!
--
This is an automated
hadoop-yetus commented on pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#issuecomment-898788219
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637915
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898785995
Thank you @sunchao !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637911=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637911
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
sunchao commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898783160
> @sunchao They are from testBZip2NativeCodec and
testCodecPoolCompressorReinit. They are original code which this change doesn't
touch. Do we want to change it here?
It
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637907
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898778379
Looks like unrelated failure.
```
[ERROR] Tests run: 18, Failures: 0, Errors: 12, Skipped: 0, Time elapsed:
2.128 s <<< FAILURE! - in
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637906
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898777110
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637900=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637900
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898773785
@sunchao They are from `testBZip2NativeCodec` and
`testCodecPoolCompressorReinit`. They are original code which this change
doesn't touch. Do we want to change it here?
--
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637898=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637898
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-898767347
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
LeonGao91 commented on pull request #3284:
URL: https://github.com/apache/hadoop/pull/3284#issuecomment-898741480
thanks for the review @fengnanli @Hexiaoqiao ! will make the change
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637887
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688773637
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
##
@@ -882,26 +908,28 @@ private void
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637885=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637885
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
sunchao commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688770891
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
##
@@ -882,26 +908,28 @@ private void
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637884=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637884
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
hadoop-yetus removed a comment on pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#issuecomment-897916404
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637880
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688751999
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637876
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
sunchao commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688739194
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637875=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637875
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637874=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637874
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688737420
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688737260
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637873=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637873
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688736893
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637872=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637872
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688736308
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637871
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688736051
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+ *
shvachko commented on pull request #3232:
URL: https://github.com/apache/hadoop/pull/3232#issuecomment-898665090
@prasad-acit I removed on commit those lines that you commented out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shvachko commented on pull request #3232:
URL: https://github.com/apache/hadoop/pull/3232#issuecomment-898648082
+1 this looks good now. Will commit in a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
virajjasani commented on a change in pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#discussion_r688683336
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
##
@@ -307,6
virajjasani commented on a change in pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#discussion_r688681995
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
##
@@ -307,6
virajjasani commented on a change in pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#discussion_r688681854
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
##
@@ -307,6
aajisaka commented on pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#issuecomment-898616551
@virajjasani Thank you for your work. Overall looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aajisaka commented on a change in pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#discussion_r688674750
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
##
@@ -307,6 +323,59
aajisaka commented on a change in pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#discussion_r688673319
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
##
@@ -307,6 +323,59
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637838
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
sunchao commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688637566
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##
@@ -0,0 +1,261 @@
+/*
+
[
https://issues.apache.org/jira/browse/HADOOP-17825?focusedWorklogId=637828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637828
]
ASF GitHub Bot logged work on HADOOP-17825:
---
Author: ASF GitHub Bot
viirya commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688633641
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
##
@@ -882,26 +908,28 @@ private void
Li Rong created HADOOP-17847:
Summary: S3AInstrumentation Closing output stream statistics while
data is still marked as pending upload in OutputStreamStatistics
Key: HADOOP-17847
URL:
jianghuazhu commented on pull request #3302:
URL: https://github.com/apache/hadoop/pull/3302#issuecomment-898423320
There are some exceptions in CI/CD:
1.org.jenkinsci.plugins.workflow.steps.MissingContextVariableException:
Required context class hudson.FilePath is missing
Perhaps
hadoop-yetus commented on pull request #3296:
URL: https://github.com/apache/hadoop/pull/3296#issuecomment-898417526
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
jianghuazhu opened a new pull request #3302:
URL: https://github.com/apache/hadoop/pull/3302
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number.
[
https://issues.apache.org/jira/browse/HADOOP-17844?focusedWorklogId=637762=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637762
]
ASF GitHub Bot logged work on HADOOP-17844:
---
Author: ASF GitHub Bot
prasad-acit removed a comment on pull request #3299:
URL: https://github.com/apache/hadoop/pull/3299#issuecomment-898073289
Thank you for quick review and feedback.
Jenkins got completed and no new failures. Also, it's a third party upgrade,
no new tests added.
--
This is an
virajjasani commented on pull request #3296:
URL: https://github.com/apache/hadoop/pull/3296#issuecomment-898350217
As per the latest QA results, we have all tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hadoop-yetus commented on pull request #3296:
URL: https://github.com/apache/hadoop/pull/3296#issuecomment-898339232
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
tomscut commented on pull request #3291:
URL: https://github.com/apache/hadoop/pull/3291#issuecomment-898329687
Thanks @ferhui for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
szilard-nemeth edited a comment on pull request #3286:
URL: https://github.com/apache/hadoop/pull/3286#issuecomment-898309256
> @tomicooler branch-3.1 is already EoL, and 3.1.5 release will never
happen. Would you still want to backport it into branch-3.1?
Thanks for bringing this
szilard-nemeth commented on pull request #3286:
URL: https://github.com/apache/hadoop/pull/3286#issuecomment-898309256
> @tomicooler branch-3.1 is already EoL, and 3.1.5 release will never
happen. Would you still want to backport it into branch-3.1?
Thanks for bringing this in. I
Hexiaoqiao commented on pull request #3284:
URL: https://github.com/apache/hadoop/pull/3284#issuecomment-898297579
Thanks @LeonGao91 and @fengnanli . It is great improvement here. Just some
nits here,
a. We should put the new configuration item to hdfs-default.xml.
b. If enable this
ferhui commented on pull request #3291:
URL: https://github.com/apache/hadoop/pull/3291#issuecomment-898286830
Will merge if no other comments next Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ferhui commented on pull request #3291:
URL: https://github.com/apache/hadoop/pull/3291#issuecomment-898286231
Thanks for ping, the change looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hadoop-yetus commented on pull request #3286:
URL: https://github.com/apache/hadoop/pull/3286#issuecomment-898249516
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #3232:
URL: https://github.com/apache/hadoop/pull/3232#issuecomment-898223775
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
tomscut edited a comment on pull request #3291:
URL: https://github.com/apache/hadoop/pull/3291#issuecomment-898215822
Hi @aajisaka @ferhui , could you please help review these PRs:
[PR#3291](https://github.com/apache/hadoop/pull/3291) and
tomscut commented on pull request #3291:
URL: https://github.com/apache/hadoop/pull/3291#issuecomment-898215822
Hi @aajisaka @ferhui , could you please help review these PR:
[PR#3291](https://github.com/apache/hadoop/pull/3291) and
[PR#3288](https://github.com/apache/hadoop/pull/3288).
69 matches
Mail list logo