[GitHub] [hadoop] hadoop-yetus commented on pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#issuecomment-1019087733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=713190=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713190 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3906: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3906: URL: https://github.com/apache/hadoop/pull/3906#issuecomment-1019085492 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] ThinkerLei commented on a change in pull request #3898: HDFS-16428. Source path setted storagePolicy will cause wrong typeCon…

2022-01-21 Thread GitBox
ThinkerLei commented on a change in pull request #3898: URL: https://github.com/apache/hadoop/pull/3898#discussion_r790095163 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java ## @@ -339,6 +339,13 @@ public boolean

[GitHub] [hadoop] hadoop-yetus commented on pull request #3741: YARN-11026. Make default AppPlacementAllocator configurable in AppSch…

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3741: URL: https://github.com/apache/hadoop/pull/3741#issuecomment-1018940680 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3898: HDFS-16428. Source path setted storagePolicy will cause wrong typeCon…

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3898: URL: https://github.com/apache/hadoop/pull/3898#issuecomment-1018917145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?focusedWorklogId=713099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713099 ] ASF GitHub Bot logged work on HADOOP-18089: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3913: HADOOP-18089. Test coverage for Async profiler servlets

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3913: URL: https://github.com/apache/hadoop/pull/3913#issuecomment-1018901314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?focusedWorklogId=713034=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713034 ] ASF GitHub Bot logged work on HADOOP-18089: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3913: HADOOP-18089. Test coverage for Async profiler servlets

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3913: URL: https://github.com/apache/hadoop/pull/3913#issuecomment-1018769536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3909: HDFS-16431. Truncate CallerContext in client side.

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3909: URL: https://github.com/apache/hadoop/pull/3909#issuecomment-1018739271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3900: HDFS-16429.Add DataSetLockManager to maintain block pool level lock a…

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3900: URL: https://github.com/apache/hadoop/pull/3900#issuecomment-1018734777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] minni31 commented on pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse

2022-01-21 Thread GitBox
minni31 commented on pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#issuecomment-1018727927 @goiri I checked the CI issue and discussed with @GauthamBanasandra also. It seems to be warning in C code and are unrelated to my changes. -- This is an automated message

[jira] [Updated] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18089: -- Priority: Minor (was: Major) > Test coverage for Async profiler servlets >

[jira] [Work logged] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?focusedWorklogId=712929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712929 ] ASF GitHub Bot logged work on HADOOP-18089: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3913: HADOOP-18089. Test coverage for Async profiler servlets

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3913: URL: https://github.com/apache/hadoop/pull/3913#issuecomment-1018593362 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18071) ABFS: Set driver global timeout for ITestAzureBlobFileSystemBasics

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18071?focusedWorklogId=712813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712813 ] ASF GitHub Bot logged work on HADOOP-18071: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3866: HADOOP-18071. ABFS: Set driver global timeout for ITestAzureBlobFileSystemBasics

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3866: URL: https://github.com/apache/hadoop/pull/3866#issuecomment-1018470326 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18080) ABFS: Skip testEtagConsistencyAcrossRename for Non-HNS accounts

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18080?focusedWorklogId=712811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712811 ] ASF GitHub Bot logged work on HADOOP-18080: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3914: HADOOP-18080. ABFS: Skip testEtagConsistencyAcrossRename for Non-HNS accounts

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3914: URL: https://github.com/apache/hadoop/pull/3914#issuecomment-1018467734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=712808=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712808 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] jojochuang commented on pull request #3906: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-01-21 Thread GitBox
jojochuang commented on pull request #3906: URL: https://github.com/apache/hadoop/pull/3906#issuecomment-1018466715 > more that we need to keep out any log4j stuff coming in once we remove it from hadoop common. I know of one > > ``` > [INFO] \-

[jira] [Work logged] (HADOOP-18082) Add debug log when RPC#Reader gets a Call

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18082?focusedWorklogId=712797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712797 ] ASF GitHub Bot logged work on HADOOP-18082: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on a change in pull request #3891: HADOOP-18082.Add debug log when RPC#Reader gets a Call.

2022-01-21 Thread GitBox
virajjasani commented on a change in pull request #3891: URL: https://github.com/apache/hadoop/pull/3891#discussion_r789598239 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java ## @@ -3046,6 +3046,8 @@ private void

[jira] [Work logged] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?focusedWorklogId=712777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712777 ] ASF GitHub Bot logged work on HADOOP-18089: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3913: HADOOP-18089. Test coverage for Async profiler servlets

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3913: URL: https://github.com/apache/hadoop/pull/3913#issuecomment-1018421160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Updated] (HADOOP-18080) ABFS: Skip testEtagConsistencyAcrossRename for Non-HNS accounts

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18080: Labels: pull-request-available (was: ) > ABFS: Skip testEtagConsistencyAcrossRename for

[jira] [Work logged] (HADOOP-18080) ABFS: Skip testEtagConsistencyAcrossRename for Non-HNS accounts

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18080?focusedWorklogId=712759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712759 ] ASF GitHub Bot logged work on HADOOP-18080: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sumangala-patki opened a new pull request #3914: HADOOP-18080. ABFS: Skip testEtagConsistencyAcrossRename for Non-HNS accounts

2022-01-21 Thread GitBox
sumangala-patki opened a new pull request #3914: URL: https://github.com/apache/hadoop/pull/3914 The rename operation is not supported for non-HNS accounts. Hence, tests verifying matching etag for file before and after rename should not be run against non-HNS accounts. PR modifies the

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=712745=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712745 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3906: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-01-21 Thread GitBox
steveloughran commented on pull request #3906: URL: https://github.com/apache/hadoop/pull/3906#issuecomment-1018401121 more that we need to keep out any log4j stuff coming in once we remove it from hadoop common. I know of one ``` [INFO] \-

[jira] [Work logged] (HADOOP-11867) FS API: Add a high-performance vectored Read to FSDataInputStream API

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?focusedWorklogId=712727=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712727 ] ASF GitHub Bot logged work on HADOOP-11867: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #3904: HADOOP-11867. Add a high performance vectored read API to file system.

2022-01-21 Thread GitBox
steveloughran commented on a change in pull request #3904: URL: https://github.com/apache/hadoop/pull/3904#discussion_r789545997 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java ## @@ -120,6

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=712725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712725 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] Apache9 commented on pull request #3906: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-01-21 Thread GitBox
Apache9 commented on pull request #3906: URL: https://github.com/apache/hadoop/pull/3906#issuecomment-1018384643 > I like this. i spent some time last week moving cloudstore to logback. all our modules indirectly publish their dependency on hadoop-common and so whatever logger is

[jira] [Work logged] (HADOOP-17743) Replace Guava Lists usage by Hadoop's own Lists in hadoop-common, hadoop-tools and cloud-storage projects

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17743?focusedWorklogId=712724=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712724 ] ASF GitHub Bot logged work on HADOOP-17743: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3072: HADOOP-17743. Replace Guava Lists usage by Hadoop's own Lists in hadoop-common, hadoop-tools and cloud-storage projects

2022-01-21 Thread GitBox
steveloughran commented on pull request #3072: URL: https://github.com/apache/hadoop/pull/3072#issuecomment-1018384368 I pulled in the declaration of the Lists class, so new code can go back without problems -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18088: Labels: pull-request-available (was: ) > Replace log4j 1.x with reload4j >

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=712723=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712723 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3906: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-01-21 Thread GitBox
steveloughran commented on pull request #3906: URL: https://github.com/apache/hadoop/pull/3906#issuecomment-1018383088 I like this. i spent some time last week moving cloudstore to logback. all our modules indirectly publish their dependency on hadoop-common and so whatever logger is

[GitHub] [hadoop] hadoop-yetus commented on pull request #3912: HDFS-13923. Add a configuration to turn on/off observer reads

2022-01-21 Thread GitBox
hadoop-yetus commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1018319686 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?focusedWorklogId=712669=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712669 ] ASF GitHub Bot logged work on HADOOP-18089: --- Author: ASF GitHub Bot

[jira] [Updated] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18089: Labels: pull-request-available (was: ) > Test coverage for Async profiler servlets >

[GitHub] [hadoop] virajjasani opened a new pull request #3913: HADOOP-18089. Test coverage for Async profiler servlets

2022-01-21 Thread GitBox
virajjasani opened a new pull request #3913: URL: https://github.com/apache/hadoop/pull/3913 ### Description of PR As discussed in HADOOP-18077, we should provide sufficient test coverage to discover any potential regression in async profiler servlets: ProfileServlet and

[jira] [Created] (HADOOP-18089) Test coverage for Async profiler servlets

2022-01-21 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-18089: - Summary: Test coverage for Async profiler servlets Key: HADOOP-18089 URL: https://issues.apache.org/jira/browse/HADOOP-18089 Project: Hadoop Common Issue