[GitHub] [hadoop] prasad-acit opened a new pull request, #4162: HDFS-16526. Add metrics for slow DataNode

2022-04-11 Thread GitBox
prasad-acit opened a new pull request, #4162: URL: https://github.com/apache/hadoop/pull/4162 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] tasanuma commented on a diff in pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
tasanuma commented on code in PR #4032: URL: https://github.com/apache/hadoop/pull/4032#discussion_r847973070 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/sps/BlockStorageMovementNeeded.java: ## @@ -248,13 +251,22 @@ public void run()

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4077: HDFS-16509. Fix decommission UnsupportedOperationException

2022-04-11 Thread GitBox
Hexiaoqiao commented on PR #4077: URL: https://github.com/apache/hadoop/pull/4077#issuecomment-1095956053 Thanks @cndaimin for your great catch here. Would you mind to add new unit test to cover this case? Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4077: HDFS-16509. Fix decommission UnsupportedOperationException

2022-04-11 Thread GitBox
Hexiaoqiao commented on PR #4077: URL: https://github.com/apache/hadoop/pull/4077#issuecomment-1095956052 Thanks @cndaimin for your great catch here. Would you mind to add new unit test to cover this case? Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4148: HDFS-16531. Avoid setReplication writing an edit record if old replication equals the new value

2022-04-11 Thread GitBox
Hexiaoqiao commented on code in PR #4148: URL: https://github.com/apache/hadoop/pull/4148#discussion_r847921761 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -2466,11 +2466,12 @@ boolean setReplication(final

[GitHub] [hadoop] liubingxing commented on a diff in pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
liubingxing commented on code in PR #4032: URL: https://github.com/apache/hadoop/pull/4032#discussion_r847908964 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/sps/BlockStorageMovementNeeded.java: ## @@ -248,13 +250,18 @@ public void

[GitHub] [hadoop] jojochuang commented on a diff in pull request #4148: HDFS-16531. Avoid setReplication writing an edit record if old replication equals the new value

2022-04-11 Thread GitBox
jojochuang commented on code in PR #4148: URL: https://github.com/apache/hadoop/pull/4148#discussion_r847906125 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -2466,11 +2466,12 @@ boolean setReplication(final

[GitHub] [hadoop] tasanuma commented on a diff in pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
tasanuma commented on code in PR #4032: URL: https://github.com/apache/hadoop/pull/4032#discussion_r847892437 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/sps/BlockStorageMovementNeeded.java: ## @@ -248,13 +250,18 @@ public void run()

[GitHub] [hadoop] tasanuma commented on a diff in pull request #4138: HDFS-16479. EC: NameNode should not send a reconstruction work when the source datanodes are insufficient

2022-04-11 Thread GitBox
tasanuma commented on code in PR #4138: URL: https://github.com/apache/hadoop/pull/4138#discussion_r847876025 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java: ## @@ -852,6 +852,101 @@ public void

[GitHub] [hadoop] tasanuma commented on pull request #4138: HDFS-16479. EC: NameNode should not send a reconstruction work when the source datanodes are insufficient

2022-04-11 Thread GitBox
tasanuma commented on PR #4138: URL: https://github.com/apache/hadoop/pull/4138#issuecomment-1095814107 @ayushtkn Thanks for your reviews. I update the PR addressing your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] singer-bin commented on pull request #4122: HDFS-16525.System.err should be used when error occurs in multiple methods in DFSAdmin class

2022-04-11 Thread GitBox
singer-bin commented on PR #4122: URL: https://github.com/apache/hadoop/pull/4122#issuecomment-1095802817 ok,thanks @ayushtkn for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] tomscut commented on a diff in pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-04-11 Thread GitBox
tomscut commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r847843114 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1380,8 +1437,9 @@ private static

[GitHub] [hadoop] hadoop-yetus commented on pull request #4161: remove explicit dependency on jackson 1

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4161: URL: https://github.com/apache/hadoop/pull/4161#issuecomment-1095670692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15327?focusedWorklogId=755397=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755397 ] ASF GitHub Bot logged work on HADOOP-15327: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #3259: URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1095473597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4141: HDFS-16534. Split FsDatasetImpl from block pool locks to volume grain locks.

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4141: URL: https://github.com/apache/hadoop/pull/4141#issuecomment-1095460870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] pjfanning opened a new pull request, #4161: remove explicit dependency on jackson 1

2022-04-11 Thread GitBox
pjfanning opened a new pull request, #4161: URL: https://github.com/apache/hadoop/pull/4161 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Updated] (HADOOP-18198) Release Hadoop 3.3.3: hadoop-3.3.2 with somefixes

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18198: Description: Hadoop 3.3.3 is a minor followup release to Hadoop 3.3.2 with * CVE fixes

[jira] [Updated] (HADOOP-18198) Release Hadoop 3.3.3: hadoop-3.3.2 with somefixes

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18198: Summary: Release Hadoop 3.3.3: hadoop-3.3.2 with somefixes (was: Release Hadoop 3.3.3:

[jira] [Updated] (HADOOP-18198) Release Hadoop 3.3.3: hadoop-3.3.2 with somefixes

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18198: Description: Hadoop 3.3.3 is a minor followup release to Hadoop 3.3.2 with * CVE fixes

[GitHub] [hadoop] hadoop-yetus commented on pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4032: URL: https://github.com/apache/hadoop/pull/4032#issuecomment-1095345044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4104: HDFS-16520. Improve EC pread: avoid potential reading whole block

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4104: URL: https://github.com/apache/hadoop/pull/4104#issuecomment-1095344815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4160: HDFS-16537.Fix oev decode xml error

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4160: URL: https://github.com/apache/hadoop/pull/4160#issuecomment-1095317778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18196) Remove replace-guava from replacer plugin

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18196?focusedWorklogId=755322=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755322 ] ASF GitHub Bot logged work on HADOOP-18196: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #4152: HADOOP-18196. Remove replace-guava from replacer plugin

2022-04-11 Thread GitBox
virajjasani commented on PR #4152: URL: https://github.com/apache/hadoop/pull/4152#issuecomment-1095307329 Thank you for the review @steveloughran. Could you please help merge this PR? This change is only meant for trunk, no backport required. -- This is an automated message from the

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-04-11 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r847541480 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java: ## @@ -79,6 +79,8 @@ String

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-04-11 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r847532359 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1380,8 +1437,9 @@ private static

[jira] [Work logged] (HADOOP-15983) Remove the usage of jersey-json to remove jackson 1.x dependency.

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15983?focusedWorklogId=755253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755253 ] ASF GitHub Bot logged work on HADOOP-15983: --- Author: ASF GitHub Bot

[GitHub] [hadoop] pjfanning commented on pull request #3988: [HADOOP-15983] use jersey-json that is built to use jackson2

2022-04-11 Thread GitBox
pjfanning commented on PR #3988: URL: https://github.com/apache/hadoop/pull/3988#issuecomment-1095160613 @aajisaka there is a still a problem with this change - see https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3988/16/artifact/out/patch-mvninstall-root.txt ``` [INFO]

[jira] [Created] (HADOOP-18198) Release Hadoop 3.3.3: hadoop-3.3.2 with CVE fixes

2022-04-11 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18198: --- Summary: Release Hadoop 3.3.3: hadoop-3.3.2 with CVE fixes Key: HADOOP-18198 URL: https://issues.apache.org/jira/browse/HADOOP-18198 Project: Hadoop Common

[jira] [Work logged] (HADOOP-15983) Remove the usage of jersey-json to remove jackson 1.x dependency.

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15983?focusedWorklogId=755226=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755226 ] ASF GitHub Bot logged work on HADOOP-15983: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3988: [HADOOP-15983] use jersey-json that is built to use jackson2

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #3988: URL: https://github.com/apache/hadoop/pull/3988#issuecomment-1095063897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] MingXiangLi commented on pull request #4141: HDFS-16534. Split FsDatasetImpl from block pool locks to volume grain locks.

2022-04-11 Thread GitBox
MingXiangLi commented on PR #4141: URL: https://github.com/apache/hadoop/pull/4141#issuecomment-1095060902 > some method is not frequently and if split to volume lock it have to get locks and release locks sequence.So just acquire block pool lock is enough. -- This is an automated

[jira] [Work logged] (HADOOP-16202) Enhance openFile() for better read performance against object stores

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16202?focusedWorklogId=755223=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755223 ] ASF GitHub Bot logged work on HADOOP-16202: --- Author: ASF GitHub Bot

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #2584: HADOOP-16202. Enhance openFile() for better read performance against object stores

2022-04-11 Thread GitBox
mehakmeet commented on code in PR #2584: URL: https://github.com/apache/hadoop/pull/2584#discussion_r847102156 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/openfile.md: ## @@ -0,0 +1,122 @@ + + +# `FileSystem.openFile()`/`FileContext.openFile()` + +This

[GitHub] [hadoop] MingXiangLi commented on a diff in pull request #4141: HDFS-16534. Split FsDatasetImpl from block pool locks to volume grain locks.

2022-04-11 Thread GitBox
MingXiangLi commented on code in PR #4141: URL: https://github.com/apache/hadoop/pull/4141#discussion_r847329561 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -629,6 +634,9 @@ public void

[GitHub] [hadoop] MingXiangLi commented on a diff in pull request #4141: HDFS-16534. Split FsDatasetImpl from block pool locks to volume grain locks.

2022-04-11 Thread GitBox
MingXiangLi commented on code in PR #4141: URL: https://github.com/apache/hadoop/pull/4141#discussion_r847326503 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -1887,12 +1896,12 @@ public

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520566#comment-17520566 ] Steve Loughran commented on HADOOP-13363: - we've just had HADOOP-18197 reported and the cve  

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520557#comment-17520557 ] Steve Loughran commented on HADOOP-18197: - [~ivan.viaznikov] HADOOP-16557 upgraded our internal

[jira] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197 ] Steve Loughran deleted comment on HADOOP-18197: - was (Author: ste...@apache.org): duplicate of HADOOP-17860   you involvement here would be welcome; the move to shaded versions of the

[jira] [Updated] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18197: Summary: Update protobuf 3.7.1 to a version without CVE-2021-22569 (was: Update the

[jira] [Updated] (HADOOP-17860) Upgrade third party protobuf-java-2.5.0.jar to address vulnerabilities #CVE-2015-5237, CVE-2019-15544,

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17860: Summary: Upgrade third party protobuf-java-2.5.0.jar to address vulnerabilities

[jira] [Reopened] (HADOOP-18197) Update the vulnerable protobuf-java:2.5.0 to a newer version

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-18197: - as the real protobuf jar is vulnerable to the CVE, reopening this and changing the title.

[jira] [Updated] (HADOOP-17860) Upgrade third party protobuf-java-2.5.0.jar to address vulnerabilities #CVE-2015-5237, CVE-2019-15544, CVE-2021-22569

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17860: Summary: Upgrade third party protobuf-java-2.5.0.jar to address vulnerabilities

[jira] [Resolved] (HADOOP-18197) Update the vulnerable protobuf-java:2.5.0 to a newer version

2022-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18197. - Resolution: Duplicate duplicate of HADOOP-17860   you involvement here would be

[GitHub] [hadoop] liubingxing commented on a diff in pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
liubingxing commented on code in PR #4032: URL: https://github.com/apache/hadoop/pull/4032#discussion_r847262936 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/sps/BlockStorageMovementNeeded.java: ## @@ -248,13 +250,18 @@ public void

[GitHub] [hadoop] hadoop-yetus commented on pull request #4151: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4151: URL: https://github.com/apache/hadoop/pull/4151#issuecomment-1094927966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

2022-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=755182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755182 ] ASF GitHub Bot logged work on HADOOP-18088: --- Author: ASF GitHub Bot

[GitHub] [hadoop] GuoPhilipse opened a new pull request, #4160: HDFS-16537.Fix oev decode xml error

2022-04-11 Thread GitBox
GuoPhilipse opened a new pull request, #4160: URL: https://github.com/apache/hadoop/pull/4160 JIRA:HDFS-16537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HADOOP-18197) Update the vulnerable protobuf-java:2.5.0 to a newer version

2022-04-11 Thread Ivan Viaznikov (Jira)
Ivan Viaznikov created HADOOP-18197: --- Summary: Update the vulnerable protobuf-java:2.5.0 to a newer version Key: HADOOP-18197 URL: https://issues.apache.org/jira/browse/HADOOP-18197 Project: Hadoop

[GitHub] [hadoop] hadoop-yetus commented on pull request #4104: HDFS-16520. Improve EC pread: avoid potential reading whole block

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4104: URL: https://github.com/apache/hadoop/pull/4104#issuecomment-1094839139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4159: YARN-10553. Refactor TestDistributedShell (#2581)

2022-04-11 Thread GitBox
hadoop-yetus commented on PR #4159: URL: https://github.com/apache/hadoop/pull/4159#issuecomment-1094810600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-04-11 Thread GitBox
Hexiaoqiao commented on PR #4090: URL: https://github.com/apache/hadoop/pull/4090#issuecomment-1094669958 Committed to trunk. Thanks @GuoPhilipse for your contribution, and thanks @tomscut @cndaimin for your reviews. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] Hexiaoqiao merged pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-04-11 Thread GitBox
Hexiaoqiao merged PR #4090: URL: https://github.com/apache/hadoop/pull/4090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] aajisaka opened a new pull request, #4159: YARN-10553. Refactor TestDistributedShell (#2581)

2022-04-11 Thread GitBox
aajisaka opened a new pull request, #4159: URL: https://github.com/apache/hadoop/pull/4159 (cherry picked from commit 890f2da624465473a5f401a3bcfc4bbd068289a1) Conflicts:

[GitHub] [hadoop] cndaimin commented on pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-04-11 Thread GitBox
cndaimin commented on PR #4090: URL: https://github.com/apache/hadoop/pull/4090#issuecomment-1094619991 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] cndaimin commented on pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-04-11 Thread GitBox
cndaimin commented on PR #4090: URL: https://github.com/apache/hadoop/pull/4090#issuecomment-1094618474 I have some concern on change of API, FsShell also, since some ops-tool might rely on it. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] singer-bin commented on pull request #4156: HDFS-16457.Make fs.getspaceused.classname reconfigurable (apache#4069)

2022-04-11 Thread GitBox
singer-bin commented on PR #4156: URL: https://github.com/apache/hadoop/pull/4156#issuecomment-1094609750 Also thanks to @tasanuma for the review and suggestion, thank you. I also have a jira [16525](https://issues.apache.org/jira/browse/HDFS-16525) I don't know if you are interested in

[jira] [Comment Edited] (HADOOP-18191) Log retry count while handling exceptions in RetryInvocationHandler

2022-04-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520326#comment-17520326 ] Viraj Jasani edited comment on HADOOP-18191 at 4/11/22 6:35 AM: Thank

[jira] [Commented] (HADOOP-18191) Log retry count while handling exceptions in RetryInvocationHandler

2022-04-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520326#comment-17520326 ] Viraj Jasani commented on HADOOP-18191: --- Thank you [~tasanuma] ! > Log retry count while

[GitHub] [hadoop] tasanuma commented on a diff in pull request #4032: HDFS-16484. [SPS]: Fix an infinite loop bug in SPSPathIdProcessor thread

2022-04-11 Thread GitBox
tasanuma commented on code in PR #4032: URL: https://github.com/apache/hadoop/pull/4032#discussion_r846985459 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/sps/BlockStorageMovementNeeded.java: ## @@ -248,13 +250,18 @@ public void run()

[GitHub] [hadoop] cndaimin commented on a diff in pull request #3982: HDFS-16454:fix inconsistent comments in DataNode

2022-04-11 Thread GitBox
cndaimin commented on code in PR #3982: URL: https://github.com/apache/hadoop/pull/3982#discussion_r846984707 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -2227,14 +2227,14 @@ public void shutdown() { // wait

[jira] [Resolved] (HADOOP-18191) Log retry count while handling exceptions in RetryInvocationHandler

2022-04-11 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma resolved HADOOP-18191. --- Fix Version/s: 3.4.0 2.10.2 3.2.4

[jira] [Updated] (HADOOP-17116) Skip Retry INFO logging on first failover from a proxy

2022-04-11 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma updated HADOOP-17116: -- Fix Version/s: 2.10.2 3.2.4 3.3.3 > Skip Retry

[jira] [Commented] (HADOOP-17116) Skip Retry INFO logging on first failover from a proxy

2022-04-11 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520319#comment-17520319 ] Takanobu Asanuma commented on HADOOP-17116: --- This fix is a good improvement, and I'd like to

[GitHub] [hadoop] tasanuma commented on pull request #4156: HDFS-16457.Make fs.getspaceused.classname reconfigurable (apache#4069)

2022-04-11 Thread GitBox
tasanuma commented on PR #4156: URL: https://github.com/apache/hadoop/pull/4156#issuecomment-1094582191 @singer-bin Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to