[GitHub] [hadoop] hadoop-yetus commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148257091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated Annotation

2022-06-06 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550807#comment-17550807 ] Akira Ajisaka commented on HADOOP-18277: -1 I think the deprecation is necessa

[GitHub] [hadoop] slfan1989 commented on pull request #4406: HDFS-16619. impove HttpHeaders.Values And HttpHeaders.Names With recommended Class

2022-06-06 Thread GitBox
slfan1989 commented on PR #4406: URL: https://github.com/apache/hadoop/pull/4406#issuecomment-1148196108 @virajjasani @tomscut Please help me review the code, this part is to replace the deprecated import. There should be no code risk and will not cause junit to fail. -- This is an autom

[GitHub] [hadoop] slfan1989 commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148190628 > That's surprising indeed. One of the recent PRs, I see this test passing: > > 1. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4402/1/testReport/org.apache.hadoop.hd

[GitHub] [hadoop] virajjasani commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
virajjasani commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148188221 That's surprising indeed. One of the recent PRs, I see this test passing: 1. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4402/1/testReport/org.apache.hadoop.hdfs.tools

[jira] [Comment Edited] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated Annotation

2022-06-06 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550793#comment-17550793 ] fanshilun edited comment on HADOOP-18277 at 6/7/22 4:20 AM:

[jira] [Work started] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated Annotation

2022-06-06 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-18277 started by fanshilun. -- > Remove org.apache.hadoop.test#Whitebox Deprecated Annotation > -

[jira] [Commented] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated Annotation

2022-06-06 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550793#comment-17550793 ] fanshilun commented on HADOOP-18277: Hi,[~stev...@iseran.com] ,Is it possible to su

[GitHub] [hadoop] prasad-acit commented on pull request #4241: HDFS-16563. Namenode WebUI prints sensitive information on Token expiry

2022-06-06 Thread GitBox
prasad-acit commented on PR #4241: URL: https://github.com/apache/hadoop/pull/4241#issuecomment-1148171582 Thanks @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Work logged] (HADOOP-18272) replace with HashSet/TreeSet constructor directly in hadoop-yarn-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18272?focusedWorklogId=778825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778825 ] ASF GitHub Bot logged work on HADOOP-18272: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #4411: HADOOP-18272. Removing util.set from yarn project

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4411: URL: https://github.com/apache/hadoop/pull/4411#issuecomment-1148161259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18106) Handle memory fragmentation in S3 Vectored IO implementation.

2022-06-06 Thread Rajesh Balamohan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550781#comment-17550781 ] Rajesh Balamohan commented on HADOOP-18106: --- This will be applicable mainly f

[jira] [Updated] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated Annotation

2022-06-06 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanshilun updated HADOOP-18277: --- Summary: Remove org.apache.hadoop.test#Whitebox Deprecated Annotation (was: Remove org.apache.hado

[jira] [Updated] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated

2022-06-06 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanshilun updated HADOOP-18277: --- Description: org.apache.hadoop.test#Whitebox is marked as deprecated, I personally feel that this i

[jira] [Created] (HADOOP-18277) Remove org.apache.hadoop.test#Whitebox Deprecated

2022-06-06 Thread fanshilun (Jira)
fanshilun created HADOOP-18277: -- Summary: Remove org.apache.hadoop.test#Whitebox Deprecated Key: HADOOP-18277 URL: https://issues.apache.org/jira/browse/HADOOP-18277 Project: Hadoop Common Issue

[jira] [Work logged] (HADOOP-18275) update os-maven-plugin to 1.7.0

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18275?focusedWorklogId=778821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778821 ] ASF GitHub Bot logged work on HADOOP-18275: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #4397: HADOOP-18275. Update os-maven-plugin to 1.7.0

2022-06-06 Thread GitBox
virajjasani commented on PR #4397: URL: https://github.com/apache/hadoop/pull/4397#issuecomment-1148135029 `os-maven-plugin.version` is defined in `hadoop-yarn-csi` pom as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] slfan1989 commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148133845 > Thanks for the PR @slfan1989 Is this test consistently failing or is it more of a flaky one? Hi @virajjasani , This error looks like a consistent failing, I can reproduce it

[GitHub] [hadoop] virajjasani commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
virajjasani commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148130883 Thanks for the PR @slfan1989 Is this test consistently failing or is it more of a flaky one? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hadoop] tomscut commented on pull request #4219: HDFS-16557. BootstrapStandby failed because of checking gap for inprogress EditLogInputStream

2022-06-06 Thread GitBox
tomscut commented on PR #4219: URL: https://github.com/apache/hadoop/pull/4219#issuecomment-1148120968 Hi @jojochuang @tasanuma @Hexiaoqiao , could you please also take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4382: HDFS-16609. Fix Flakes Junit Tests that often report timeouts.

2022-06-06 Thread GitBox
slfan1989 commented on code in PR #4382: URL: https://github.com/apache/hadoop/pull/4382#discussion_r890702393 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java: ## @@ -282,7 +282,7 @@ public void testServerDefaultsWithMinimalCaching()

[GitHub] [hadoop] zhengchenyu commented on pull request #4408: YARN-11172. Fix testDelegationToken

2022-06-06 Thread GitBox
zhengchenyu commented on PR #4408: URL: https://github.com/apache/hadoop/pull/4408#issuecomment-1148102146 @Hexiaoqiao @steveloughran Can you please review the PR? Some unit test fail after HDFS-16563. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tomscut commented on a diff in pull request #4382: HDFS-16609. Fix Flakes Junit Tests that often report timeouts.

2022-06-06 Thread GitBox
tomscut commented on code in PR #4382: URL: https://github.com/apache/hadoop/pull/4382#discussion_r890688840 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java: ## @@ -282,7 +282,7 @@ public void testServerDefaultsWithMinimalCaching() t

[GitHub] [hadoop] slfan1989 commented on pull request #4382: HDFS-16609. Fix Flakes Junit Tests that often report timeouts.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4382: URL: https://github.com/apache/hadoop/pull/4382#issuecomment-1148069751 @tomscut please help me to review the code, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on pull request #4408: YARN-11172. Fix testDelegationToken

2022-06-06 Thread GitBox
slfan1989 commented on PR #4408: URL: https://github.com/apache/hadoop/pull/4408#issuecomment-1148068069 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hadoop] slfan1989 commented on pull request #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4412: URL: https://github.com/apache/hadoop/pull/4412#issuecomment-1148067099 @virajjasani @tomscut please help to review the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [hadoop] slfan1989 opened a new pull request, #4412: HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR.

2022-06-06 Thread GitBox
slfan1989 opened a new pull request, #4412: URL: https://github.com/apache/hadoop/pull/4412 JIRA:HDFS-16624. Fix org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig ERROR. [HDFS-16619](https://issues.apache.org/jira/browse/HDFS-16619) found an error message during Juni

[jira] [Work logged] (HADOOP-18276) Rename CHANGES to CHANGELOG in branch-2.10

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18276?focusedWorklogId=778789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778789 ] ASF GitHub Bot logged work on HADOOP-18276: --- Author: ASF GitHub B

[GitHub] [hadoop] iwasakims commented on pull request #4401: HADOOP-18276. Rename CHANGES to CHANGELOG in branch-2.10.

2022-06-06 Thread GitBox
iwasakims commented on PR #4401: URL: https://github.com/apache/hadoop/pull/4401#issuecomment-1148035103 I merged this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Work logged] (HADOOP-18276) Rename CHANGES to CHANGELOG in branch-2.10

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18276?focusedWorklogId=778788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778788 ] ASF GitHub Bot logged work on HADOOP-18276: --- Author: ASF GitHub B

[GitHub] [hadoop] iwasakims merged pull request #4401: HADOOP-18276. Rename CHANGES to CHANGELOG in branch-2.10.

2022-06-06 Thread GitBox
iwasakims merged PR #4401: URL: https://github.com/apache/hadoop/pull/4401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Work logged] (HADOOP-17833) Improve Magic Committer Performance

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17833?focusedWorklogId=778785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778785 ] ASF GitHub Bot logged work on HADOOP-17833: --- Author: ASF GitHub B

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3289: HADOOP-17833. Improve Magic Committer performance

2022-06-06 Thread GitBox
mukund-thakur commented on code in PR #3289: URL: https://github.com/apache/hadoop/pull/3289#discussion_r890553440 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -1599,69 +1604,88 @@ public FSDataOutputStream create(Path f, FsPermissi

[GitHub] [hadoop] jojochuang merged pull request #4405: HDFS-16595. Slow peer metrics - add median, mad and upper latency limits

2022-06-06 Thread GitBox
jojochuang merged PR #4405: URL: https://github.com/apache/hadoop/pull/4405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[GitHub] [hadoop] hadoop-yetus commented on pull request #4405: HDFS-16595. Slow peer metrics - add median, mad and upper latency limits

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4405: URL: https://github.com/apache/hadoop/pull/4405#issuecomment-1147998733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4406: HDFS-16619. impove HttpHeaders.Values And HttpHeaders.Names With recommended Class

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4406: URL: https://github.com/apache/hadoop/pull/4406#issuecomment-1147982542 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Work logged] (HADOOP-17833) Improve Magic Committer Performance

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17833?focusedWorklogId=778765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778765 ] ASF GitHub Bot logged work on HADOOP-17833: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3289: HADOOP-17833. Improve Magic Committer performance

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #3289: URL: https://github.com/apache/hadoop/pull/3289#issuecomment-1147945670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] KevinWikant commented on pull request #4410: HDFS-16064. Determine when to invalidate corrupt replicas based on number of usable replicas

2022-06-06 Thread GitBox
KevinWikant commented on PR #4410: URL: https://github.com/apache/hadoop/pull/4410#issuecomment-1147944328 The failing unit test is: ``` Failed junit tests | hadoop.hdfs.tools.TestDFSAdmin ``` This seems to be unrelated to my change & a flaky unit test: ``` [ER

[GitHub] [hadoop] hadoop-yetus commented on pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4370: URL: https://github.com/apache/hadoop/pull/4370#issuecomment-1147939325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4370: URL: https://github.com/apache/hadoop/pull/4370#issuecomment-1147917193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4410: HDFS-16064. Determine when to invalidate corrupt replicas based on number of usable replicas

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4410: URL: https://github.com/apache/hadoop/pull/4410#issuecomment-1147898690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18272) replace with HashSet/TreeSet constructor directly in hadoop-yarn-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18272: Labels: pull-request-available (was: ) > replace with HashSet/TreeSet constructor direct

[jira] [Work logged] (HADOOP-18272) replace with HashSet/TreeSet constructor directly in hadoop-yarn-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18272?focusedWorklogId=778738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778738 ] ASF GitHub Bot logged work on HADOOP-18272: --- Author: ASF GitHub B

[GitHub] [hadoop] Samrat002 opened a new pull request, #4411: HADOOP-18272. Removing util.set from yarn project

2022-06-06 Thread GitBox
Samrat002 opened a new pull request, #4411: URL: https://github.com/apache/hadoop/pull/4411 ### Description of PR [HADOOP-18272](https://issues.apache.org/jira/browse/HADOOP-18272) ### How was this patch tested? ### For code changes: - [x] Does the title or

[GitHub] [hadoop] hadoop-yetus commented on pull request #4409: HDFS-16623. Avoid IllegalArgumentException in LifelineSender

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1147767240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18265) replace with HashSet/TreeSet constructor directly in hadoop-hdfs-project

2022-06-06 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550602#comment-17550602 ] Samrat Deb commented on HADOOP-18265: - https://github.com/apache/hadoop/pull/4400

[jira] [Updated] (HADOOP-18265) replace with HashSet/TreeSet constructor directly in hadoop-hdfs-project

2022-06-06 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated HADOOP-18265: Description: Associated PR : [https://github.com/apache/hadoop/pull/4400] Please review  > repla

[GitHub] [hadoop] hadoop-yetus commented on pull request #4408: YARN-11172. Fix testDelegationToken

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4408: URL: https://github.com/apache/hadoop/pull/4408#issuecomment-1147709796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Work logged] (HADOOP-17833) Improve Magic Committer Performance

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17833?focusedWorklogId=778700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778700 ] ASF GitHub Bot logged work on HADOOP-17833: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3289: HADOOP-17833. Improve Magic Committer performance

2022-06-06 Thread GitBox
steveloughran commented on PR #3289: URL: https://github.com/apache/hadoop/pull/3289#issuecomment-1147670480 Wrapping up createFile() with the ability to set headers on the file builder.must("fs.s3a.create.header.my-header","my-value"); this will set a user metadata entry "m

[jira] [Updated] (HADOOP-17740) Set locale for Centos 7 and 8

2022-06-06 Thread Gautham Banasandra (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautham Banasandra updated HADOOP-17740: Description: The locale is set for Ubuntu Focal - https://github.com/apache/hadoo

[GitHub] [hadoop] goiri commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
goiri commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890340126 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890339355 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] hadoop-yetus commented on pull request #4389: HDFS-16576.Remove unused Imports in Hadoop HDFS project

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4389: URL: https://github.com/apache/hadoop/pull/4389#issuecomment-1147657748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] goiri commented on a diff in pull request #4354: YARN-6539. Create SecureLogin inside Router.

2022-06-06 Thread GitBox
goiri commented on code in PR #4354: URL: https://github.com/apache/hadoop/pull/4354#discussion_r890338361 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java: ## @@ -0,0

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890332363 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890332363 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890335244 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.h: ## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache So

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4370: HDFS-16463. Make dirent cross platform compatible

2022-06-06 Thread GitBox
GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r890332363 ## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] slfan1989 commented on pull request #4354: YARN-6539. Create SecureLogin inside Router.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4354: URL: https://github.com/apache/hadoop/pull/4354#issuecomment-1147635731 @zhengchenyu Can this pr guarantee that the router will run for a long time? Is ticket renewa considered? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] slfan1989 closed pull request #4387: HDFS-16611. impove TestSeveralNameNodes#testCircularLinkedListWrites Params

2022-06-06 Thread GitBox
slfan1989 closed pull request #4387: HDFS-16611. impove TestSeveralNameNodes#testCircularLinkedListWrites Params URL: https://github.com/apache/hadoop/pull/4387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [hadoop] slfan1989 commented on pull request #4403: MAPREDUCE-7385. impove JobEndNotifier#httpNotification With recommended methods

2022-06-06 Thread GitBox
slfan1989 commented on PR #4403: URL: https://github.com/apache/hadoop/pull/4403#issuecomment-1147625810 @jojochuang Please help me review the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop] slfan1989 commented on pull request #4375: HDFS-16605. Improve Code With Lambda in hadoop-hdfs-rbf moudle.

2022-06-06 Thread GitBox
slfan1989 commented on PR #4375: URL: https://github.com/apache/hadoop/pull/4375#issuecomment-1147618712 @goiri Please help me review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on pull request #4396: YARN-11159. Support failApplicationAttempt, updateApplicationPriority, updateApplicationTimeouts API's for Federation

2022-06-06 Thread GitBox
slfan1989 commented on PR #4396: URL: https://github.com/apache/hadoop/pull/4396#issuecomment-1147617621 @goiri Please help me review the code again, thank you very much, I will follow up on YARN-10122. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550522#comment-17550522 ] Daniel Carl Jones commented on HADOOP-18273: {quote} i think perhaps the al

[jira] [Work logged] (HADOOP-18266) Replace with HashSet/TreeSet constructor in Hadoop-common-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18266?focusedWorklogId=778647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778647 ] ASF GitHub Bot logged work on HADOOP-18266: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #4365: HADOOP-18266. Using HashSet/ TreeSet Constructor for hadoop-common

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4365: URL: https://github.com/apache/hadoop/pull/4365#issuecomment-1147518404 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Shen Cong (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550502#comment-17550502 ] Shen Cong commented on HADOOP-18273: [~dannycjones] Yeah, i think to treat alias as

[jira] [Work logged] (HADOOP-18271) Remove unused Imports in Hadoop Common project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18271?focusedWorklogId=778640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778640 ] ASF GitHub Bot logged work on HADOOP-18271: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #4392: HADOOP-18271.Remove unused Imports in Hadoop Common project

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4392: URL: https://github.com/apache/hadoop/pull/4392#issuecomment-1147504310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] KevinWikant opened a new pull request, #4410: HDFS-16064. Determine when to invalidate corrupt replicas based on number of usable replicas

2022-06-06 Thread GitBox
KevinWikant opened a new pull request, #4410: URL: https://github.com/apache/hadoop/pull/4410 HDFS-16064. Determine when to invalidate corrupt replicas based on number of usable replicas ### Description of PR Bug fix for a re-occurring HDFS bug which can result in datanodes bei

[jira] [Comment Edited] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550485#comment-17550485 ] Daniel Carl Jones edited comment on HADOOP-18273 at 6/6/22 1:58 PM: -

[jira] [Comment Edited] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550485#comment-17550485 ] Daniel Carl Jones edited comment on HADOOP-18273 at 6/6/22 1:58 PM: -

[jira] [Comment Edited] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550485#comment-17550485 ] Daniel Carl Jones edited comment on HADOOP-18273 at 6/6/22 1:54 PM: -

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Shen Cong (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550486#comment-17550486 ] Shen Cong commented on HADOOP-18273: [~dannycjones] Hi Daniel, i think perhaps the

[jira] [Comment Edited] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550485#comment-17550485 ] Daniel Carl Jones edited comment on HADOOP-18273 at 6/6/22 1:54 PM: -

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550485#comment-17550485 ] Daniel Carl Jones commented on HADOOP-18273: My question is why is any expl

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Shen Cong (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550479#comment-17550479 ] Shen Cong commented on HADOOP-18273: Yes i think it works well too, my only concern

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550475#comment-17550475 ] Daniel Carl Jones commented on HADOOP-18273: As I understood it, the S3 Acc

[jira] [Commented] (HADOOP-18273) Support S3 access point alias

2022-06-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550463#comment-17550463 ] Steve Loughran commented on HADOOP-18273: - why can;t we just have the arn optio

[jira] [Resolved] (HADOOP-18275) update os-maven-plugin to 1.7.0

2022-06-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18275. - Fix Version/s: 3.3.4 Resolution: Fixed > update os-maven-plugin to 1.7.0 > -

[GitHub] [hadoop] ZanderXu opened a new pull request, #4409: HDFS-16623. Avoid IllegalArgumentException in LifelineSender

2022-06-06 Thread GitBox
ZanderXu opened a new pull request, #4409: URL: https://github.com/apache/hadoop/pull/4409 Jira: [HDFS-16623](https://issues.apache.org/jira/browse/HDFS-16623), fix bug to avoid IllegalArgumentException in LifelineSender. In our production environment, an IllegalArgumentException occ

[jira] [Work logged] (HADOOP-18275) update os-maven-plugin to 1.7.0

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18275?focusedWorklogId=778591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778591 ] ASF GitHub Bot logged work on HADOOP-18275: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran merged pull request #4397: HADOOP-18275. Update os-maven-plugin to 1.7.0

2022-06-06 Thread GitBox
steveloughran merged PR #4397: URL: https://github.com/apache/hadoop/pull/4397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] zhengchenyu opened a new pull request, #4408: YARN-11172. Fix testDelegationToken

2022-06-06 Thread GitBox
zhengchenyu opened a new pull request, #4408: URL: https://github.com/apache/hadoop/pull/4408 ### Description of PR UT fail after [HDFS-16563], other yarn PR is blocked. ``` [ERROR] testDelegationToken(org.apache.hadoop.yarn.server.resourcemanager.TestClientRMTokens) Time

[GitHub] [hadoop] hadoop-yetus commented on pull request #4407: HDFS-16622. addRDBI in IncrementalBlockReportManager may remove the b…

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4407: URL: https://github.com/apache/hadoop/pull/4407#issuecomment-1147344802 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] zhengchenyu closed pull request #4314: YARN-11153. Make proxy server support yarn federation.

2022-06-06 Thread GitBox
zhengchenyu closed pull request #4314: YARN-11153. Make proxy server support yarn federation. URL: https://github.com/apache/hadoop/pull/4314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Work logged] (HADOOP-18266) Replace with HashSet/TreeSet constructor in Hadoop-common-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18266?focusedWorklogId=778569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778569 ] ASF GitHub Bot logged work on HADOOP-18266: --- Author: ASF GitHub B

[GitHub] [hadoop] Samrat002 commented on a diff in pull request #4365: HADOOP-18266. Using HashSet/ TreeSet Constructor for hadoop-common

2022-06-06 Thread GitBox
Samrat002 commented on code in PR #4365: URL: https://github.com/apache/hadoop/pull/4365#discussion_r890013938 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java: ## @@ -1442,7 +1441,7 @@ public static void destroyAllShellProcesses() { */

[GitHub] [hadoop] hadoop-yetus commented on pull request #4402: HDFS-16618. sync_file_range error should include more volume/file info

2022-06-06 Thread GitBox
hadoop-yetus commented on PR #4402: URL: https://github.com/apache/hadoop/pull/4402#issuecomment-1147286805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] aajisaka merged pull request #4379: HDFS-16608. Fix the link in the doc to point correct function

2022-06-06 Thread GitBox
aajisaka merged PR #4379: URL: https://github.com/apache/hadoop/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Work logged] (HADOOP-18266) Replace with HashSet/TreeSet constructor in Hadoop-common-project

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18266?focusedWorklogId=778553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778553 ] ASF GitHub Bot logged work on HADOOP-18266: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4365: HADOOP-18266. Using HashSet/ TreeSet Constructor for hadoop-common

2022-06-06 Thread GitBox
aajisaka commented on code in PR #4365: URL: https://github.com/apache/hadoop/pull/4365#discussion_r889951385 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java: ## @@ -1442,7 +1441,7 @@ public static void destroyAllShellProcesses() { */

[GitHub] [hadoop] aajisaka commented on pull request #4389: HDFS-16576.Remove unused Imports in Hadoop HDFS project

2022-06-06 Thread GitBox
aajisaka commented on PR #4389: URL: https://github.com/apache/hadoop/pull/4389#issuecomment-1147199575 The change looks good to me. Rerun the precommit job to verify it can compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hadoop] aajisaka commented on pull request #4389: HDFS-16576.Remove unused Imports in Hadoop HDFS project

2022-06-06 Thread GitBox
aajisaka commented on PR #4389: URL: https://github.com/apache/hadoop/pull/4389#issuecomment-1147198550 The change looks good to me. Rerun the precommit job to verify it can compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Work logged] (HADOOP-18276) Rename CHANGES to CHANGELOG in branch-2.10

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18276?focusedWorklogId=778548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778548 ] ASF GitHub Bot logged work on HADOOP-18276: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4393: YARN-9827.Fix Http Response code in GenericExceptionHandler

2022-06-06 Thread GitBox
aajisaka commented on code in PR #4393: URL: https://github.com/apache/hadoop/pull/4393#discussion_r889940958 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/GenericExceptionHandler.java: ## @@ -94,7 +94,7 @@ public Response toRe

[GitHub] [hadoop] ashutoshcipher commented on pull request #4401: HADOOP-18276. Rename CHANGES to CHANGELOG in branch-2.10.

2022-06-06 Thread GitBox
ashutoshcipher commented on PR #4401: URL: https://github.com/apache/hadoop/pull/4401#issuecomment-1147196207 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hadoop] zhengchenyu commented on pull request #4354: YARN-6539. Create SecureLogin inside Router.

2022-06-06 Thread GitBox
zhengchenyu commented on PR #4354: URL: https://github.com/apache/hadoop/pull/4354#issuecomment-1147159029 @goiri I fix it, and rebase it. And I add some test which will verify ugi. Can you help review this PR? Thanks again. -- This is an automated message from the Apache Git Service.

  1   2   >