xinglin commented on PR #4872:
URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1272459124
Hi @ZanderXu,
I understand what you tried to do now. The first
`checkOperation(OperationCategory.WRITE)` call will throw a
`RetryOnActiveException` on an observerNN.
Are
xinglin commented on code in PR #4872:
URL: https://github.com/apache/hadoop/pull/4872#discussion_r990733465
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRpcServer.java:
##
@@ -158,6 +164,49 @@ public void
ZanderXu commented on code in PR #4750:
URL: https://github.com/apache/hadoop/pull/4750#discussion_r990721289
##
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java:
##
@@ -73,39 +102,15 @@
import
ZanderXu commented on PR #4872:
URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1272433724
> Hi @ZanderXu,
>
> I am not clear what exactly you are trying to achieve here. Are you trying
to enable observerNodes to handle addBlock RPC from clients? I believe addBlock
is
xinglin commented on PR #4872:
URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1272415229
Hi @ZanderXu,
I am not clear what exactly you are trying to achieve here. Are you trying
to enable observerNodes to handle addBlock RPC from clients? I believe addBlock
is an
hadoop-yetus commented on PR #4987:
URL: https://github.com/apache/hadoop/pull/4987#issuecomment-1272383474
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4968:
URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1272366371
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu commented on PR #4987:
URL: https://github.com/apache/hadoop/pull/4987#issuecomment-1272346518
> Congratulations on your promotion to committer, very good!
@slfan1989 Thanks, bro. You will get a promotion soon.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614499#comment-17614499
]
ASF GitHub Bot commented on HADOOP-18360:
-
slfan1989 commented on PR #4928:
URL:
slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1272339219
@ayushtkn Can you help review this pr? I think an upgrade is still
necessary. For the deprecated method, I also made a replacement.
--
This is an automated message from the Apache Git
slfan1989 commented on PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1272338733
@9uapaw Thank you very much for your suggestion, I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
slfan1989 commented on PR #4982:
URL: https://github.com/apache/hadoop/pull/4982#issuecomment-1272337601
@goiri Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
slfan1989 commented on PR #4987:
URL: https://github.com/apache/hadoop/pull/4987#issuecomment-1272331099
@ZanderXu Congratulations on your promotion to committer, very good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hadoop-yetus commented on PR #4941:
URL: https://github.com/apache/hadoop/pull/4941#issuecomment-1272329041
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
9uapaw commented on PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1272312993
Hi @slfan1989, thanks for the patch! I think this should be hidden behind a
config flag, and should be opt-in (false by default). Metrics aggregation often
causes performance degradation.
susheel-gupta commented on code in PR #4941:
URL: https://github.com/apache/hadoop/pull/4941#discussion_r990636469
##
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java:
##
@@ -105,7 +108,11 @@ public boolean tryCommit(Resource
hadoop-yetus commented on PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1272305412
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu opened a new pull request, #4987:
URL: https://github.com/apache/hadoop/pull/4987
### Description of PR
During looking into some code related XATTR, I found there is a bug in
SerialNumberMap, as bellow:
```
public int get(T t) {
if (t == null) {
return 0;
ashutoshcipher commented on PR #4750:
URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1272297083
Hi @ZanderXu - Can you please help in reviewing ? Thank you so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ashutoshcipher commented on PR #4750:
URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1272296766
> hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem
Is passing in local. Will trigger jenkins once again after getting current
code being reviewed
--
This is an
hadoop-yetus commented on PR #4967:
URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1272286436
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
K0K0V0K commented on PR #4949:
URL: https://github.com/apache/hadoop/pull/4949#issuecomment-1272264656
I think there should be at least one test in the TestLinuxContainerExecutor,
what will check in case of an error the app will return with a not -1 error
code.
--
This is an automated
hadoop-yetus commented on PR #4967:
URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1272263575
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1272244531
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4976:
URL: https://github.com/apache/hadoop/pull/4976#issuecomment-1272242696
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
25 matches
Mail list logo
