[jira] [Commented] (HADOOP-18671) Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715229#comment-17715229 ] ASF GitHub Bot commented on HADOOP-18671: - hadoop-yetus commented on PR #5553: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5553: HADOOP-18671 Add recoverLease(), setSafeMode(), isFileClosed() as interfaces to hadoop-common

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5553: URL: https://github.com/apache/hadoop/pull/5553#issuecomment-1518520447 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.3.

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715228#comment-17715228 ] ASF GitHub Bot commented on HADOOP-18359: - hadoop-yetus commented on PR #5095: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.5.

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1518515619 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715219#comment-17715219 ] ASF GitHub Bot commented on HADOOP-18660: - hadoop-yetus commented on PR #5475: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1518495114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhtttylz commented on a diff in pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
zhtttylz commented on code in PR #5572: URL: https://github.com/apache/hadoop/pull/5572#discussion_r1174273765 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception {

[jira] [Commented] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715216#comment-17715216 ] ASF GitHub Bot commented on HADOOP-18697: - hadoop-yetus commented on PR #5580: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5580: HADOOP-18697. Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5580: URL: https://github.com/apache/hadoop/pull/5580#issuecomment-1518477070 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18711) upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715212#comment-17715212 ] ASF GitHub Bot commented on HADOOP-18711: - hadoop-yetus commented on PR #5573: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5573: HADOOP-18711 upgrade to nimbus jwt 9.31

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5573: URL: https://github.com/apache/hadoop/pull/5573#issuecomment-1518447330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715211#comment-17715211 ] ASF GitHub Bot commented on HADOOP-18697: - virajjasani commented on PR #5580: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5580: HADOOP-18697. Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread via GitHub
virajjasani commented on PR #5580: URL: https://github.com/apache/hadoop/pull/5580#issuecomment-1518444225 `us-west-2`: ``` $ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch $ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale ```

[jira] [Assigned] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18697: - Assignee: Viraj Jasani > Fix transient failure of >

[jira] [Updated] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18697: Labels: pull-request-available (was: ) > Fix transient failure of >

[jira] [Commented] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715184#comment-17715184 ] ASF GitHub Bot commented on HADOOP-18697: - virajjasani opened a new pull request, #5580: URL:

[GitHub] [hadoop] virajjasani opened a new pull request, #5580: HADOOP-18697. Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread via GitHub
virajjasani opened a new pull request, #5580: URL: https://github.com/apache/hadoop/pull/5580 - Eventual assertions - Update prefetch iostats only after updating blocks map with new entry -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (HADOOP-18697) Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18697: -- Summary: Fix transient failure of ITestS3APrefetchingInputStream#testRandomReadLargeFile

[jira] [Commented] (HADOOP-18697) transient failure of ITestS3APrefetchingInputStream.testRandomReadLargeFile

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715181#comment-17715181 ] Viraj Jasani commented on HADOOP-18697: --- While using eventual assertions is good idea, but it is

[jira] [Comment Edited] (HADOOP-18688) s3a audit info to include #of items in a DeleteObjects request

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714703#comment-17714703 ] Viraj Jasani edited comment on HADOOP-18688 at 4/21/23 9:25 PM: As far

[GitHub] [hadoop] hadoop-yetus commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1518344185 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
simbadzina commented on code in PR #5572: URL: https://github.com/apache/hadoop/pull/5572#discussion_r1174123604 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception

[jira] [Commented] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715154#comment-17715154 ] ASF GitHub Bot commented on HADOOP-18714: - ayushtkn commented on code in PR #5578: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5578: HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread via GitHub
ayushtkn commented on code in PR #5578: URL: https://github.com/apache/hadoop/pull/5578#discussion_r1174108029 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java: ## @@ -197,7 +197,7 @@ public void

[jira] [Resolved] (HADOOP-18710) Add RPC metrics for response time

2023-04-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18710. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Add RPC

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

2023-04-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715152#comment-17715152 ] Ayush Saxena commented on HADOOP-18710: --- Committed to trunk. Thanx [~liuguanghua] for the

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715150#comment-17715150 ] ASF GitHub Bot commented on HADOOP-18710: - ayushtkn merged PR #5545: URL:

[GitHub] [hadoop] ayushtkn merged pull request #5545: HADOOP-18710. Add RPC metrics for response time

2023-04-21 Thread via GitHub
ayushtkn merged PR #5545: URL: https://github.com/apache/hadoop/pull/5545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (HADOOP-18710) Add RPC metrics for response time

2023-04-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18710: - Assignee: liuguanghua > Add RPC metrics for response time >

[jira] [Commented] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715141#comment-17715141 ] ASF GitHub Bot commented on HADOOP-18714: - ayushtkn commented on code in PR #5578: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5578: HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread via GitHub
ayushtkn commented on code in PR #5578: URL: https://github.com/apache/hadoop/pull/5578#discussion_r1174097084 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java: ## @@ -197,7 +197,7 @@ public void

[jira] [Commented] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715140#comment-17715140 ] ASF GitHub Bot commented on HADOOP-18714: - steveloughran commented on PR #5578: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5578: HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread via GitHub
steveloughran commented on PR #5578: URL: https://github.com/apache/hadoop/pull/5578#issuecomment-1518247144 what about moving it to an assertj assert, something like ``` Assert.assertThat(fs.listStatus(root)) .describedAs("ls /") .hasSize(0) ``` -- This

[GitHub] [hadoop] virajjasani commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-21 Thread via GitHub
virajjasani commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1518245825 Thanks @simbadzina, addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5519: URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1518223814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715124#comment-17715124 ] ASF GitHub Bot commented on HADOOP-18706: - hadoop-yetus commented on PR #5563: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1518185036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-21 Thread via GitHub
simbadzina commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1174047769 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -132,15 +135,15 @@ public void printUsage() {

[GitHub] [hadoop] umamaheswararao commented on pull request #5532: HDFS-16972. Delete a snapshot may deleteCurrentFile.

2023-04-21 Thread via GitHub
umamaheswararao commented on PR #5532: URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1518177291 We had offline discussion on the above comments. The CURRENT_STATE_ID was coming because it tries to check until CURRENT_STATE_ID. This fix is basically keeping the given

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

2023-04-21 Thread via GitHub
simbadzina commented on code in PR #5552: URL: https://github.com/apache/hadoop/pull/5552#discussion_r1174022112 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestNamenodeAuditlogWithDFSRouterPort.java: ## @@ -0,0 +1,91 @@

[jira] [Commented] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715110#comment-17715110 ] ASF GitHub Bot commented on HADOOP-18714: - hadoop-yetus commented on PR #5578: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5578: HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5578: URL: https://github.com/apache/hadoop/pull/5578#issuecomment-1518149214 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-21 Thread via GitHub
simbadzina commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1173987391 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableManager.java: ## @@ -48,6 +50,17 @@ public interface

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1518123299 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715097#comment-17715097 ] ASF GitHub Bot commented on HADOOP-18565: - hadoop-yetus commented on PR #5421: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1518113204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715092#comment-17715092 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn commented on PR #5502: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-21 Thread via GitHub
ayushtkn commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1518101777 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5579: MAPREDUCE-7437. spotbugs complains about MR Fetcher class.

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5579: URL: https://github.com/apache/hadoop/pull/5579#issuecomment-1518066768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715034#comment-17715034 ] ASF GitHub Bot commented on HADOOP-18706: - cbevard1 commented on PR #5563: URL:

[GitHub] [hadoop] cbevard1 commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

2023-04-21 Thread via GitHub
cbevard1 commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1517915320 > minor: checkstyle unhappy about line length...please keep at 100 chars or less No problem, will do. > How about adding a new test case or modifying testRegularUpload() to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1517912772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715031#comment-17715031 ] ASF GitHub Bot commented on HADOOP-18689: - hadoop-yetus commented on PR #5502: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1517912431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran opened a new pull request, #5579: MAPREDUCE-7437. spotbugs complains about MR Fetcher class.

2023-04-21 Thread via GitHub
steveloughran opened a new pull request, #5579: URL: https://github.com/apache/hadoop/pull/5579 ### Description of PR Move to an atomic integer. ### How was this patch tested? yetus's homework ### For code changes: - [X] Does the title or this

[jira] [Updated] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18714: Labels: pull-request-available (was: ) > Wrong StringUtils.join() called in

[jira] [Commented] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715025#comment-17715025 ] ASF GitHub Bot commented on HADOOP-18714: - adoroszlai opened a new pull request, #5578: URL:

[GitHub] [hadoop] adoroszlai opened a new pull request, #5578: HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread via GitHub
adoroszlai opened a new pull request, #5578: URL: https://github.com/apache/hadoop/pull/5578 ## What changes were proposed in this pull request? Fix assertion message in `AbstractContractRootDirectoryTest` by calling `join(Object[], String)` instead of `join(T...)` (where `T` was

[jira] [Created] (HADOOP-18714) Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

2023-04-21 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HADOOP-18714: - Summary: Wrong StringUtils.join() called in AbstractContractRootDirectoryTest Key: HADOOP-18714 URL: https://issues.apache.org/jira/browse/HADOOP-18714

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714981#comment-17714981 ] ASF GitHub Bot commented on HADOOP-18706: - steveloughran commented on PR #5563: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

2023-04-21 Thread via GitHub
steveloughran commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1517764238 looks good, just two issues to worry about minor: checkstyle unhappy about line length...please keep at 100 chars or less One bigger issue, which you already mentioned:

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714980#comment-17714980 ] ASF GitHub Bot commented on HADOOP-18565: - steveloughran commented on PR #5421: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

2023-04-21 Thread via GitHub
steveloughran commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1517736384 spotbugs is happy; deprecation warnings file...all that is left is to get the name of the new method right -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] ashutoshcipher commented on pull request #5562: YARN-11463. Node Labels root directory creation doesn't have a retry logic

2023-04-21 Thread via GitHub
ashutoshcipher commented on PR #5562: URL: https://github.com/apache/hadoop/pull/5562#issuecomment-1517735733 Thanks @brumi1024 for review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714978#comment-17714978 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-21 Thread via GitHub
steveloughran commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1517733567 can we get this in while I work on other things? I am done here and have to get back to the rest of my todo list -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714975#comment-17714975 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-21 Thread via GitHub
steveloughran commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1517730579 Tested s3 london; I'm now playing with both prefetch and non-prefetching test runs. At least with my local test setup, its a bit slower with -Dprefetch, but remember these

[GitHub] [hadoop] brumi1024 commented on pull request #5562: YARN-11463. Node Labels root directory creation doesn't have a retry logic

2023-04-21 Thread via GitHub
brumi1024 commented on PR #5562: URL: https://github.com/apache/hadoop/pull/5562#issuecomment-1517719022 Thanks @ashutoshcipher for the patch, merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] brumi1024 merged pull request #5562: YARN-11463. Node Labels root directory creation doesn't have a retry logic

2023-04-21 Thread via GitHub
brumi1024 merged PR #5562: URL: https://github.com/apache/hadoop/pull/5562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18697) transient failure of ITestS3APrefetchingInputStream.testRandomReadLargeFile

2023-04-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714959#comment-17714959 ] Ayush Saxena commented on HADOOP-18697: --- Just passing by, the exception changed btw. In the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1517679805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1517668480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714943#comment-17714943 ] ASF GitHub Bot commented on HADOOP-18660: - ayushtkn commented on PR #5475: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-21 Thread via GitHub
ayushtkn commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1517657908 That error seems to say like you changed the class name but not the file name. Just fix the checkstyle warning and we should be good to go -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1517636692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18697) transient failure of ITestS3APrefetchingInputStream.testRandomReadLargeFile

2023-04-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714932#comment-17714932 ] Steve Loughran commented on HADOOP-18697: - proposed changes * log iostats before the asserts *

[jira] [Commented] (HADOOP-18697) transient failure of ITestS3APrefetchingInputStream.testRandomReadLargeFile

2023-04-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714931#comment-17714931 ] Steve Loughran commented on HADOOP-18697: - spotted again. {code} [ERROR]

[jira] [Updated] (HADOOP-18179) Boost S3A Stream Read Performance

2023-04-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18179: Summary: Boost S3A Stream Read Performance (was: Boost S3A Stream Read Performance with

[GitHub] [hadoop] zhtttylz commented on a diff in pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
zhtttylz commented on code in PR #5572: URL: https://github.com/apache/hadoop/pull/5572#discussion_r1173598854 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception {

[jira] [Updated] (HADOOP-18179) Boost S3A Stream Read Performance with prefetching and caching

2023-04-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18179: Summary: Boost S3A Stream Read Performance with prefetching and caching (was: Boost S3A

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714929#comment-17714929 ] ASF GitHub Bot commented on HADOOP-18660: - Baunsgaard commented on PR #5475: URL:

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-21 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1517600783 Okay, maybe i was to quick again...

[GitHub] [hadoop] ayushtkn commented on pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
ayushtkn commented on PR #5572: URL: https://github.com/apache/hadoop/pull/5572#issuecomment-1517600636 I will do that, do create a ticket for httpfs as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] zhtttylz commented on pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
zhtttylz commented on PR #5572: URL: https://github.com/apache/hadoop/pull/5572#issuecomment-1517595399 @ayushtkn Thank you very much for reviewing the code! `HttpFS` and `WebHDFS` are not part of the same module. I plan to create a separate Jira ticket to complete this functionality.

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714912#comment-17714912 ] ASF GitHub Bot commented on HADOOP-18660: - ayushtkn commented on PR #5475: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-21 Thread via GitHub
ayushtkn commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1517549337 Can you pass me the link or atleast attach a screenshot where Yetus is complaining about the file name change? I am not able to follow that. The only complain I see is around

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-21 Thread via GitHub
ayushtkn commented on code in PR #5572: URL: https://github.com/apache/hadoop/pull/5572#discussion_r1173553320 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception {

[jira] [Assigned] (HADOOP-18711) upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code

2023-04-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18711: - Assignee: PJ Fanning > upgrade nimbus jwt jar due to issues in its embedded shaded

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714901#comment-17714901 ] ASF GitHub Bot commented on HADOOP-18710: - ayushtkn commented on code in PR #5545: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5545: HADOOP-18710. Add RPC metrics for response time

2023-04-21 Thread via GitHub
ayushtkn commented on code in PR #5545: URL: https://github.com/apache/hadoop/pull/5545#discussion_r1173538662 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java: ## @@ -282,6 +290,15 @@ public void addRpcProcessingTime(long

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.3.

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714897#comment-17714897 ] ASF GitHub Bot commented on HADOOP-18359: - ayushtkn commented on PR #5095: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.3.

2023-04-21 Thread via GitHub
ayushtkn commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1517520592 If possible please keep the refactor separate if it isn't required for 1.5 upgrade, and we can merge both of them separately -- This is an automated message from the Apache Git

[GitHub] [hadoop] yl09099 opened a new pull request, #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-21 Thread via GitHub
yl09099 opened a new pull request, #5577: URL: https://github.com/apache/hadoop/pull/5577 YARN-11474.The yarn queue list is displayed on the CLI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-18694) Client.Connection#updateAddress needs to ensure that address is resolved before updating

2023-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714840#comment-17714840 ] ASF GitHub Bot commented on HADOOP-18694: - hadoop-yetus commented on PR #5542: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5542: HADOOP-18694. Client.Connection#updateAddress needs to ensure that address is resolved before updating

2023-04-21 Thread via GitHub
hadoop-yetus commented on PR #5542: URL: https://github.com/apache/hadoop/pull/5542#issuecomment-1517351542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |