slfan1989 commented on code in PR #5565:
URL: https://github.com/apache/hadoop/pull/5565#discussion_r1178658969
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##
slfan1989 commented on code in PR #5565:
URL: https://github.com/apache/hadoop/pull/5565#discussion_r1178657862
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##
cxzl25 opened a new pull request, #5599:
URL: https://github.com/apache/hadoop/pull/5599
### Description of PR
NodeManager has two dispatchers, we can add metrics to observe the
dispatcher queue size.
### How was this patch tested?
### For code changes:
- [ ]
hadoop-yetus commented on PR #5598:
URL: https://github.com/apache/hadoop/pull/5598#issuecomment-1524696999
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5577:
URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1524688841
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5577:
URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1524684886
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5593:
URL: https://github.com/apache/hadoop/pull/5593#issuecomment-1524651963
>
we can reproduce this case by execute `hdfs dfs -setrep 3 /largedir` on a
large capacity dir(1.0PB) with replication factor 2.
--
This is an automated message from the
simbadzina commented on PR #5598:
URL: https://github.com/apache/hadoop/pull/5598#issuecomment-1524561408
There are still 3 unresolved checkstyle issues. Since this PR is to clean-up
checkstyle errors, we shouldn't introduce new one.
slfan1989 commented on code in PR #5596:
URL: https://github.com/apache/hadoop/pull/5596#discussion_r1178561074
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
slfan1989 commented on PR #5577:
URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1524470331
@yl09099 Thanks for your contribution! merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/HADOOP-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716935#comment-17716935
]
ASF GitHub Bot commented on HADOOP-18603:
-
simbadzina commented on PR #5581:
URL:
simbadzina commented on PR #5581:
URL: https://github.com/apache/hadoop/pull/5581#issuecomment-1524300983
Could you please add a unit test that fails without your change and passes
with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716891#comment-17716891
]
ASF GitHub Bot commented on HADOOP-18706:
-
hadoop-yetus commented on PR #5563:
URL:
hadoop-yetus commented on PR #5563:
URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1523955619
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #5596:
URL: https://github.com/apache/hadoop/pull/5596#discussion_r1178310665
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
hadoop-yetus commented on PR #5332:
URL: https://github.com/apache/hadoop/pull/5332#issuecomment-1523887426
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716847#comment-17716847
]
ASF GitHub Bot commented on HADOOP-18706:
-
cbevard1 commented on code in PR #5563:
URL:
cbevard1 commented on code in PR #5563:
URL: https://github.com/apache/hadoop/pull/5563#discussion_r1178227622
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABlockOutputArray.java:
##
@@ -79,6 +80,42 @@ public void testRegularUpload() throws
[
https://issues.apache.org/jira/browse/HADOOP-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716843#comment-17716843
]
Steve Loughran commented on HADOOP-18703:
-
feature branch has all the commits that I think are
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716841#comment-17716841
]
Steve Loughran commented on HADOOP-18291:
-
something in the storecontext should
[
https://issues.apache.org/jira/browse/HADOOP-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18283:
Description:
Need to review S3A prefetching stream retry logic
* no attempt to retry on
[
https://issues.apache.org/jira/browse/HADOOP-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18283:
Summary: Review s3a prefetching input stream retry code; synchronization
(was: Review
[
https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716831#comment-17716831
]
ASF GitHub Bot commented on HADOOP-18697:
-
steveloughran commented on code in PR #5580:
URL:
steveloughran commented on code in PR #5580:
URL: https://github.com/apache/hadoop/pull/5580#discussion_r1178178480
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java:
##
@@ -202,13 +203,31 @@ public void
hadoop-yetus commented on PR #5596:
URL: https://github.com/apache/hadoop/pull/5596#issuecomment-1523750376
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
virajjasani commented on PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1523700673
javadoc warnings are not for patch code, they are only for generated proto
code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hadoop-yetus commented on PR #5594:
URL: https://github.com/apache/hadoop/pull/5594#issuecomment-1523688163
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1523685056
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5583:
URL: https://github.com/apache/hadoop/pull/5583#issuecomment-1523678996
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5591:
URL: https://github.com/apache/hadoop/pull/5591#issuecomment-1523677733
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5594:
URL: https://github.com/apache/hadoop/pull/5594#issuecomment-1523673141
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716784#comment-17716784
]
ASF GitHub Bot commented on HADOOP-18718:
-
dongjoon-hyun commented on PR #5592:
URL:
dongjoon-hyun commented on PR #5592:
URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1523661404
Ya, I thought like that. Thank you, @steveloughran and @ayushtkn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dmmkr commented on PR #22:
URL: https://github.com/apache/hadoop-thirdparty/pull/22#issuecomment-1523658895
Hadoop trunk build is successful with guava-31.1-hadoop-thirdparty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716781#comment-17716781
]
ASF GitHub Bot commented on HADOOP-18695:
-
hadoop-yetus commented on PR #5548:
URL:
hadoop-yetus commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1523654004
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1523650228
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5593:
URL: https://github.com/apache/hadoop/pull/5593#issuecomment-1523544877
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Mehakmeet Singh created HADOOP-18722:
Summary: Optimise S3A delete objects when multiObjectDelete is
disabled
Key: HADOOP-18722
URL: https://issues.apache.org/jira/browse/HADOOP-18722
Project:
hadoop-yetus commented on PR #5594:
URL: https://github.com/apache/hadoop/pull/5594#issuecomment-1523492794
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5594:
URL: https://github.com/apache/hadoop/pull/5594#issuecomment-1523489130
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18721:
Labels: pull-request-available (was: )
> Upgrade guava to 31.1
> -
dmmkr opened a new pull request, #22:
URL: https://github.com/apache/hadoop-thirdparty/pull/22
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number.
D M Murali Krishna Reddy created HADOOP-18721:
-
Summary: Upgrade guava to 31.1
Key: HADOOP-18721
URL: https://issues.apache.org/jira/browse/HADOOP-18721
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716740#comment-17716740
]
ASF GitHub Bot commented on HADOOP-18695:
-
steveloughran commented on PR #5548:
URL:
steveloughran commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1523468362
one more checkstyle update; full test run of ` -Dparallel-tests
-DtestsThreadCount=8 -Dscale` against s3 london. all good
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716721#comment-17716721
]
ASF GitHub Bot commented on HADOOP-18565:
-
steveloughran commented on PR #5421:
URL:
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1523433345
oh, and based some other changes, spotbugs warning about extant spotbugs
doesn't mean you've added a new one, just that there is one to get rid of.
yetus can still warn there even
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716720#comment-17716720
]
ASF GitHub Bot commented on HADOOP-18695:
-
steveloughran commented on PR #5548:
URL:
steveloughran commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1523430441
checkstyle still unhappy. the file length one is something i can ignore for
a test case, but I will improve it slightly anyway. a lot of the lines are just
multiline assertj
steveloughran commented on PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1523419702
latest patch tested against azure cardiff, timeout unrelated
```
[ERROR] Errors:
[ERROR]
[
https://issues.apache.org/jira/browse/HADOOP-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena updated HADOOP-18712:
--
Fix Version/s: 3.3.9
> Upgrade to jetty 9.4.51 due to cve
>
ayushtkn merged PR #5585:
URL: https://github.com/apache/hadoop/pull/5585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ayushtkn commented on PR #5585:
URL: https://github.com/apache/hadoop/pull/5585#issuecomment-1523412130
Failing tests passed locally
```
[INFO] ---
[INFO] T E S T S
[INFO] ---
hadoop-yetus commented on PR #5598:
URL: https://github.com/apache/hadoop/pull/5598#issuecomment-1523393115
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716709#comment-17716709
]
ASF GitHub Bot commented on HADOOP-18718:
-
ayushtkn commented on PR #5592:
URL:
ayushtkn commented on PR #5592:
URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1523387368
Should be good, if the build doesn't complain. The findbug thing looks like
a leftover to me. We don't run neither setup findbugs now in our jenkins job,
we just run spotbugs
hadoop-yetus commented on PR #5596:
URL: https://github.com/apache/hadoop/pull/5596#issuecomment-1523375951
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716700#comment-17716700
]
ASF GitHub Bot commented on HADOOP-18695:
-
hadoop-yetus commented on PR #5548:
URL:
hadoop-yetus commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1523366082
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
caoergou commented on PR #5293:
URL: https://github.com/apache/hadoop/pull/5293#issuecomment-1523331494
still nobody review for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1523266310
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1523265310
ok, rebasing and pushing up with a commit to address most of the changes.
Not addressed: having timeouts on the offer/take of the EntryWriter in the
queue. I agree it is
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177727496
##
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177725376
##
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177721915
##
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177721536
##
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177720020
##
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177718895
##
slfan1989 opened a new pull request, #5598:
URL: https://github.com/apache/hadoop/pull/5598
JIRA: YARN-11437. [hotfix][Federation] SQLFederationStateStore Support
Version.
Fix CheckStyle Issue.
--
This is an automated message from the Apache Git Service.
To respond to the message,
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177718242
##
hfutatzhanghb opened a new pull request, #5597:
URL: https://github.com/apache/hadoop/pull/5597
### Description of PR
In our prod environment, we try to collect datanode metrics every 15s
through jmx_exporter. we found the datanodenetworkerror metric generates a lot.
for example,
slfan1989 opened a new pull request, #5596:
URL: https://github.com/apache/hadoop/pull/5596
JIRA: YARN-11379. [Federation] Support mapAttributesToNodes、getGroupsForUser
API's for Federation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Ujjawal Kumar created HADOOP-18720:
--
Summary: Publish test jar for hadoop-aws project
Key: HADOOP-18720
URL: https://issues.apache.org/jira/browse/HADOOP-18720
Project: Hadoop Common
Issue
hadoop-yetus commented on PR #5564:
URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1523093653
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5583:
URL: https://github.com/apache/hadoop/pull/5583#issuecomment-1523089889
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716619#comment-17716619
]
ASF GitHub Bot commented on HADOOP-18695:
-
steveloughran commented on PR #5548:
URL:
steveloughran commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1523060709
little bit of indentation
```
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java:160:
@Test:3: Method length is 154 lines
[
https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716618#comment-17716618
]
ASF GitHub Bot commented on HADOOP-18718:
-
steveloughran commented on PR #5592:
URL:
steveloughran commented on PR #5592:
URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1523055074
looks good. worried that a move to spotbugs may have surprises, but it is
only in 1 module and that already has a spotbugs by the look of things
--
This is an automated message
pjfanning opened a new pull request, #5595:
URL: https://github.com/apache/hadoop/pull/5595
### Description of PR
### How was this patch tested?
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g.
[
https://issues.apache.org/jira/browse/HADOOP-18719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PJ Fanning resolved HADOOP-18719.
-
Resolution: Duplicate
> upgrade snakeyaml to 2.0 (fixes CVE-2022-1471)
>
PJ Fanning created HADOOP-18719:
---
Summary: upgrade snakeyaml to 2.0 (fixes CVE-2022-1471)
Key: HADOOP-18719
URL: https://issues.apache.org/jira/browse/HADOOP-18719
Project: Hadoop Common
Issue
pjfanning commented on PR #5585:
URL: https://github.com/apache/hadoop/pull/5585#issuecomment-1523000989
@ayushtkn I did a new run - there was a merge conflict that needed fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #5585:
URL: https://github.com/apache/hadoop/pull/5585#issuecomment-1522990034
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb opened a new pull request, #5594:
URL: https://github.com/apache/hadoop/pull/5594
recently, we found lots of logs like below which trigger logWarn alarm：
```
WARN org.apache.hadoop.hdfs.StateChange: BLOCK* internalReleaseLease: All
existing blocks are COMPLETE, lease
[
https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716592#comment-17716592
]
ASF GitHub Bot commented on HADOOP-18359:
-
hadoop-yetus commented on PR #5095:
URL:
hadoop-yetus commented on PR #5095:
URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1522957405
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1522920461
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5593:
URL: https://github.com/apache/hadoop/pull/5593#issuecomment-1522898614
hi @ayushtkn @tomscut , sorry for disturbing you. now i have not add UT for
this change. could you please take a look at
hfutatzhanghb opened a new pull request, #5593:
URL: https://github.com/apache/hadoop/pull/5593
https://issues.apache.org/jira/browse/HDFS-16989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
91 matches
Mail list logo
