hadoop-yetus commented on PR #5652:
URL: https://github.com/apache/hadoop/pull/5652#issuecomment-1546535343
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5569:
URL: https://github.com/apache/hadoop/pull/5569#discussion_r1192914285
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeResourceChecker.java:
##
@@ -174,6 +174,19 @@ private void
slfan1989 commented on PR #5652:
URL: https://github.com/apache/hadoop/pull/5652#issuecomment-1546519509
> can you fix the checkstyle warning:
hadoop-yetus commented on PR #5652:
URL: https://github.com/apache/hadoop/pull/5652#issuecomment-1546514212
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 opened a new pull request, #5652:
URL: https://github.com/apache/hadoop/pull/5652
### Description of PR
JIRA: YARN-11495. Fix typos in hadoop-yarn-server-web-proxy.
While reading the code, I found some typo issues. This JIRA will fix these
issues in
slfan1989 commented on PR #5625:
URL: https://github.com/apache/hadoop/pull/5625#issuecomment-1546490322
@goiri Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
goiri commented on PR #5625:
URL: https://github.com/apache/hadoop/pull/5625#issuecomment-1546480133
Let's go with trunk then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
goiri merged PR #5625:
URL: https://github.com/apache/hadoop/pull/5625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goiri merged PR #5648:
URL: https://github.com/apache/hadoop/pull/5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ayushtkn commented on code in PR #5028:
URL: https://github.com/apache/hadoop/pull/5028#discussion_r1192841288
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClient.java:
##
@@ -22,77 +22,81 @@
ayushtkn commented on code in PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#discussion_r1192839897
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##
@@ -379,13 +380,18 @@ public static
ayushtkn merged PR #5628:
URL: https://github.com/apache/hadoop/pull/5628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szilard-nemeth commented on PR #5649:
URL: https://github.com/apache/hadoop/pull/5649#issuecomment-1546312317
@susheel-gupta
How do you mean you can't fetch those branches?
If you do git fetch and git branch -r you should see branch-3.2 and
branch-3.3 in the list.
You can also see
[
https://issues.apache.org/jira/browse/HADOOP-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HADOOP-18652:
-
Assignee: Viraj Jasani
> Path.suffix raises NullPointerException
>
hadoop-yetus commented on PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#issuecomment-1546170647
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#issuecomment-1546168747
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5647:
URL: https://github.com/apache/hadoop/pull/5647#issuecomment-1546110738
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#issuecomment-1546101936
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1546040307
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1546007574
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1545969724
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
tomicooler commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1192533938
##
tomicooler commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1192532531
##
hadoop-yetus commented on PR #5651:
URL: https://github.com/apache/hadoop/pull/5651#issuecomment-1545901335
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#issuecomment-1545857620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
brumi1024 commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1192439238
##
steveloughran merged PR #5650:
URL: https://github.com/apache/hadoop/pull/5650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1545802929
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
susheel-gupta commented on PR #5649:
URL: https://github.com/apache/hadoop/pull/5649#issuecomment-1545771995
@brumi1024 Yes, the emberJS version in branch-3.2
(https://github.com/apache/hadoop/blob/branch-3.2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/bower.json#L4)
hadoop-yetus commented on PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#issuecomment-1545756573
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5651:
URL: https://github.com/apache/hadoop/pull/5651#issuecomment-1545745262
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722161#comment-17722161
]
ASF GitHub Bot commented on HADOOP-18724:
-
hadoop-yetus commented on PR #5647:
URL:
hadoop-yetus commented on PR #5647:
URL: https://github.com/apache/hadoop/pull/5647#issuecomment-1545700556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722159#comment-17722159
]
ASF GitHub Bot commented on HADOOP-18739:
-
hadoop-yetus commented on PR #5640:
URL:
hadoop-yetus commented on PR #5640:
URL: https://github.com/apache/hadoop/pull/5640#issuecomment-1545689229
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1545687204
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722156#comment-17722156
]
ASF GitHub Bot commented on HADOOP-18739:
-
hadoop-yetus commented on PR #5640:
URL:
hadoop-yetus commented on PR #5640:
URL: https://github.com/apache/hadoop/pull/5640#issuecomment-1545674155
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Likkey commented on PR #5569:
URL: https://github.com/apache/hadoop/pull/5569#issuecomment-1545658915
@ayushtkn Hello, can u give me some advice:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
brumi1024 commented on PR #5649:
URL: https://github.com/apache/hadoop/pull/5649#issuecomment-1545657869
Thanks @susheel-gupta, merged to trunk. Can you please check if branch-3.3
and/or 3.2 has the same EmberJS version?
--
This is an automated message from the Apache Git Service.
To
brumi1024 merged PR #5649:
URL: https://github.com/apache/hadoop/pull/5649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Likkey commented on code in PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#discussion_r1192290936
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##
@@ -383,7 +384,9 @@ public ShortCircuitCache(int
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722147#comment-17722147
]
ASF GitHub Bot commented on HADOOP-18724:
-
hadoop-yetus commented on PR #5650:
URL:
hadoop-yetus commented on PR #5650:
URL: https://github.com/apache/hadoop/pull/5650#issuecomment-1545646943
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#issuecomment-1545604065
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1545585362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 opened a new pull request, #5651:
URL: https://github.com/apache/hadoop/pull/5651
### Description of PR
JIRA: YARN-11493. [Federation] ConfiguredRMFailoverProxyProvider Supports
Randomly Select an Router.
### How was this patch tested?
### For code
hadoop-yetus commented on PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1545509896
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#discussion_r1192144572
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServiceUtil.java:
hadoop-yetus commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545449348
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
zhtttylz commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1545445770
@slfan1989 Would you kindly assist in reviewing this PR once again?The
`Junit Test` error is not caused by our pr.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-18657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722087#comment-17722087
]
ASF GitHub Bot commented on HADOOP-18657:
-
steveloughran commented on PR #5462:
URL:
steveloughran commented on PR #5462:
URL: https://github.com/apache/hadoop/pull/5462#issuecomment-1545445339
reviewing this; too many other things have got in my way.
I agree, with create overwrite=false, we must fail with a concurrency error
what we don't want to do is
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18724:
Fix Version/s: 3.4.0
> Open file fails with NumberFormatException for S3AFileSystem
>
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18724:
Component/s: fs
fs/azure
> Open file fails with NumberFormatException
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722083#comment-17722083
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran opened a new pull request, #5650:
URL:
slfan1989 commented on code in PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#discussion_r1192123405
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/uam/TestUnmanagedApplicationManager.java:
steveloughran opened a new pull request, #5650:
URL: https://github.com/apache/hadoop/pull/5650
Somehow @Deprecated crept in.
### How was this patch tested?
letting yetus do it
### For code changes:
- [ ] Does the title or this PR starts with the
slfan1989 commented on code in PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#discussion_r1192122850
##
slfan1989 commented on code in PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#discussion_r1192108204
##
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722075#comment-17722075
]
ASF GitHub Bot commented on HADOOP-18637:
-
HarshitGupta11 commented on PR #5641:
URL:
HarshitGupta11 commented on PR #5641:
URL: https://github.com/apache/hadoop/pull/5641#issuecomment-1545412081
Hi @steveloughran,
1. Due to the merge resolution, the S3ABlockOutputStreamBuilder was not
being properly initialised, also the threadpool was not being initialised with
the
hadoop-yetus commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1545406253
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5649:
URL: https://github.com/apache/hadoop/pull/5649#issuecomment-1545353716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5643:
URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1545343969
>
Hi, @sodonnel . Sorry for replying late and thanks your reviewing. I totally
agree with you. Current fix still has problems, I will take a look at this
continuously.
susheel-gupta opened a new pull request, #5649:
URL: https://github.com/apache/hadoop/pull/5649
Change-Id: Iffd45222b073cc1bc35bbb3153ffe6583aefaa74
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or
simbadzina commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191935955
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java:
##
@@ -370,7 +372,9 @@ public static
67 matches
Mail list logo