hfutatzhanghb commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1420066021
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno)
hfutatzhanghb commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1419950588
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno)
hadoop-yetus commented on PR #6333:
URL: https://github.com/apache/hadoop/pull/6333#issuecomment-1846608430
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1419950588
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno)
xinglin commented on PR #6183:
URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1846575811
My understanding is a similar issue is happening here as what I tried to fix
in [HDFS-17030](https://issues.apache.org/jira/browse/HDFS-17030): when a JN is
not responsive (either it is
haiyang1987 opened a new pull request, #6333:
URL: https://github.com/apache/hadoop/pull/6333
### Description of PR
https://issues.apache.org/jira/browse/HDFS-17279
Fix link to Fedbalance document cannot be displayed.
--
This is an automated message from the Apache Git
haiyang1987 commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1419926052
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno) throws
hadoop-yetus commented on PR #6332:
URL: https://github.com/apache/hadoop/pull/6332#issuecomment-1846303719
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 opened a new pull request, #6332:
URL: https://github.com/apache/hadoop/pull/6332
### Description of PR
JIRA: YARN-11627. [GPG] Improve GPGPolicyFacade#getPolicyManager.
### How was this patch tested?
Add Junit Test.
### For code changes:
pjfanning commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1846123497
#6201 was merged - this can be closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794403#comment-17794403
]
ASF GitHub Bot commented on HADOOP-18975:
-
hadoop-yetus commented on PR #6277:
URL:
hadoop-yetus commented on PR #6277:
URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1845971887
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran merged PR #6063:
URL: https://github.com/apache/hadoop/pull/6063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1419369703
##
hadoop-client-modules/hadoop-client-minicluster/pom.xml:
##
@@ -400,6 +400,7 @@
org.mockito
mockito-core
+ ${mockito.version}
Review
[
https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794370#comment-17794370
]
ASF GitHub Bot commented on HADOOP-17377:
-
steveloughran commented on code in PR #5273:
URL:
steveloughran commented on code in PR #5273:
URL: https://github.com/apache/hadoop/pull/5273#discussion_r1419336218
##
hadoop-tools/hadoop-azure/pom.xml:
##
@@ -323,6 +323,13 @@
mockito-core
test
+
+
Review Comment:
is this needed? because its not in
[
https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794309#comment-17794309
]
ASF GitHub Bot commented on HADOOP-18975:
-
hadoop-yetus commented on PR #6277:
URL:
hadoop-yetus commented on PR #6277:
URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1845569277
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794302#comment-17794302
]
Steve Loughran commented on HADOOP-18915:
-
looking at the AWS SDK source, it looks like the
[
https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794284#comment-17794284
]
ASF GitHub Bot commented on HADOOP-18975:
-
hadoop-yetus commented on PR #6277:
URL:
hadoop-yetus commented on PR #6277:
URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1845512715
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794282#comment-17794282
]
ASF GitHub Bot commented on HADOOP-18540:
-
steveloughran commented on PR #5166:
URL:
steveloughran commented on PR #5166:
URL: https://github.com/apache/hadoop/pull/5166#issuecomment-1845510872
lets merge this and let spark cope themselves.
@dmmkr can you rebase and resubmit, this will force a retest of everything.
thanks
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/HADOOP-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794283#comment-17794283
]
Steve Loughran commented on HADOOP-18540:
-
[~BilwaST] ok, lets get that PR rebased for a retest
[
https://issues.apache.org/jira/browse/HADOOP-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794260#comment-17794260
]
ASF GitHub Bot commented on HADOOP-18989:
-
hadoop-yetus commented on PR #6294:
URL:
hadoop-yetus commented on PR #6294:
URL: https://github.com/apache/hadoop/pull/6294#issuecomment-1845475716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18925.
-
Fix Version/s: 3.4.0
3.3.9
Resolution: Fixed
> S3A: add
[
https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794254#comment-17794254
]
ASF GitHub Bot commented on HADOOP-18925:
-
steveloughran merged PR #6259:
URL:
steveloughran merged PR #6259:
URL: https://github.com/apache/hadoop/pull/6259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6326:
URL: https://github.com/apache/hadoop/pull/6326#issuecomment-1845424168
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6277:
URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1845383631
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794217#comment-17794217
]
ASF GitHub Bot commented on HADOOP-18975:
-
hadoop-yetus commented on PR #6277:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794210#comment-17794210
]
ASF GitHub Bot commented on HADOOP-18975:
-
hadoop-yetus commented on PR #6277:
URL:
hadoop-yetus commented on PR #6277:
URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1845349590
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #6304:
URL: https://github.com/apache/hadoop/pull/6304#issuecomment-1845320913
@goiri Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
slfan1989 merged PR #6304:
URL: https://github.com/apache/hadoop/pull/6304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18997.
-
Fix Version/s: 3.4.0
Resolution: Fixed
> S3A: Add option
[
https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794192#comment-17794192
]
ASF GitHub Bot commented on HADOOP-18997:
-
steveloughran merged PR #6316:
URL:
steveloughran merged PR #6316:
URL: https://github.com/apache/hadoop/pull/6316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6316:
URL: https://github.com/apache/hadoop/pull/6316#issuecomment-1845286527
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794175#comment-17794175
]
ASF GitHub Bot commented on HADOOP-18997:
-
hadoop-yetus commented on PR #6316:
URL:
hadoop-yetus commented on PR #6331:
URL: https://github.com/apache/hadoop/pull/6331#issuecomment-1845232330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
susheelgupta7 opened a new pull request, #6331:
URL: https://github.com/apache/hadoop/pull/6331
…MRMProxyTokenRenewal (#6310)
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the
ayushtkn commented on PR #5829:
URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1845117963
@Neilxzn I tried & it fails locally
```
[INFO] ---
[INFO] T E S T S
[INFO]
slfan1989 commented on PR #6298:
URL: https://github.com/apache/hadoop/pull/6298#issuecomment-1845077525
> @Hexiaoqiao @goiri @slfan1989 hi, If no more comments here, please help
merge it, thanks!
@KeeProMise I will merge this pr into the trunk branch tomorrow. Thank you
for your
[
https://issues.apache.org/jira/browse/HADOOP-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794114#comment-17794114
]
ASF GitHub Bot commented on HADOOP-18989:
-
hadoop-yetus commented on PR #6294:
URL:
hadoop-yetus commented on PR #6294:
URL: https://github.com/apache/hadoop/pull/6294#issuecomment-1845061852
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6329:
URL: https://github.com/apache/hadoop/pull/6329#issuecomment-1845007425
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6294:
URL: https://github.com/apache/hadoop/pull/6294#issuecomment-1844959603
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794100#comment-17794100
]
ASF GitHub Bot commented on HADOOP-18989:
-
hadoop-yetus commented on PR #6294:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794097#comment-17794097
]
Bilwa S T commented on HADOOP-18540:
There is a CVE for this - CVE-2023-33201. [~ste...@apache.org]
xinglin commented on PR #6290:
URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1844942867
Sounds good. I wasn't suggesting to revert/overwrite this commit. Just
wanted to put a note here to make it clear it was contributed by rav instead of
me. Rav was aware that I was doing
[
https://issues.apache.org/jira/browse/HADOOP-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794084#comment-17794084
]
ASF GitHub Bot commented on HADOOP-18989:
-
hfutatzhanghb commented on PR #6294:
URL:
hfutatzhanghb commented on PR #6294:
URL: https://github.com/apache/hadoop/pull/6294#issuecomment-1844903305
> LGTM. Only need to fix some code style.
Sir, Thanks a lot for your reviewing. The in-progress YETUS has fixed
checkstyle problems. We can wait for its completion.
--
hadoop-yetus commented on PR #6329:
URL: https://github.com/apache/hadoop/pull/6329#issuecomment-1844903765
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Hexiaoqiao commented on PR #6290:
URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1844900630
Hi @xinglin @rdingankar , It's not too bad, I will mark rdingankar as
Contributor at JIRA, and keep git message this time if you don't mind. Because
revert and checkin code repo again
hadoop-yetus commented on PR #6329:
URL: https://github.com/apache/hadoop/pull/6329#issuecomment-1844902702
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
yijut2 commented on code in PR #6329:
URL: https://github.com/apache/hadoop/pull/6329#discussion_r1418571351
##
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java:
##
@@ -31,8 +31,14 @@
import
ayushtkn commented on code in PR #6329:
URL: https://github.com/apache/hadoop/pull/6329#discussion_r1418532463
##
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java:
##
@@ -31,8 +31,14 @@
import
59 matches
Mail list logo