[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802042#comment-17802042 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1874956395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17314. Add a metrics to record congestion backoff counts. [hadoop]

2024-01-02 Thread via GitHub
hfutatzhanghb commented on PR #6398: URL: https://github.com/apache/hadoop/pull/6398#issuecomment-1874945130 Updated with unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-02 Thread via GitHub
xuzifu666 commented on PR #6402: URL: https://github.com/apache/hadoop/pull/6402#issuecomment-1874933861 > I have triggered a new build: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6402/2/ > > we need to get a green build before we can merge OK,Thanks -- This

Re: [PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-02 Thread via GitHub
ayushtkn commented on PR #6402: URL: https://github.com/apache/hadoop/pull/6402#issuecomment-1874932858 I have triggered a new build: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6402/2/ we need to get a green build before we can merge -- This is an automated

Re: [PR] HDFS-17305. Add avoid datanode reason count related metrics to namenode. [hadoop]

2024-01-02 Thread via GitHub
huangzhaobo99 commented on PR #6393: URL: https://github.com/apache/hadoop/pull/6393#issuecomment-1874927909 Hi @tasanuma @ayushtkn, Please kindly review this PR as well if you have bandwidth. thanks. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-02 Thread via GitHub
LiuGuH commented on code in PR #6390: URL: https://github.com/apache/hadoop/pull/6390#discussion_r1440125583 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -116,7 +116,7 @@ public class

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-02 Thread via GitHub
KeeProMise commented on PR #6380: URL: https://github.com/apache/hadoop/pull/6380#issuecomment-1874924983 @goiri @simbadzina hi, could you please help to review, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802026#comment-17802026 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1874921180 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [WARNING] Tests run: 141, Failures: 0,

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on code in PR #6390: URL: https://github.com/apache/hadoop/pull/6390#discussion_r1440105699 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -116,7 +116,7 @@ public class

Re: [PR] HDFS-17310. DiskBalancer: Enhance the log message for submitPlan [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on PR #6391: URL: https://github.com/apache/hadoop/pull/6391#issuecomment-1874893095 > Thanks @slfan1989 @ashutoshcipher help me reivew it. > Could you mind to push this modification forward when you have free time ? Thank you very much. @haiyang1987 Thanks

Re: [PR] HDFS-17306. RBF: Router should not return nameservices that does not enable observer nodes in RpcResponseHeaderProto [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6385: URL: https://github.com/apache/hadoop/pull/6385#issuecomment-1874843069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-01-02 Thread via GitHub
saxenapranav commented on code in PR #6314: URL: https://github.com/apache/hadoop/pull/6314#discussion_r1440069408 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsCountersImpl.java: ## @@ -63,6 +67,12 @@ public class AbfsCountersImpl implements

Re: [PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-02 Thread via GitHub
xuzifu666 commented on PR #6402: URL: https://github.com/apache/hadoop/pull/6402#issuecomment-1874801552 @ayushtkn Thanks for your review,could you help to merge it?CI seems hang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17311. RBF: ConnectionManager creatorQueue should offer a pool that is not already in creatorQueue. [hadoop]

2024-01-02 Thread via GitHub
LiuGuH commented on code in PR #6392: URL: https://github.com/apache/hadoop/pull/6392#discussion_r1440027525 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -229,7 +229,7 @@ public

Re: [PR] HDFS-17306. RBF: Router should not return nameservices that does not enable observer nodes in RpcResponseHeaderProto [hadoop]

2024-01-02 Thread via GitHub
LiuGuH commented on PR #6385: URL: https://github.com/apache/hadoop/pull/6385#issuecomment-1874794589 > @LiuGuH Thanks for your contribution! We need to fix checkstyle. Thanks for review. Fixed -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-02 Thread via GitHub
LiuGuH commented on code in PR #6390: URL: https://github.com/apache/hadoop/pull/6390#discussion_r1440022147 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -116,7 +116,7 @@ public class

Re: [PR] HDFS-17310. DiskBalancer: Enhance the log message for submitPlan [hadoop]

2024-01-02 Thread via GitHub
haiyang1987 commented on PR #6391: URL: https://github.com/apache/hadoop/pull/6391#issuecomment-1874777837 Thanks @slfan1989 @ashutoshcipher help me reivew it. Could you mind to push this modification forward when you have free time ? Thank you very much. -- This is an automated

[jira] [Commented] (HADOOP-19015) Increase fs.s3a.connection.maximum to 500 to minimize risk of Timeout waiting for connection from pool

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801986#comment-17801986 ] ASF GitHub Bot commented on HADOOP-19015: - hadoop-yetus commented on PR #6372: URL:

Re: [PR] HADOOP-19015. Increase fs.s3a.connection.maximum to 500 to minimize risk of Timeout waiting for connection from pool. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6372: URL: https://github.com/apache/hadoop/pull/6372#issuecomment-1874774309 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17290: add disconnected client rpc backoff metrics [hadoop]

2024-01-02 Thread via GitHub
li-leyang commented on PR #6359: URL: https://github.com/apache/hadoop/pull/6359#issuecomment-1874756402 @simbadzina Please take look. The yetus waring is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-11631. [GPG] Add GPGWebServices. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6354: URL: https://github.com/apache/hadoop/pull/6354#issuecomment-1874751236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17313. dfsadmin -reconfig option to start/query reconfig on all live namenodes. [hadoop]

2024-01-02 Thread via GitHub
huangzhaobo99 commented on PR #6395: URL: https://github.com/apache/hadoop/pull/6395#issuecomment-1874739359 Hi @tomscut @virajjasani If you have time, please help me review the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17290: add disconnected client rpc backoff metrics [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6359: URL: https://github.com/apache/hadoop/pull/6359#issuecomment-1874720576 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17311. RBF: ConnectionManager creatorQueue should offer a pool that is not already in creatorQueue. [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on code in PR #6392: URL: https://github.com/apache/hadoop/pull/6392#discussion_r1439961113 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -229,7 +229,7 @@ public

Re: [PR] HDFS-17311. RBF: ConnectionManager creatorQueue should offer a pool that is not already in creatorQueue. [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on code in PR #6392: URL: https://github.com/apache/hadoop/pull/6392#discussion_r1439961113 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -229,7 +229,7 @@ public

Re: [PR] YARN-11633.[Federation] Improve LoadBasedRouterPolicy To Use Available vcores. [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on PR #6356: URL: https://github.com/apache/hadoop/pull/6356#issuecomment-1874691119 > @slfan1989 Thank you for your reply, I will close this PR. Where can I contact you, such as wechat, and I will ask you some questions. Sorry for the late reply, we can contact

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-1874688435 > /new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html @hiwangzhihui I'll take a look at this later. I've been a little busy

Re: [PR] YARN-11632. [Doc] Add allow-partial-result description to Yarn Federation documentation. [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on PR #6340: URL: https://github.com/apache/hadoop/pull/6340#issuecomment-1874676533 @goiri Thank you very much for reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-11632. [Doc] Add allow-partial-result description to Yarn Federation documentation. [hadoop]

2024-01-02 Thread via GitHub
slfan1989 merged PR #6340: URL: https://github.com/apache/hadoop/pull/6340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17306. RBF: Router should not return nameservices that does not enable observer nodes in RpcResponseHeaderProto [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on PR #6385: URL: https://github.com/apache/hadoop/pull/6385#issuecomment-1874674522 @LiuGuH Thanks for your contribution! We need to fix checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-02 Thread via GitHub
slfan1989 commented on code in PR #6390: URL: https://github.com/apache/hadoop/pull/6390#discussion_r1439936960 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -116,7 +116,7 @@ public class

Re: [PR] HDFS-17290: add disconnected client rpc backoff metrics [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6359: URL: https://github.com/apache/hadoop/pull/6359#issuecomment-1874656850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17290: add disconnected client rpc backoff metrics [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6359: URL: https://github.com/apache/hadoop/pull/6359#issuecomment-1874656622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-01-02 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801945#comment-17801945 ] Mukund Thakur commented on HADOOP-19013: Well, this is an attribute. So setting it would be

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801928#comment-17801928 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832: URL:

Re: [PR] HADOOP-18184. S3A Prefetching unbuffer. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1874575178 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19015) Increase fs.s3a.connection.maximum to 500 to minimize risk of Timeout waiting for connection from pool

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801894#comment-17801894 ] ASF GitHub Bot commented on HADOOP-19015: - mukund-thakur commented on PR #6372: URL:

Re: [PR] HADOOP-19015. Increase fs.s3a.connection.maximum to 500 to minimize risk of Timeout waiting for connection from pool. [hadoop]

2024-01-02 Thread via GitHub
mukund-thakur commented on PR #6372: URL: https://github.com/apache/hadoop/pull/6372#issuecomment-1874398099 > * you'll need to rebase and rerun Yes, will do. > * did you accidentally commit this? Yes, committed by mistake but reverted right away. Sorry, it was dumb. -- This

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1874275707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17306. RBF: Router should not return nameservices that does not enable observer nodes in RpcResponseHeaderProto [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6385: URL: https://github.com/apache/hadoop/pull/6385#issuecomment-1874212168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801819#comment-17801819 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832: URL:

Re: [PR] HADOOP-18184. S3A Prefetching unbuffer. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1874162091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-1874062645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-1874055222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16420. Avoid deleting unique data blocks when deleting redundancy striped blocks. [hadoop]

2024-01-02 Thread via GitHub
LoseYSelf commented on PR #3880: URL: https://github.com/apache/hadoop/pull/3880#issuecomment-1874050010 > hello, @Jackson-Wang-7 Does this fix adapt to Hadoop 3.1 version? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17306. RBF: Router should not return nameservices that does not enable observer nodes in RpcResponseHeaderProto [hadoop]

2024-01-02 Thread via GitHub
LiuGuH commented on code in PR #6385: URL: https://github.com/apache/hadoop/pull/6385#discussion_r1439428230 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java: ## @@ -85,7 +85,11 @@ public void

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801770#comment-17801770 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1873984948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18991) Remove commons-beanutils dependency from Hadoop 3

2024-01-02 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801768#comment-17801768 ] Ayush Saxena commented on HADOOP-18991: --- >From hive perspective, I don't think removing this

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-1873967302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801766#comment-17801766 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1873952960 > LGTM +1 > > does need rebase to trunk before merging. Thanks for the review... Resolved Conflicts and did sanity check. Please merge with trunk. -- This is

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801765#comment-17801765 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1873952335 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [WARNING] Tests run: 141, Failures: 0,

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801760#comment-17801760 ] ASF GitHub Bot commented on HADOOP-18971: - steveloughran commented on PR #6270: URL:

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801759#comment-17801759 ] ASF GitHub Bot commented on HADOOP-18971: - hadoop-yetus commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-187397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2024-01-02 Thread via GitHub
steveloughran commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1873944811 > I think not only footer reads but this can be expanded to other prefetches as well. Especially small files that are read fully can be cached such that multiple streams can be

[jira] [Updated] (HADOOP-19021) [ABFS] move to jdk11 HttpClient for http2 and connection keep alive

2024-01-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19021: Summary: [ABFS] move to jdk11 HttpClient for http2 and connection keep alive (was: in

[jira] [Commented] (HADOOP-18991) Remove commons-beanutils dependency from Hadoop 3

2024-01-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801756#comment-17801756 ] Steve Loughran commented on HADOOP-18991: - so leave in branch-3.3 and noted as optional; cut

[jira] [Resolved] (HADOOP-19017) Setup pre-commit CI for Windows 10

2024-01-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19017. - Fix Version/s: 3.4.0 Resolution: Fixed > Setup pre-commit CI for Windows 10 >

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hiwangzhihui commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-1873902545 > @hiwangzhihui Can we fix `checkstyle` and `spotbugs` issue ? Because this PR involves changes to RM, we need to be more careful. Can we reproduce this issue? Can you provide some

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hiwangzhihui commented on code in PR #6352: URL: https://github.com/apache/hadoop/pull/6352#discussion_r1438289028 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hiwangzhihui commented on code in PR #6352: URL: https://github.com/apache/hadoop/pull/6352#discussion_r1438289028 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-02 Thread via GitHub
hiwangzhihui commented on code in PR #6352: URL: https://github.com/apache/hadoop/pull/6352#discussion_r1436500920 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:

Re: [PR] HDFS-16420. Avoid deleting unique data blocks when deleting redundancy striped blocks. [hadoop]

2024-01-02 Thread via GitHub
echomyecho commented on PR #3880: URL: https://github.com/apache/hadoop/pull/3880#issuecomment-1873890061 hello, @Jackson-Wang-7 Does this fix adapt to Hadoop 3.1 version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-01-02 Thread via GitHub
anmolanmol1234 commented on code in PR #6314: URL: https://github.com/apache/hadoop/pull/6314#discussion_r1439323259 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperationMockFailures.java: ## @@ -188,7 +187,7 @@ private void

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-01-02 Thread via GitHub
anmolanmol1234 commented on code in PR #6314: URL: https://github.com/apache/hadoop/pull/6314#discussion_r1439320952 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsCountersImpl.java: ## @@ -63,6 +67,12 @@ public class AbfsCountersImpl implements

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801725#comment-17801725 ] ASF GitHub Bot commented on HADOOP-18971: - anujmodi2021 commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1873834155 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [WARNING] Tests run: 141, Failures: 0,

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1873827133 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801721#comment-17801721 ] ASF GitHub Bot commented on HADOOP-18971: - anujmodi2021 commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1873811739 Regarding the cross-stream caching. Its sounds really good. I think not only footer reads but this can be expanded to other prefetches as well. Especially small files that

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801718#comment-17801718 ] ASF GitHub Bot commented on HADOOP-18971: - anujmodi2021 commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2024-01-02 Thread via GitHub
anujmodi2021 commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1873804668 > ok, you need to merge in trunk and it'll be good to go. > > Can you also add as a comment what the explicit text you want in the commit message. I'm thinking something like

Re: [PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-02 Thread via GitHub
xuzifu666 commented on PR #6402: URL: https://github.com/apache/hadoop/pull/6402#issuecomment-1873798203 @ayushtkn PTAL for the minor fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-02 Thread via GitHub
xuzifu666 opened a new pull request, #6402: URL: https://github.com/apache/hadoop/pull/6402 ### Description of PR DebugAdmin metaOut not need multiple close ### How was this patch tested? not need ### For code changes: - [ ] Does the title or this

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801707#comment-17801707 ] ASF GitHub Bot commented on HADOOP-17912: - saxenapranav commented on PR #6401: URL:

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context (#6221) [hadoop]

2024-01-02 Thread via GitHub
saxenapranav commented on PR #6401: URL: https://github.com/apache/hadoop/pull/6401#issuecomment-1873773458 @steveloughran , this is backport PR to branch-3.3 of https://github.com/apache/hadoop/pull/6221. Requesting your kind help in review and merge. Thank you so much. -- This is an

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801706#comment-17801706 ] ASF GitHub Bot commented on HADOOP-17912: - saxenapranav commented on PR #6221: URL:

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context [hadoop]

2024-01-02 Thread via GitHub
saxenapranav commented on PR #6221: URL: https://github.com/apache/hadoop/pull/6221#issuecomment-1873771485 Thank you much @steveloughran for reviewing and approving. Have raised https://github.com/apache/hadoop/pull/6401 for backport in branch-3.3. Thank you so much. -- This is an

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801704#comment-17801704 ] ASF GitHub Bot commented on HADOOP-17912: - saxenapranav commented on PR #6401: URL:

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context (#6221) [hadoop]

2024-01-02 Thread via GitHub
saxenapranav commented on PR #6401: URL: https://github.com/apache/hadoop/pull/6401#issuecomment-1873769791 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [ERROR] Failures: [ERROR]

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-02 Thread via GitHub
huangzhaobo99 commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1873747947 This warning is confusing for me, try passing it directly into FsImage to resolve this warning.

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801700#comment-17801700 ] ASF GitHub Bot commented on HADOOP-17912: - hadoop-yetus commented on PR #6401: URL:

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context (#6221) [hadoop]

2024-01-02 Thread via GitHub
hadoop-yetus commented on PR #6401: URL: https://github.com/apache/hadoop/pull/6401#issuecomment-1873747277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |