[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845542#comment-17845542 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2105598897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-10 Thread via GitHub
YaAYadeer commented on PR #6797: URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2105598177 The test class TestOfflineImageViewer already exists. TestOfflineImageViewer.testPBImageXmlWriter() method will call dumpXattrs when input parameter of dumpXattrs has xattrs. -- Thi

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 in /hadoop-project [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6811: URL: https://github.com/apache/hadoop/pull/6811#issuecomment-2105595427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] YARN-11689. Update the cgroup v2 init error handling [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6810: URL: https://github.com/apache/hadoop/pull/6810#issuecomment-2105549930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2105541751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845528#comment-17845528 ] ASF GitHub Bot commented on HADOOP-19156: - hadoop-yetus commented on PR #6767:

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2105500387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845520#comment-17845520 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2105337986 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2105313781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2105303552 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-13603: do not propagate ExecutionException and add maxRetries li… [hadoop]

2024-05-10 Thread via GitHub
CloudZY commented on code in PR #6774: URL: https://github.com/apache/hadoop/pull/6774#discussion_r1597249343 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java: ## @@ -601,18 +604,22 @@ public void run() {

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845511#comment-17845511 ] ASF GitHub Bot commented on HADOOP-19167: - hadoop-yetus commented on PR #6807:

Re: [PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6807: URL: https://github.com/apache/hadoop/pull/6807#issuecomment-2105295494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 in /hadoop-project [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6811: URL: https://github.com/apache/hadoop/pull/6811#issuecomment-2105184449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11689. Update the cgroup v2 init error handling [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6810: URL: https://github.com/apache/hadoop/pull/6810#issuecomment-2105173101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
ctrezzo commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1597137120 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-13603: do not propagate ExecutionException and add maxRetries li… [hadoop]

2024-05-10 Thread via GitHub
simbadzina commented on code in PR #6774: URL: https://github.com/apache/hadoop/pull/6774#discussion_r1597092684 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java: ## @@ -269,12 +269,23 @@ public ValueQueue(final int numValues,

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2105113000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
ctrezzo commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1596090988 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

[PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 in /hadoop-project [hadoop]

2024-05-10 Thread via GitHub
dependabot[bot] opened a new pull request, #6811: URL: https://github.com/apache/hadoop/pull/6811 Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.77 to 1.78. Changelog Sourced from https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html";>

[jira] [Commented] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845450#comment-17845450 ] ASF GitHub Bot commented on HADOOP-19156: - hadoop-yetus commented on PR #6767:

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2105055678 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] YARN-11689. Update the cgroup v2 init error handling [hadoop]

2024-05-10 Thread via GitHub
brumi1024 opened a new pull request, #6810: URL: https://github.com/apache/hadoop/pull/6810 ### Description of PR The cgroup v2 init error handling was updated to show the concrete step it failed, and also a bug was fixed that disallowed the automatic creation of the YARN cgr

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845404#comment-17845404 ] ASF GitHub Bot commented on HADOOP-19013: - hadoop-yetus commented on PR #6646:

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6646: URL: https://github.com/apache/hadoop/pull/6646#issuecomment-2104842997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845399#comment-17845399 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2104796915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-10 Thread via GitHub
ThinkerLei opened a new pull request, #6809: URL: https://github.com/apache/hadoop/pull/6809 In the lease monitor, if a file is closed, method checklease will return true, and then the edits log will not be sync. In my opinion, we should sync the edits log to avoid not synchronizing the sta

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2104748348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-10 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1596818926 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/C

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-10 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1596811423 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/T

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-10 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1596818926 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/C

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2104652320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6784: URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2104604443 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2104599790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HADOOP-19168. Upgrade kafka-client to 3.4.0 due to CVEs [hadoop]

2024-05-10 Thread via GitHub
rohit-kb opened a new pull request, #6808: URL: https://github.com/apache/hadoop/pull/6808 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP

[jira] [Commented] (HADOOP-19168) Upgrade Kafka Clients due to CVEs

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845303#comment-17845303 ] ASF GitHub Bot commented on HADOOP-19168: - rohit-kb opened a new pull request,

[jira] [Updated] (HADOOP-19168) Upgrade Kafka Clients due to CVEs

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19168: Labels: pull-request-available (was: ) > Upgrade Kafka Clients due to CVEs > ---

[jira] [Created] (HADOOP-19168) Upgrade Kafka Clients due to CVEs

2024-05-10 Thread Rohit Kumar (Jira)
Rohit Kumar created HADOOP-19168: Summary: Upgrade Kafka Clients due to CVEs Key: HADOOP-19168 URL: https://issues.apache.org/jira/browse/HADOOP-19168 Project: Hadoop Common Issue Type: Task

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-10 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1596579974 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java: ## @@ -1224,6 +1224,17 @@ public void testProxyCo

Re: [PR] HDFS-16368. DFSadmin supports refresh topology info without restarting namenode [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #3743: URL: https://github.com/apache/hadoop/pull/3743#issuecomment-2104271718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6797: URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2104197718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845243#comment-17845243 ] ASF GitHub Bot commented on HADOOP-19156: - hadoop-yetus commented on PR #6767:

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2104169307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845234#comment-17845234 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2104125153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845233#comment-17845233 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2104119250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2104068739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks