liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-681026137
@sguggilam
>and use false for both parameter?
Yeah, the second parameter actually is `true`, but you got what I meant
as the above code snippet. I have reverted
liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-681017115
@sguggilam We both agree on that we need to change all two callsites in UGI.
For the new API, if we keep it as it, is a bit confusing when user calls with
`false` value when
liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-680714535
@sguggilam When I backport the code, I went through the code again. I think
I found one bug. Before I revert the change, I want to confirm with you.
The new public API
liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-674491150
The patch looks good to me overall.
A question is: should we rename the word "force" with "ignoreTimeElapsed" to
make it clear. If agreed on it includes updating the
liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-670640493
Thanks @steveloughran I added Arpit and kihwal as reviewers.
This is an automated message from the Apache Git
