szilard-nemeth commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1575670756
Thanks @ferdelyi for working on this.
Latest patch LGTM, committed to trunk.
Thaknks @goiri for the review.
--
This is an automated message from the Apache Git Service.
To
szilard-nemeth commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555435928
Hi @ferdelyi ,
I added a couple of review comments.
Could you please also add comments to the test class (e.g. in javadoc) about
how the added certificate files, keystore
szilard-nemeth commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555433823
> Thank you Szilard for the CR.
>
> The change was exclusively tested with the unit test, which is a kind of
integration test, as a ZK Server was brought up and the
szilard-nemeth commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1544898512
Thanks for the patch @ferdelyi, good job.
Added some comments / questions.
Could you please add testing evidence to the Jira?
To document how this was tested on a real
