haiyang1987 commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2072033364
Committed to trunk. Thanks @KeeProMise for your contributions! and @ZanderXu
@simbadzina @ayushtkn @slfan1989 review!
--
This is an automated message from the Apache Git Service.
To
haiyang1987 merged PR #6697:
URL: https://github.com/apache/hadoop/pull/6697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
KeeProMise commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2072025405
@ZanderXu @haiyang1987 thanks for you review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ZanderXu commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2069092826
As I described in HDFS-17485, this spotbug should be fixed.
If there is no input type DNs, `dnCache` will return an empty result, not
null. So I thinks this modification is ok.
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1558805351
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1558805351
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
hadoop-yetus commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2046132702
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
simbadzina commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1558177674
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1552627925
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1089,13 +1089,7 @@ public
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1552627925
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1089,13 +1089,7 @@ public
ayushtkn commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1551269035
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1089,13 +1089,7 @@ public
slfan1989 commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1550647039
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1089,13 +1089,7 @@ public
hadoop-yetus commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2034207973
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
KeeProMise commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2033857932
@NickyYe hi, this method was committed by you. Do you have any suggestions?
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hadoop-yetus commented on PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2033529207
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1548840150
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1548840150
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
slfan1989 commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1548835509
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##
@@ -1090,7 +1090,7 @@ DatanodeInfo[]
18 matches
Mail list logo
