haiyang1987 commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2121550133
Committed to trunk.
Thanks @hfutatzhanghb for your contributions and @ZanderXu @ayushtkn review!
--
This is an automated message from the Apache Git Service.
To respond to the mes
haiyang1987 merged PR #6724:
URL: https://github.com/apache/hadoop/pull/6724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@h
ayushtkn commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2121001399
@haiyang1987 / @ZanderXu anyone hitting the merge button?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hadoop-yetus commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2101890001
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks _
hfutatzhanghb commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1591724020
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##
@@ -2028,7 +2028,7 @@ private Replica
haiyang1987 commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2097225735
LGTM. Leave some small comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
haiyang1987 commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1591717049
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##
@@ -2028,7 +2028,7 @@ private ReplicaIn
hadoop-yetus commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2083608127
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks _
hfutatzhanghb commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1582077047
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##
@@ -2091,14 +2092,16 @@ public void u
haiyang1987 commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1582072571
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##
@@ -2028,7 +2028,8 @@ private ReplicaIn
haiyang1987 commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1582072552
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##
@@ -2091,14 +2092,16 @@ public void unf
hfutatzhanghb commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2074091225
@zhangshuyan0 @ZanderXu @haiyang1987 Hi, sir. please help me reivew this
simple modification when you have free time, thanks~
--
This is an automated message from the Apache Git Se
hadoop-yetus commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2074072638
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks _
hadoop-yetus commented on PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2052146135
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hfutatzhanghb opened a new pull request, #6724:
URL: https://github.com/apache/hadoop/pull/6724
### Description of PR
Improve some logs output in class FsDatasetImpl, add block info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
15 matches
Mail list logo
