[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731381#comment-14731381 ] Andrew Wang commented on HADOOP-12358: -- +1 LGTM, I'll commit shortly > FSShell should prompt

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730032#comment-14730032 ] Xiaoyu Yao commented on HADOOP-12358: - [~andrew.wang], can you help review changes based on your

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726819#comment-14726819 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728112#comment-14728112 ] Xiaoyu Yao commented on HADOOP-12358: - [~aw], can you help review patch v7 to see if it addresses

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726208#comment-14726208 ] Andrew Wang commented on HADOOP-12358: -- Patch looks good overall, thanks for discussion everyone.

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723767#comment-14723767 ] Xiaoyu Yao commented on HADOOP-12358: - Thanks all for the review and feedbacks. Update to patch v6

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721486#comment-14721486 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721049#comment-14721049 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721185#comment-14721185 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718108#comment-14718108 ] Xiaoyu Yao commented on HADOOP-12358: - Thanks [~arpitagarwal] for the feedback.

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718131#comment-14718131 ] Xiaoyu Yao commented on HADOOP-12358: - Thanks [~aw] for the feedback. bq. doing

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720288#comment-14720288 ] Owen O'Malley commented on HADOOP-12358: I agree with Allen. This is a bad

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720074#comment-14720074 ] Allen Wittenauer commented on HADOOP-12358: --- bq.Only admins who want to use

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720341#comment-14720341 ] Xiaoyu Yao commented on HADOOP-12358: - Thanks [~aw] for the suggestions to improve

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717403#comment-14717403 ] Xiaoyu Yao commented on HADOOP-12358: - bq. Finally, to tie it back to your comment,

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717407#comment-14717407 ] Xiaoyu Yao commented on HADOOP-12358: - If the concern is for non-HDFS, we could do

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717481#comment-14717481 ] Arpit Agarwal commented on HADOOP-12358: There are three concerns from the Jira.

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717489#comment-14717489 ] Allen Wittenauer commented on HADOOP-12358: --- If automation really wants to

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717513#comment-14717513 ] Xiaoyu Yao commented on HADOOP-12358: - We could add -y, --yes, or --assume-yes to

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717862#comment-14717862 ] Allen Wittenauer commented on HADOOP-12358: --- Actually, now that I think about

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717842#comment-14717842 ] Arpit Agarwal commented on HADOOP-12358: bq. If automation really wants to

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715427#comment-14715427 ] Allen Wittenauer commented on HADOOP-12358: --- bq. What if these are not

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712569#comment-14712569 ] Xiaoyu Yao commented on HADOOP-12358: - Change to check getContentSummary for bulk

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715165#comment-14715165 ] Xiaoyu Yao commented on HADOOP-12358: - Summary of delta for patch v1: change to

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715145#comment-14715145 ] Xiaoyu Yao commented on HADOOP-12358: - Thanks [~aw] for the feedback. I really

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714488#comment-14714488 ] Xiaoyu Yao commented on HADOOP-12358: - bq. There's also some danger of client OOMs

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713589#comment-14713589 ] Allen Wittenauer commented on HADOOP-12358: --- bq.it's off by default in the

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715840#comment-14715840 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715867#comment-14715867 ] Andrew Wang commented on HADOOP-12358: -- bq. If the client OOM because of deleting

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716040#comment-14716040 ] Hadoop QA commented on HADOOP-12358: \\ \\ | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712427#comment-14712427 ] Xiaoyu Yao commented on HADOOP-12358: - @Andrew wang, thanks for the feedback. Good

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711810#comment-14711810 ] Allen Wittenauer commented on HADOOP-12358: --- This feature can't be on by

[jira] [Commented] (HADOOP-12358) FSShell should prompt before deleting directories bigger than a configured size

[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712283#comment-14712283 ] Andrew Wang commented on HADOOP-12358: -- [~aw] it's off by default in the patch, so