[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239875#comment-15239875
]
Elliott Clark commented on HADOOP-12973:
Thanks for all the reviews [~cmccabe]
> make DU
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238277#comment-15238277
]
Hudson commented on HADOOP-12973:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9601 (See
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238238#comment-15238238
]
Colin Patrick McCabe commented on HADOOP-12973:
---
The fact that the tests pass for me
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238106#comment-15238106
]
Elliott Clark commented on HADOOP-12973:
All test failures seem to be caused by:
{code}
Caused
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238090#comment-15238090
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236389#comment-15236389
]
Colin Patrick McCabe commented on HADOOP-12973:
---
Cool. Thanks, [~eclark]. +1 pending
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236134#comment-15236134
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233265#comment-15233265
]
Colin Patrick McCabe commented on HADOOP-12973:
---
Thanks, [~eclark]. Looks good! The
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233122#comment-15233122
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231286#comment-15231286
]
Elliott Clark commented on HADOOP-12973:
bq.but I don't want the WindowsDU to be a subclass of
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230762#comment-15230762
]
Colin Patrick McCabe commented on HADOOP-12973:
---
bq. It makes it more obvious when someone
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230772#comment-15230772
]
Colin Patrick McCabe commented on HADOOP-12973:
---
Part of the reason I believe there should
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230114#comment-15230114
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229725#comment-15229725
]
Elliott Clark commented on HADOOP-12973:
bq.There's no benefit to changing this class from
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229636#comment-15229636
]
Colin Patrick McCabe commented on HADOOP-12973:
---
Thanks, [~eclark]. Looks cool.
{code}
-
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229623#comment-15229623
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226327#comment-15226327
]
Wei-Chiu Chuang commented on HADOOP-12973:
--
I like the idea of adding a GetSpaceAvailable
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225291#comment-15225291
]
Colin Patrick McCabe commented on HADOOP-12973:
---
Hi [~eclark],
Good idea. This seems
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224594#comment-15224594
]
Elliott Clark commented on HADOOP-12973:
Ping? It would be nice to get this in so that the other
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220649#comment-15220649
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219138#comment-15219138
]
Gary Helmling commented on HADOOP-12973:
Probably should add {{InterfaceAudience}} and
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219018#comment-15219018
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218785#comment-15218785
]
Gary Helmling commented on HADOOP-12973:
In {{getInstance()}}, when invoking the configured
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218747#comment-15218747
]
Elliott Clark commented on HADOOP-12973:
bq.Hi Elliott Clark I wonder what was the concern about
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218718#comment-15218718
]
Wei-Chiu Chuang commented on HADOOP-12973:
--
Hi [~eclark] I wonder what was the concern about
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218676#comment-15218676
]
Elliott Clark commented on HADOOP-12973:
Added a test and cleaned up more checkstyle.
> make DU
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218584#comment-15218584
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217173#comment-15217173
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217146#comment-15217146
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216952#comment-15216952
]
Hadoop QA commented on HADOOP-12973:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
30 matches
Mail list logo
