[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527640#comment-15527640
]
Aaron Fabbri commented on HADOOP-13448:
---
Hey [~cnauroth] thanks for the feedback
{quote}
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527531#comment-15527531
]
Lei (Eddy) Xu commented on HADOOP-13448:
Hi, [~fabbri] Thanks for the proposals.
Regarding
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517772#comment-15517772
]
Aaron Fabbri commented on HADOOP-13448:
---
Thinking about this a bit more, I'm favoring option (C).
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510928#comment-15510928
]
Aaron Fabbri commented on HADOOP-13448:
---
Another interface thing to discuss is move(). I'm
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508089#comment-15508089
]
Chris Nauroth commented on HADOOP-13448:
+1 for a {{MetadataStore#initialize}} method accepting
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494750#comment-15494750
]
Mingliang Liu commented on HADOOP-13448:
+1 for the proposal. Thanks.
> S3Guard: Define
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494659#comment-15494659
]
Aaron Fabbri commented on HADOOP-13448:
---
Another design question. I'd like to propose we require
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491760#comment-15491760
]
Mingliang Liu commented on HADOOP-13448:
{quote}
I can make the change as part of the v2 patch
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491745#comment-15491745
]
Aaron Fabbri commented on HADOOP-13448:
---
I can make the change as part of the v2 patch for
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491728#comment-15491728
]
Mingliang Liu commented on HADOOP-13448:
Sure it's more flexible, though we're not exploring
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491708#comment-15491708
]
Mingliang Liu commented on HADOOP-13448:
Precisely. See my above comment. Ping [~cnauroth] for
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491710#comment-15491710
]
Aaron Fabbri commented on HADOOP-13448:
---
Ok, thanks. Another thing to consider is, I shouldn't
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491701#comment-15491701
]
Aaron Fabbri commented on HADOOP-13448:
---
i.e.
{code}
public class DynamoDBMetadataStore
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491699#comment-15491699
]
Mingliang Liu commented on HADOOP-13448:
Sorry I never thought out of the S3A box. It looks a
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491679#comment-15491679
]
Mingliang Liu commented on HADOOP-13448:
Are we moving the S3Guard out of S3A module someday? If
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491681#comment-15491681
]
Aaron Fabbri commented on HADOOP-13448:
---
Just saw your followup comment.
How about this idea: We
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491663#comment-15491663
]
Aaron Fabbri commented on HADOOP-13448:
---
[~liuml07] can you elaborate on why you prefer
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491653#comment-15491653
]
Chris Nauroth commented on HADOOP-13448:
Yes, I forgot about this point, which I encountered
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491649#comment-15491649
]
Mingliang Liu commented on HADOOP-13448:
Another point is that, DynamoDBMetadataStore should
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491636#comment-15491636
]
Mingliang Liu commented on HADOOP-13448:
I'd still prefer S3AFileSystem.
{quote}
envisioning
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491609#comment-15491609
]
Chris Nauroth commented on HADOOP-13448:
[~fabbri], yes, that sounds like a good idea. If you
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491603#comment-15491603
]
Aaron Fabbri commented on HADOOP-13448:
---
(Posting here since it is related, but I'd probably add
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477543#comment-15477543
]
Aaron Fabbri commented on HADOOP-13448:
---
[~cnauroth] would love to, thanks. Will try to commit
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477451#comment-15477451
]
Chris Nauroth commented on HADOOP-13448:
[~fabbri], thank you for the code review. Since this
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477444#comment-15477444
]
Aaron Fabbri commented on HADOOP-13448:
---
+1 on patch 005 (I'm only feature branch committer).
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477439#comment-15477439
]
Hadoop QA commented on HADOOP-13448:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475411#comment-15475411
]
Hadoop QA commented on HADOOP-13448:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475388#comment-15475388
]
Aaron Fabbri commented on HADOOP-13448:
---
bq. Yes, that makes sense. Would both get and put change
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475290#comment-15475290
]
Aaron Fabbri commented on HADOOP-13448:
---
Thanks for the patch [~cnauroth]. Looks good. Couple of
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469109#comment-15469109
]
Aaron Fabbri commented on HADOOP-13448:
---
{quote}Are you interested in doing another revision, or
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468963#comment-15468963
]
Chris Nauroth commented on HADOOP-13448:
[~fabbri], thanks for continuing work on this while I
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456742#comment-15456742
]
Hadoop QA commented on HADOOP-13448:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433626#comment-15433626
]
Aaron Fabbri commented on HADOOP-13448:
---
Thanks for the patch! Looks pretty good, especially since
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433301#comment-15433301
]
Lei (Eddy) Xu commented on HADOOP-13448:
Hi, [~cnauroth] The interface looks very nice. Just one
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432212#comment-15432212
]
Hadoop QA commented on HADOOP-13448:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416334#comment-15416334
]
Aaron Fabbri commented on HADOOP-13448:
---
Ok, cool. Sounds like we are on the same page. As I
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416136#comment-15416136
]
Chris Nauroth commented on HADOOP-13448:
bq. Why does your {{DynamoDBConsistentStore#save()}}
[
https://issues.apache.org/jira/browse/HADOOP-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415658#comment-15415658
]
Aaron Fabbri commented on HADOOP-13448:
---
To start the interface discussion:
I was looking at the
38 matches
Mail list logo
