[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411719#comment-16411719
]
Chris Douglas commented on HADOOP-14600:
bq. Without realizing you had already fixed this issue,
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411586#comment-16411586
]
Jonathan Eagles commented on HADOOP-14600:
--
[~myapachejira] Was taking a look at this exact bug
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275613#comment-16275613
]
Ping Liu commented on HADOOP-14600:
---
This is great to hear! Finally, this gets in. Thanks
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275443#comment-16275443
]
Hudson commented on HADOOP-14600:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13312 (See
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274962#comment-16274962
]
Chris Douglas commented on HADOOP-14600:
Thanks, [~myapachejira]. Glad to have that cleared up.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273970#comment-16273970
]
Ping Liu commented on HADOOP-14600:
---
Just verified. There is no error!
I missed {{-Pnative}} in
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268098#comment-16268098
]
Ping Liu commented on HADOOP-14600:
---
Yes, Chris. I am verifying the patch. There is an issue just
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267246#comment-16267246
]
Chris Douglas commented on HADOOP-14600:
bq. replace `listLocatedStatus` call with
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265476#comment-16265476
]
Ohad Raviv commented on HADOOP-14600:
-
I'm not sure I was clear enough in the above comment.
I
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264461#comment-16264461
]
Steve Loughran commented on HADOOP-14600:
-
doing a recursive walk like that will kill
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264406#comment-16264406
]
Ohad Raviv commented on HADOOP-14600:
-
Hi,
We also encountered a similar problem as SPARK-21137,
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263924#comment-16263924
]
Chris Douglas commented on HADOOP-14600:
lgtm, but if you have cycles to verify the patch, then
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263821#comment-16263821
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] Finally, this round is green. That's great! Do
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263136#comment-16263136
]
Hadoop QA commented on HADOOP-14600:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260386#comment-16260386
]
Chris Douglas commented on HADOOP-14600:
bq. The only question I have is the number of spaces
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257912#comment-16257912
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] excellent catch! Your correction is perfect.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256301#comment-16256301
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256234#comment-16256234
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239865#comment-16239865
]
Ping Liu commented on HADOOP-14600:
---
This time unit test fails on different test case
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239376#comment-16239376
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239375#comment-16239375
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239347#comment-16239347
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] You are right. {{path}} doesn't connect to
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236837#comment-16236837
]
Chris Douglas commented on HADOOP-14600:
Just skimmed the patch, but this line jumped out:
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235082#comment-16235082
]
Ping Liu commented on HADOOP-14600:
---
Can someone have a look at this? As I said before, the unit test
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192445#comment-16192445
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189239#comment-16189239
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186891#comment-16186891
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186875#comment-16186875
]
Ping Liu commented on HADOOP-14600:
---
[~ste...@apache.org]
Thanks for your detailed code review!
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171960#comment-16171960
]
Steve Loughran commented on HADOOP-14600:
-
I like where this is going, done another review.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160168#comment-16160168
]
Ping Liu commented on HADOOP-14600:
---
Changes has been made. *HADOOP-14600.002.patch* is attached.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157223#comment-16157223
]
Ping Liu commented on HADOOP-14600:
---
Excellent comments. I'm going to make the suggested changes.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156841#comment-16156841
]
Steve Loughran commented on HADOOP-14600:
-
bq. I got lots of cuts and blood with getting mvn
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154192#comment-16154192
]
Ping Liu commented on HADOOP-14600:
---
I couldn't successfully set up a local environment to run
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151289#comment-16151289
]
Ping Liu commented on HADOOP-14600:
---
Yeah, it must be automatically included with MingW, Visual
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151275#comment-16151275
]
Allen Wittenauer commented on HADOOP-14600:
---
bq. As I checked Program Files, I found there is
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151255#comment-16151255
]
Ping Liu commented on HADOOP-14600:
---
Thanks [~aw]! I have both Cygwin and Git. But Neither has
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151203#comment-16151203
]
Allen Wittenauer commented on HADOOP-14600:
---
You actually can run test-patch on Windows. I've
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151090#comment-16151090
]
Ping Liu commented on HADOOP-14600:
---
Now I am trying to do the patch test on my Windows. It looks
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150948#comment-16150948
]
Hadoop QA commented on HADOOP-14600:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150822#comment-16150822
]
Ping Liu commented on HADOOP-14600:
---
Hi [~jzhuge], thanks for your help!
The patch and the test file
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150811#comment-16150811
]
John Zhuge commented on HADOOP-14600:
-
Please follow the guidelines in
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150810#comment-16150810
]
John Zhuge commented on HADOOP-14600:
-
Hi [~myapachejira], added you to the contributor list and
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150254#comment-16150254
]
Ping Liu commented on HADOOP-14600:
---
Oops, looks like I don't have permission to attach files. I'll
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150245#comment-16150245
]
Ping Liu commented on HADOOP-14600:
---
I just followed [~steve_l]'s idea to add stat() native
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066510#comment-16066510
]
Steve Loughran commented on HADOOP-14600:
-
no, fstat() doesn't work, as it needs an open FD, and
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065441#comment-16065441
]
Steve Loughran commented on HADOOP-14600:
-
{{NativeIO.POSIX.getFstat}} should handle all of
46 matches
Mail list logo