[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283082#comment-16283082
]
Hudson commented on HADOOP-15056:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13346 (See
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283063#comment-16283063
]
Xiao Chen commented on HADOOP-15056:
Test failures look unrelated, committing this.
> Fix
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282537#comment-16282537
]
Jack Bearden commented on HADOOP-15056:
---
Thanks again [~jzhuge] and [~xiaochen] for all the help
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282508#comment-16282508
]
John Zhuge commented on HADOOP-15056:
-
+1 LGTM
> Fix TestUnbuffer#testUnbufferException failure
>
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282481#comment-16282481
]
Xiao Chen commented on HADOOP-15056:
Thanks for revving [~jackbearden], +1 on patch 7.
Any
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281909#comment-16281909
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281578#comment-16281578
]
Jack Bearden commented on HADOOP-15056:
---
Thanks [~xiaochen], patch #6 has fixes for the last
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281377#comment-16281377
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281185#comment-16281185
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281172#comment-16281172
]
Xiao Chen commented on HADOOP-15056:
Thanks for promptly revving [~jackbearden]! Looks good to me
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280817#comment-16280817
]
Jack Bearden commented on HADOOP-15056:
---
Really great feedback, thanks for reviewing the code
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279062#comment-16279062
]
Xiao Chen commented on HADOOP-15056:
Thanks [~jackbearden] for reporting and fixing this, and
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278301#comment-16278301
]
John Zhuge commented on HADOOP-15056:
-
Here is a table of all scenarios and the comparisons of
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273838#comment-16273838
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272479#comment-16272479
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272261#comment-16272261
]
Jack Bearden commented on HADOOP-15056:
---
Submitted patch #3 based on our latest comments. Let me
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272219#comment-16272219
]
Jack Bearden commented on HADOOP-15056:
---
What about the streams that call unbuffer() without the
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272192#comment-16272192
]
John Zhuge commented on HADOOP-15056:
-
IMHO, it is not a good idea to swallow CCE and just log.
In
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272135#comment-16272135
]
Jack Bearden commented on HADOOP-15056:
---
Ah ok, I understand. What are your thoughts on something
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272100#comment-16272100
]
John Zhuge commented on HADOOP-15056:
-
No worry. Good discussion.
IMPALA-5909 complained excessive
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271676#comment-16271676
]
Jack Bearden commented on HADOOP-15056:
---
Forgive me if I am being too pedantic... The way I see
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271601#comment-16271601
]
John Zhuge commented on HADOOP-15056:
-
StreamCapabilities was added by HDFS-11644. It is considered
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271432#comment-16271432
]
Jack Bearden commented on HADOOP-15056:
---
Hey [~jzhuge], hope your vacation was great. Thanks for
[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270689#comment-16270689
]
genericqa commented on HADOOP-15056:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
24 matches
Mail list logo
