[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767395#comment-16767395
]
Eric Yang commented on HADOOP-15229:
[~ste...@apache.org] the previous comment was filed as
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767082#comment-16767082
]
Steve Loughran commented on HADOOP-15229:
-
bq. Some trivial fix in javadoc is required
can you
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765266#comment-16765266
]
Eric Yang commented on HADOOP-15229:
Some trivial fix in javadoc is required.
> Add FileSystem
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760743#comment-16760743
]
Hudson commented on HADOOP-15229:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15888 (See
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760097#comment-16760097
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760038#comment-16760038
]
Steve Loughran commented on HADOOP-15229:
-
(I should add: I'm going w./ Aaron's +1 & everyone
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759776#comment-16759776
]
Steve Loughran commented on HADOOP-15229:
-
I'm going to merge in, but clarify the docs that
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759775#comment-16759775
]
Steve Loughran commented on HADOOP-15229:
-
ooh, thanks for the reviews everyone.
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752922#comment-16752922
]
Yuzhou Sun commented on HADOOP-15229:
-
Sorry I just noticed that: Should SelectInputStream#mark do
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751744#comment-16751744
]
Aaron Fabbri commented on HADOOP-15229:
---
I looked at the latest large patch today. Also played
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748145#comment-16748145
]
Gabor Bota commented on HADOOP-15229:
-
Hey [~ste...@apache.org], thanks for working on this, I've
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746835#comment-16746835
]
Aaron Fabbri commented on HADOOP-15229:
---
Thanks for the discussion [~ste...@apache.org]. No
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742624#comment-16742624
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742488#comment-16742488
]
Steve Loughran commented on HADOOP-15229:
-
FWIW, I think this PR can stop as "done" and leave
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740602#comment-16740602
]
Steve Loughran commented on HADOOP-15229:
-
# I'm thinking we could add an option
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736240#comment-16736240
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734967#comment-16734967
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734767#comment-16734767
]
Sameer Choudhary commented on HADOOP-15229:
---
[~ste...@apache.org]
{quote}OK. here's a
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734734#comment-16734734
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734576#comment-16734576
]
Yuzhou Sun commented on HADOOP-15229:
-
Thanks [~ste...@apache.org], "have the codec return MAX_INT"
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734396#comment-16734396
]
Steve Loughran commented on HADOOP-15229:
-
OK. here's a question: what is logged in the AWS S3
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733840#comment-16733840
]
Sameer Choudhary commented on HADOOP-15229:
---
[~ste...@apache.org]
> you can't do a seek to
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733598#comment-16733598
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733308#comment-16733308
]
Steve Loughran commented on HADOOP-15229:
-
h2. Aaron's comments
thanks for these: will address
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733319#comment-16733319
]
Steve Loughran commented on HADOOP-15229:
-
HADOOP-15226 patch 015
* WriteOperationsHelper
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732389#comment-16732389
]
Steve Loughran commented on HADOOP-15229:
-
thx for all the feedback, I'm back online & will
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728194#comment-16728194
]
Yuzhou Sun commented on HADOOP-15229:
-
Hey, sorry about the late reply, was on vacation.
About
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727091#comment-16727091
]
Sameer Choudhary commented on HADOOP-15229:
---
[~ste...@apache.org] Thanks for providing the
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726307#comment-16726307
]
Aaron Fabbri commented on HADOOP-15229:
---
Finished the rest of the v14 diff. Looks good overall. I
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726283#comment-16726283
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726235#comment-16726235
]
Aaron Fabbri commented on HADOOP-15229:
---
Nice work here, as usual [~ste...@apache.org].
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726157#comment-16726157
]
Aaron Fabbri commented on HADOOP-15229:
---
Applying and testing the v14 patch now while I read over
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726106#comment-16726106
]
Steve Loughran commented on HADOOP-15229:
-
I haven't quite done a retest on this specific
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725499#comment-16725499
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725355#comment-16725355
]
Steve Loughran commented on HADOOP-15229:
-
* CLI adds "-inputformat" "-outputformat " options,
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724607#comment-16724607
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724544#comment-16724544
]
Steve Loughran commented on HADOOP-15229:
-
Patch 012
* remove the ability to perform per-file
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723400#comment-16723400
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723291#comment-16723291
]
Steve Loughran commented on HADOOP-15229:
-
also: the per-file encryption settings complicates
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722637#comment-16722637
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718054#comment-16718054
]
Steve Loughran commented on HADOOP-15229:
-
Checkstyle
{code}
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712899#comment-16712899
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712760#comment-16712760
]
Steve Loughran commented on HADOOP-15229:
-
bq. Being able to change the properties of the
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707939#comment-16707939
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707860#comment-16707860
]
Owen O'Malley commented on HADOOP-15229:
My comment remains that it seems problematic having
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707682#comment-16707682
]
Steve Loughran commented on HADOOP-15229:
-
ps; interfaces and generic types are an evil
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707681#comment-16707681
]
Steve Loughran commented on HADOOP-15229:
-
* w.r.t probes for options, StreamCapabilities does
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707584#comment-16707584
]
Owen O'Malley commented on HADOOP-15229:
[~ste...@apache.org] with the problems were hitting,
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707096#comment-16707096
]
Steve Loughran commented on HADOOP-15229:
-
[~fabbri]
Thanks for the comments
bq. I'm
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707088#comment-16707088
]
Steve Loughran commented on HADOOP-15229:
-
Feedback from Miklos Gergely
bq. we don’t directly
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705291#comment-16705291
]
Aaron Fabbri commented on HADOOP-15229:
---
Looks good overall [~ste...@apache.org]. Good
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703305#comment-16703305
]
Steve Loughran commented on HADOOP-15229:
-
[~yuzhousun]
I'm ignoring the other formats in this
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703217#comment-16703217
]
Yuzhou Sun commented on HADOOP-15229:
-
Hey just some trivial comments about S3 Select part:
*
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702425#comment-16702425
]
Owen O'Malley commented on HADOOP-15229:
[~ste...@apache.org] using interfaces leaves us a lot
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701858#comment-16701858
]
Steve Loughran commented on HADOOP-15229:
-
[~owen.omalley], yes, I can do that. Because this
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701357#comment-16701357
]
Aaron Fabbri commented on HADOOP-15229:
---
Hey [~ste...@apache.org] been on vacation but will try
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700839#comment-16700839
]
Owen O'Malley commented on HADOOP-15229:
Sorry for coming into this late and for bike shedding.
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700733#comment-16700733
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699546#comment-16699546
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697907#comment-16697907
]
Steve Loughran commented on HADOOP-15229:
-
Patch 004 HADOOP-15229 + HADOOP-15364: checkstyles,
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697550#comment-16697550
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696276#comment-16696276
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696237#comment-16696237
]
Steve Loughran commented on HADOOP-15229:
-
Patch 003
This incorporates HADOOP-15364: S3
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675229#comment-16675229
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675070#comment-16675070
]
Hadoop QA commented on HADOOP-15229:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674929#comment-16674929
]
Steve Loughran commented on HADOOP-15229:
-
Patch 001.
* pulls up the core of
66 matches
Mail list logo
