[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-04-05 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427616#comment-16427616 ] Xiao Chen commented on HADOOP-15344: Makes sense. IMO that falls to API semantics - close should

[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-04-05 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427598#comment-16427598 ] Rushabh S Shah commented on HADOOP-15344: - bq. The exception from the failure is just logged and

[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-04-05 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427582#comment-16427582 ] Xiao Chen commented on HADOOP-15344: Thanks [~zhenyi] for working on this and [~shahrs87] for the

[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-03-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415673#comment-16415673 ] genericqa commented on HADOOP-15344: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-03-27 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415626#comment-16415626 ] Rushabh S Shah commented on HADOOP-15344: - Now I am thinking whether we should do this change.

[jira] [Commented] (HADOOP-15344) LoadBalancingKMSClientProvider#close should not swallow exceptions

2018-03-27 Thread fang zhenyi (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415496#comment-16415496 ] fang zhenyi commented on HADOOP-15344: -- Thanks [~xiaochen] and [~shahrs87] for reporting this. I